Re: RFR: 8243962: Various JVM TI tests time out using JFR on Windows [v2]

2020-10-18 Thread Serguei Spitsyn
On Sat, 17 Oct 2020 13:03:23 GMT, Markus Grönlund wrote: >> Greetings, >> >> JDK-8243962 has been a large effort to chase down intermittent timeouts for >> certain JVMTI tests when run on Windows >> debug builds in combination with JFR. The background is long, included in >> JDK-8243962. >> In

Re: RFR: 8246774: implement Record Classes as a standard feature in Java [v12]

2020-10-18 Thread Vicente Romero
> 8246774: implement Record Classes as a standard feature in Java Vicente Romero has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits: - Merge branch 'master' into JDK-8246774 - Merge branch 'master' into JDK-8246774 - removi

Re: RFR: 8246774: implement Record Classes as a standard feature in Java [v13]

2020-10-18 Thread Vicente Romero
> 8246774: implement Record Classes as a standard feature in Java Vicente Romero has updated the pull request incrementally with one additional commit since the last revision: removing reference to unused jcod file from test - Changes: - all: https://git.openjdk.java.net/jdk/pu

Integrated: 8246774: implement Record Classes as a standard feature in Java

2020-10-18 Thread Vicente Romero
On Mon, 21 Sep 2020 21:30:51 GMT, Vicente Romero wrote: > 8246774: implement Record Classes as a standard feature in Java This pull request has now been integrated. Changeset: c17d5851 Author:Vicente Romero URL: https://git.openjdk.java.net/jdk/commit/c17d5851 Stats: 856 lines in

Re: RFR: 8243962: Various JVM TI tests time out using JFR on Windows [v2]

2020-10-18 Thread Chris Plummer
On Sat, 17 Oct 2020 13:03:23 GMT, Markus Grönlund wrote: >> Greetings, >> >> JDK-8243962 has been a large effort to chase down intermittent timeouts for >> certain JVMTI tests when run on Windows >> debug builds in combination with JFR. The background is long, included in >> JDK-8243962. >> In

Re: RFR: 8252657: JVMTI agent is not unloaded when Agent_OnAttach is failed

2020-10-18 Thread Yasumasa Suenaga
On Fri, 2 Oct 2020 07:27:43 GMT, Yasumasa Suenaga wrote: >> I was initially wrong by supporting this, and now I share David's concerns >> about unclear semantics of this. The >> questions are: >> - Q1: Is it necessary to call the Agent_OnUnload()? >> - Q2: Would it be a JVMTI spec violation to

Re: RFR: 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents [v13]

2020-10-18 Thread Richard Reingruber
> Hi, > > this is the continuation of the review of the implementation for: > > https://bugs.openjdk.java.net/browse/JDK-8227745 > https://bugs.openjdk.java.net/browse/JDK-8233915 > > It allows for JIT optimizations based on escape analysis even if JVMTI agents > acquire capabilities to access

Re: RFR: 8254776: Remove unimplemented LowMemoryDetector::check_memory_usage [v2]

2020-10-18 Thread Aleksey Shipilev
> `LowMemoryDetector::check_memory_usage` seems declared but not implemented. > Current history does not show any > definitions since the initial load. Can be removed. > Testing: > - [x] Linux x86_64 build > - [x] Test search for `check_memory_usage` in `src/hotspot` Aleksey Shipilev has update

Re: RFR: 8253525: Implement getInstanceSize/sizeOf intrinsics [v2]

2020-10-18 Thread Aleksey Shipilev
> This is fork off the SizeOf JEP, JDK-8249196. There is already the entry > point in JDK that can use the intrinsic like > this: `Instrumentation.getInstanceSize`. Therefore, we can implement the > C1/C2 intrinsic now, hook it up to > `Instrumentation`, and let the tools use that fast path today