Re: RFR: 8066622 8066637: remove deprecated using java.io.File.toURL() in internal classes

2020-11-08 Thread Phil Race
On Sat, 7 Nov 2020 07:55:03 GMT, Sebastian Ritter wrote: > In result of Javadoc to do not use java.io.File.toURL() > Change use java.io.File.toURL().toURI() instead. You reference a desktop bug that discusses many, many deprecations and skara has identified https://bugs.openjdk.java.net/browse

Re: RFR: 8253064: monitor list simplifications and getting rid of TSM [v2]

2020-11-08 Thread David Holmes
On Sat, 7 Nov 2020 17:55:34 GMT, Daniel D. Daugherty wrote: >> src/hotspot/share/runtime/synchronizer.hpp line 173: >> >>> 171: >>> 172: static MonitorList _in_use_list; >>> 173: static jint _in_use_list_ceiling; >> >> Can you add some commentary on what this ceiling is as I cou

Re: RFR: 8253064: monitor list simplifications and getting rid of TSM

2020-11-08 Thread David Holmes
Hi Dan, On 8/11/2020 3:40 am, Daniel D.Daugherty wrote: On Fri, 6 Nov 2020 02:31:12 GMT, David Holmes wrote: Changes from @fisk and @dcubed-ojdk to: - simplify ObjectMonitor list management - get rid of Type-Stable Memory (TSM) This change has been tested with Mach5 Tier[1-3],4,5,6,7,8; no

Re: RFR: 8253064: monitor list simplifications and getting rid of TSM [v2]

2020-11-08 Thread Daniel D . Daugherty
On Sat, 7 Nov 2020 18:01:57 GMT, Daniel D. Daugherty wrote: >> Hi Dan, >> >> Overall this looks great. Comparing old and new code is complex but the new >> code on its own is generally much simpler/clearer (not all though :) ). >> >> I have a few nits, comments and queries below. >> >> Thanks

Re: RFR: 8253064: monitor list simplifications and getting rid of TSM [v2]

2020-11-08 Thread Daniel D . Daugherty
On Sun, 8 Nov 2020 21:43:00 GMT, David Holmes wrote: >> How about this: >> static MonitorList _in_use_list; >> // The ratio of the current _in_use_list count to the ceiling is used >> // to determine if we are above MonitorUsedDeflationThreshold and need >> // to do an async monitor def

Re: RFR: 8253064: monitor list simplifications and getting rid of TSM [v2]

2020-11-08 Thread David Holmes
Hi Dan, On 9/11/2020 1:50 pm, Daniel D.Daugherty wrote: On Sun, 8 Nov 2020 21:43:00 GMT, David Holmes wrote: How about this: static MonitorList _in_use_list; // The ratio of the current _in_use_list count to the ceiling is used // to determine if we are above MonitorUsedDeflationTh