Integrated: 8256337: ap01t001.cpp, 67: Received unexpected number of ObjectFree events: 7

2020-11-16 Thread Stefan Karlsson
On Fri, 13 Nov 2020 14:11:23 GMT, Stefan Karlsson wrote: > The ap01t001 test creates six extra instances of the tested class, let them > die, and then checks that it gets exactly six ObjectFree callbacks. The > problem is that this is verified in the VMDeath callback and at that point > the in

Re: RFR: 8256337: ap01t001.cpp, 67: Received unexpected number of ObjectFree events: 7

2020-11-16 Thread Stefan Karlsson
On Fri, 13 Nov 2020 19:25:57 GMT, Serguei Spitsyn wrote: >> The ap01t001 test creates six extra instances of the tested class, let them >> die, and then checks that it gets exactly six ObjectFree callbacks. The >> problem is that this is verified in the VMDeath callback and at that point >> th

Re: RFR: 8244679: JVM/TI GetCurrentContendedMonitor/contmon001 failed due to "(IsSameObject#3) unexpected monitor object: 0x000000562336DBA8" [v2]

2020-11-16 Thread David Holmes
On 16/11/2020 5:57 pm, Robbin Ehn wrote: On Mon, 16 Nov 2020 04:50:13 GMT, David Holmes wrote: test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetCurrentContendedMonitor/contmon001.java line 67: 65: public static int run(String argv[], PrintStream ref) { 66: out = ref; 67: doSlee

Re: RFR: 8244679: JVM/TI GetCurrentContendedMonitor/contmon001 failed due to "(IsSameObject#3) unexpected monitor object: 0x000000562336DBA8" [v2]

2020-11-16 Thread Serguei Spitsyn
On Thu, 12 Nov 2020 08:11:10 GMT, Robbin Ehn wrote: >> As the stack trace in the bug shows, we cannot load classes, since we may >> take a monitor. >> Resulting in an unexpected result to GetCurrentContendedMonitor(). >> Trying to use some decent primitive, e.g. Wicket/Semaphore/.., without bein

Re: RFR: 8244679: JVM/TI GetCurrentContendedMonitor/contmon001 failed due to "(IsSameObject#3) unexpected monitor object: 0x000000562336DBA8" [v2]

2020-11-16 Thread Robbin Ehn
On Mon, 16 Nov 2020 08:26:29 GMT, Serguei Spitsyn wrote: >> Robbin Ehn has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed comment > > Robbin, thank you for nice analysis in the the bug report. > The fix looks good. > Thanks, > Serguei

Re: RFR: 8244679: JVM/TI GetCurrentContendedMonitor/contmon001 failed due to "(IsSameObject#3) unexpected monitor object: 0x000000562336DBA8" [v3]

2020-11-16 Thread Robbin Ehn
> As the stack trace in the bug shows, we cannot load classes, since we may > take a monitor. > Resulting in an unexpected result to GetCurrentContendedMonitor(). > Trying to use some decent primitive, e.g. Wicket/Semaphore/.., without being > implementation dependent means we must warm up every

Re: RFR: 8253081: G1 fails on stale objects in archived module graph in Open Archive regions

2020-11-16 Thread Kim Barrett
On Wed, 11 Nov 2020 11:39:59 GMT, Thomas Schatzl wrote: > Hi all, > > can I have reviews for this change that changes the way how archive regions > are managed in general and specifically by the G1 collector, fixing the > crashes caused by adding the module graph into the archive in > [JDK-

Re: RFR: 8253081: G1 fails on stale objects in archived module graph in Open Archive regions [v2]

2020-11-16 Thread Thomas Schatzl
> Hi all, > > can I have reviews for this change that changes the way how archive regions > are managed in general and specifically by the G1 collector, fixing the > crashes caused by adding the module graph into the archive in > [JDK-8244778](https://bugs.openjdk.java.net/browse/JDK-8244778)

Re: RFR: 8253081: G1 fails on stale objects in archived module graph in Open Archive regions [v3]

2020-11-16 Thread Thomas Schatzl
> Hi all, > > can I have reviews for this change that changes the way how archive regions > are managed in general and specifically by the G1 collector, fixing the > crashes caused by adding the module graph into the archive in > [JDK-8244778](https://bugs.openjdk.java.net/browse/JDK-8244778)

Re: RFR: 8253081: G1 fails on stale objects in archived module graph in Open Archive regions [v3]

2020-11-16 Thread Thomas Schatzl
On Mon, 16 Nov 2020 09:34:51 GMT, Kim Barrett wrote: >> Thomas Schatzl has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains three commits: >> >> - Merge branch 'master' of https://git.openjdk.java.net/jdk into >> 8253081-null-narrow-

Integrated: 8244679: JVM/TI GetCurrentContendedMonitor/contmon001 failed due to "(IsSameObject#3) unexpected monitor object: 0x000000562336DBA8"

2020-11-16 Thread Robbin Ehn
On Wed, 11 Nov 2020 20:33:15 GMT, Robbin Ehn wrote: > As the stack trace in the bug shows, we cannot load classes, since we may > take a monitor. > Resulting in an unexpected result to GetCurrentContendedMonitor(). > Trying to use some decent primitive, e.g. Wicket/Semaphore/.., without being >

Re: RFR: 8212879: Make JVMTI TagMap table concurrent [v9]

2020-11-16 Thread Coleen Phillimore
> This change turns the HashTable that JVMTI uses for object tagging into a > regular Hotspot hashtable - the one in hashtable.hpp with resizing and > rehashing. Instead of pointing directly to oops so that GC has to walk the > table to follow oops and then to rehash the table, this table poin

Re: RFR: 8212879: Make JVMTI TagMap table concurrent [v10]

2020-11-16 Thread Coleen Phillimore
> This change turns the HashTable that JVMTI uses for object tagging into a > regular Hotspot hashtable - the one in hashtable.hpp with resizing and > rehashing. Instead of pointing directly to oops so that GC has to walk the > table to follow oops and then to rehash the table, this table poin

Re: RFR: 8212879: Make JVMTI TagMap table concurrent [v4]

2020-11-16 Thread Coleen Phillimore
On Thu, 5 Nov 2020 14:36:44 GMT, Erik Ă–sterlund wrote: >> Ok, so there were many test failures with other approaches. Having GC >> trigger the posting was the most reliable way to post the events when the >> tests (and presumably the jvmti customers) expected the events to be posted. >> We c

Re: RFR: 8212879: Make JVMTI TagMap table concurrent [v6]

2020-11-16 Thread Coleen Phillimore
On Mon, 9 Nov 2020 20:39:40 GMT, Coleen Phillimore wrote: >> Thanks @sspitsyn . I'm going to leave the gc_notification code because >> structurally the two sides of the if statement are different and it's not a >> long function. Thank you for reviewing the change. > > This change also passes

Re: RFR: 8212879: Make JVMTI TagMap table concurrent [v11]

2020-11-16 Thread Coleen Phillimore
> This change turns the HashTable that JVMTI uses for object tagging into a > regular Hotspot hashtable - the one in hashtable.hpp with resizing and > rehashing. Instead of pointing directly to oops so that GC has to walk the > table to follow oops and then to rehash the table, this table poin

Re: RFR: 8212879: Make JVMTI TagMap table concurrent [v11]

2020-11-16 Thread Kim Barrett
On Mon, 16 Nov 2020 23:30:25 GMT, Coleen Phillimore wrote: >> This change turns the HashTable that JVMTI uses for object tagging into a >> regular Hotspot hashtable - the one in hashtable.hpp with resizing and >> rehashing. Instead of pointing directly to oops so that GC has to walk the >> t