RFR: 8255987: JDI tests fail with com.sun.jdi.ObjectCollectedException

2020-11-20 Thread Per Liden
A number of JDI tests create objects on the debugger side with calls to `newInstance()`. However, on the debugee side, these new instances will only be held on to by a `JNIGlobalWeakRef`, which means they could be collected at any time, even before `newInstace()` returns. A number of JDI tests d

RFR: 8256741: Reduce footprint of compiler interface data structures

2020-11-20 Thread Claes Redestad
A few data structure in the ci allocate unconditionally created GrowableArrays out-of-line, have fields that are newer updated/read, or are unnecessarily cached. By cleaning this up we can slightly reduce memory used for JIT compilations while slightly speeding them up. - Commit me

Re: RFR: 8255934: JConsole 14 and greater fails to connect to older JVM

2020-11-20 Thread Chris Plummer
On Mon, 16 Nov 2020 23:00:05 GMT, Alex Menkov wrote: > OperatingSystemMXBean was changed in jdk14 (see JDK-8226575): > New methods getTotalMemorySize and getFreeMemorySize were added, old > getTotalPhysicalMemorySize and getFreePhysicalMemorySize were deprecated. > > The fix adds fallbacks for

Re: RFR: 8255934: JConsole 14 and greater fails to connect to older JVM

2020-11-20 Thread Alex Menkov
On Fri, 20 Nov 2020 21:55:43 GMT, Chris Plummer wrote: >> OperatingSystemMXBean was changed in jdk14 (see JDK-8226575): >> New methods getTotalMemorySize and getFreeMemorySize were added, old >> getTotalPhysicalMemorySize and getFreePhysicalMemorySize were deprecated. >> >> The fix adds fallbac

Re: RFR: 8256741: Reduce footprint of compiler interface data structures

2020-11-20 Thread Chris Plummer
On Fri, 20 Nov 2020 12:19:48 GMT, Claes Redestad wrote: > A few data structure in the ci allocate unconditionally created > GrowableArrays out-of-line, have fields that are newer updated/read, or are > unnecessarily cached. By cleaning this up we can slightly reduce memory used > for JIT compi

Re: RFR: 8255934: JConsole 14 and greater fails to connect to older JVM

2020-11-20 Thread Chris Plummer
On Mon, 16 Nov 2020 23:00:05 GMT, Alex Menkov wrote: > OperatingSystemMXBean was changed in jdk14 (see JDK-8226575): > New methods getTotalMemorySize and getFreeMemorySize were added, old > getTotalPhysicalMemorySize and getFreePhysicalMemorySize were deprecated. > > The fix adds fallbacks for

Re: RFR: 8256741: Reduce footprint of compiler interface data structures

2020-11-20 Thread Claes Redestad
On Fri, 20 Nov 2020 22:21:04 GMT, Chris Plummer wrote: >> A few data structure in the ci allocate unconditionally created >> GrowableArrays out-of-line, have fields that are newer updated/read, or are >> unnecessarily cached. By cleaning this up we can slightly reduce memory used >> for JIT co

Re: RFR: 8256741: Reduce footprint of compiler interface data structures

2020-11-20 Thread Chris Plummer
On Fri, 20 Nov 2020 12:19:48 GMT, Claes Redestad wrote: > A few data structure in the ci allocate unconditionally created > GrowableArrays out-of-line, have fields that are newer updated/read, or are > unnecessarily cached. By cleaning this up we can slightly reduce memory used > for JIT compi

Re: RFR: 8256741: Reduce footprint of compiler interface data structures

2020-11-20 Thread Chris Plummer
On Fri, 20 Nov 2020 22:39:19 GMT, Claes Redestad wrote: >> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/ci/ciObjectFactory.java >> line 82: >> >>> 80: public GrowableArray symbols() { >>> 81: Address addr = getAddress().addOffsetTo(symbolsField.getOffset()); >>> 82: return Grow

Re: RFR: 8256741: Reduce footprint of compiler interface data structures

2020-11-20 Thread Vladimir Kozlov
On Fri, 20 Nov 2020 12:19:48 GMT, Claes Redestad wrote: > A few data structure in the ci allocate unconditionally created > GrowableArrays out-of-line, have fields that are newer updated/read, or are > unnecessarily cached. By cleaning this up we can slightly reduce memory used > for JIT compi

Re: RFR: 8255934: JConsole 14 and greater fails to connect to older JVM

2020-11-20 Thread Serguei Spitsyn
On Mon, 16 Nov 2020 23:00:05 GMT, Alex Menkov wrote: > OperatingSystemMXBean was changed in jdk14 (see JDK-8226575): > New methods getTotalMemorySize and getFreeMemorySize were added, old > getTotalPhysicalMemorySize and getFreePhysicalMemorySize were deprecated. > > The fix adds fallbacks for

Integrated: 8255934: JConsole 14 and greater fails to connect to older JVM

2020-11-20 Thread Alex Menkov
On Mon, 16 Nov 2020 23:00:05 GMT, Alex Menkov wrote: > OperatingSystemMXBean was changed in jdk14 (see JDK-8226575): > New methods getTotalMemorySize and getFreeMemorySize were added, old > getTotalPhysicalMemorySize and getFreePhysicalMemorySize were deprecated. > > The fix adds fallbacks for

Re: RFR: 8256450: Add gz option to jmap to write a gzipped heap dump [v5]

2020-11-20 Thread Serguei Spitsyn
On Fri, 20 Nov 2020 01:17:18 GMT, Lin Zang wrote: >> This PR add "gz" option to jmap -dump command to support generate gzipped >> heap dump. >> >> example: >> jmap -dump:live,gz=1,file=dump.gz > > Lin Zang has updated the pull request incrementally with one additional > commit since the

Re: RFR: 8256364: vmTestbase/nsk/jvmti/scenarios/capability/CM01/cm01t002 failed with "assert(handle != __null) failed: JNI handle should not be null"

2020-11-20 Thread Alex Menkov
On Thu, 19 Nov 2020 22:26:38 GMT, Chris Plummer wrote: >> Looks good. > > Why does this PR show 5 commits, including one that looks like it was for a > previously fixed CR? It looks maybe you reused a branch. In the end it looks > like skara did the right thing, and the diff looks right, but th

Withdrawn: 8256364: vmTestbase/nsk/jvmti/scenarios/capability/CM01/cm01t002 failed with "assert(handle != __null) failed: JNI handle should not be null"

2020-11-20 Thread Alex Menkov
On Thu, 19 Nov 2020 21:49:09 GMT, Alex Menkov wrote: > - fixed java part of the test to handle spurious wakeups in the debuggee > thread; > - fixed native part of the test to detect and report the case when debuggee > thread not found. This pull request has been closed without being integrated

Re: RFR: 8256450: Add gz option to jmap to write a gzipped heap dump [v5]

2020-11-20 Thread Lin Zang
On Fri, 20 Nov 2020 02:57:55 GMT, Chris Plummer wrote: >> Lin Zang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove unnecessory arguments in verifyDump() > > Marked as reviewed by cjplummer (Reviewer). Thank @plummercj and @sspits

RFR: 8256364: vmTestbase/nsk/jvmti/scenarios/capability/CM01/cm01t002 failed with "assert(handle != __null) failed: JNI handle should not be null"

2020-11-20 Thread Alex Menkov
Resending the RFR without unexpected extra commits - fixed java part of the test to handle spurious wakeups in the debuggee thread; - fixed native part of the test to detect and report the case when debuggee thread not found. - Commit messages: - Fixed cm01t002 Changes: https://gi

Re: RFR: 8256364: vmTestbase/nsk/jvmti/scenarios/capability/CM01/cm01t002 failed with "assert(handle != __null) failed: JNI handle should not be null"

2020-11-20 Thread Chris Plummer
On Sat, 21 Nov 2020 01:54:58 GMT, Alex Menkov wrote: > Resending the RFR without unexpected extra commits > > - fixed java part of the test to handle spurious wakeups in the debuggee > thread; > - fixed native part of the test to detect and report the case when debuggee > thread not found. Ma

Re: RFR: 8256364: vmTestbase/nsk/jvmti/scenarios/capability/CM01/cm01t002 failed with "assert(handle != __null) failed: JNI handle should not be null"

2020-11-20 Thread Serguei Spitsyn
On Sat, 21 Nov 2020 01:54:58 GMT, Alex Menkov wrote: > Resending the RFR without unexpected extra commits > > - fixed java part of the test to handle spurious wakeups in the debuggee > thread; > - fixed native part of the test to detect and report the case when debuggee > thread not found. It