Re: RFR: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection [v2]

2020-12-14 Thread Severin Gehwolf
> This is an enhancement which solves two issues: > > 1. Multiple reads of relevant cgroup interface files. Now interface files are > only read once per file (just like Hotspot). > 2. Proxies creation of the impl specific subsystem via `determineType()` as > before, but now reads all relevant in

Re: [jdk16] RFR: 8255381: com/sun/jdi/EATests.java should not suspend graal threads

2020-12-14 Thread Martin Doerr
On Fri, 11 Dec 2020 09:03:44 GMT, Richard Reingruber wrote: > This is a clone of https://github.com/openjdk/jdk/pull/1625 which was > reviewed but not integrated before RDP1 > > The change is a test bug fix which can be integrated during RDP1 according to > https://openjdk.java.net/jeps/3 > >

Re: [jdk16] RFR: 8255381: com/sun/jdi/EATests.java should not suspend graal threads

2020-12-14 Thread Serguei Spitsyn
On Fri, 11 Dec 2020 09:03:44 GMT, Richard Reingruber wrote: > This is a clone of https://github.com/openjdk/jdk/pull/1625 which was > reviewed but not integrated before RDP1 > > The change is a test bug fix which can be integrated during RDP1 according to > https://openjdk.java.net/jeps/3 > >

RFR: 8253497: Core Libs Terminology Refresh

2020-12-14 Thread Brent Christian
This is part of an effort in the JDK to replace archaic/non-inclusive words with more neutral terms (see JDK-8253315 for details). Here are the changes covering core libraries code and tests. Terms were changed as follows: 1. grandfathered -> legacy 2. blacklist -> filter or reject 3. whitelist

Re: RFR: 8258057: serviceability/attach/RemovingUnixDomainSocketTest.java doesn't ignore VM warnings

2020-12-14 Thread Alex Menkov
On Fri, 11 Dec 2020 17:25:33 GMT, Patricio Chilano Mateo wrote: > Hi, > > Please review the following small fix for test > RemovingUnixDomainSocketTest.java. As explained in the bug comments, the > issue is due to having two different StreamPumper objects consuming from the > same stderr, on

Re: RFR: 8253497: Core Libs Terminology Refresh

2020-12-14 Thread Naoto Sato
On Mon, 14 Dec 2020 19:36:48 GMT, Brent Christian wrote: > This is part of an effort in the JDK to replace archaic/non-inclusive words > with more neutral terms (see JDK-8253315 for details). > > Here are the changes covering core libraries code and tests. Terms were > changed as follows: > 1

Re: RFR: 8253497: Core Libs Terminology Refresh

2020-12-14 Thread Kevin Rushforth
On Mon, 14 Dec 2020 19:36:48 GMT, Brent Christian wrote: > This is part of an effort in the JDK to replace archaic/non-inclusive words > with more neutral terms (see JDK-8253315 for details). > > Here are the changes covering core libraries code and tests. Terms were > changed as follows: > 1

Re: RFR: 8253497: Core Libs Terminology Refresh

2020-12-14 Thread Roger Riggs
On Mon, 14 Dec 2020 19:36:48 GMT, Brent Christian wrote: > This is part of an effort in the JDK to replace archaic/non-inclusive words > with more neutral terms (see JDK-8253315 for details). > > Here are the changes covering core libraries code and tests. Terms were > changed as follows: > 1

Re: RFR: 8253497: Core Libs Terminology Refresh

2020-12-14 Thread Joe Wang
On Mon, 14 Dec 2020 19:36:48 GMT, Brent Christian wrote: > This is part of an effort in the JDK to replace archaic/non-inclusive words > with more neutral terms (see JDK-8253315 for details). > > Here are the changes covering core libraries code and tests. Terms were > changed as follows: > 1

Re: RFR: 8258057: serviceability/attach/RemovingUnixDomainSocketTest.java doesn't ignore VM warnings

2020-12-14 Thread Chris Plummer
On Fri, 11 Dec 2020 17:25:33 GMT, Patricio Chilano Mateo wrote: > Hi, > > Please review the following small fix for test > RemovingUnixDomainSocketTest.java. As explained in the bug comments, the > issue is due to having two different StreamPumper objects consuming from the > same stderr, on

Re: RFR: 8165276: Spec states to invoke the premain method in an agent class if it's public but implementation differs [v4]

2020-12-14 Thread Serguei Spitsyn
On Mon, 14 Dec 2020 02:39:30 GMT, David Holmes wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> added 8165276 to @bug list of impacted tests > > Changes requested by dholmes (Reviewer). Alan, David and Many, tha

Re: RFR: 8258057: serviceability/attach/RemovingUnixDomainSocketTest.java doesn't ignore VM warnings

2020-12-14 Thread Alex Menkov
On Fri, 11 Dec 2020 17:25:33 GMT, Patricio Chilano Mateo wrote: > Hi, > > Please review the following small fix for test > RemovingUnixDomainSocketTest.java. As explained in the bug comments, the > issue is due to having two different StreamPumper objects consuming from the > same stderr, on

Re: RFR: 8165276: Spec states to invoke the premain method in an agent class if it's public but implementation differs [v4]

2020-12-14 Thread Mandy Chung
On 12/14/20 2:47 PM, Serguei Spitsyn wrote: On Mon, 14 Dec 2020 02:39:30 GMT, David Holmes wrote: Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision: added 8165276 to @bug list of impacted tests Changes requested by dholmes (Re

Re: RFR: 8258057: serviceability/attach/RemovingUnixDomainSocketTest.java doesn't ignore VM warnings

2020-12-14 Thread David Holmes
On 15/12/2020 10:01 am, Alex Menkov wrote: On Fri, 11 Dec 2020 17:25:33 GMT, Patricio Chilano Mateo wrote: Hi, Please review the following small fix for test RemovingUnixDomainSocketTest.java. As explained in the bug comments, the issue is due to having two different StreamPumper objects c

Re: RFR: 8253497: Core Libs Terminology Refresh

2020-12-14 Thread Brent Christian
On Mon, 14 Dec 2020 21:08:35 GMT, Joe Wang wrote: >> This is part of an effort in the JDK to replace archaic/non-inclusive words >> with more neutral terms (see JDK-8253315 for details). >> >> Here are the changes covering core libraries code and tests. Terms were >> changed as follows: >> 1.

Re: RFR: 8253497: Core Libs Terminology Refresh [v2]

2020-12-14 Thread Brent Christian
> This is part of an effort in the JDK to replace archaic/non-inclusive words > with more neutral terms (see JDK-8253315 for details). > > Here are the changes covering core libraries code and tests. Terms were > changed as follows: > 1. grandfathered -> legacy > 2. blacklist -> filter or rejec

Re: RFR: 8253497: Core Libs Terminology Refresh [v2]

2020-12-14 Thread Joe Wang
On Tue, 15 Dec 2020 01:36:27 GMT, Brent Christian wrote: >> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectorServer.java >> line 152: >> >>> 150: * >>> 151: * Care must be taken when defining such a filter, as defining >>> 152: * an accept-list too r

Re: RFR: 8253497: Core Libs Terminology Refresh [v2]

2020-12-14 Thread Alan Bateman
On Tue, 15 Dec 2020 01:46:08 GMT, Brent Christian wrote: >> This is part of an effort in the JDK to replace archaic/non-inclusive words >> with more neutral terms (see JDK-8253315 for details). >> >> Here are the changes covering core libraries code and tests. Terms were >> changed as follows