On Sun, 9 May 2021 22:42:26 GMT, David Holmes wrote:
>> src/hotspot/share/runtime/sharedRuntime.cpp line 1197:
>>
>>> 1195:
>>> 1196: methodHandle SharedRuntime::find_callee_method(TRAPS) {
>>> 1197: JavaThread* current = THREAD;
>>
>> I think these look strange, especially the ones
>> JavaT
On Wed, 5 May 2021 20:26:13 GMT, Alex Menkov wrote:
> Class loading can happen on different threads, but HotSwap agent is not ready
> to this - classCount variable is used without any synchronization.
> The fix adds synchronization for ClassFileLoadHook.
This pull request has now been integrate
On Wed, 5 May 2021 10:16:29 GMT, David Holmes wrote:
> Our code is littered with API's that take, or manifest, a Thread* and then
> assert/guarantee that it must be a JavaThread, rather than taking/manifesting
> a JavaThread in the first place. The main reason for this is that the TRAPS
> macr
On Wed, 5 May 2021 10:16:29 GMT, David Holmes wrote:
> Our code is littered with API's that take, or manifest, a Thread* and then
> assert/guarantee that it must be a JavaThread, rather than taking/manifesting
> a JavaThread in the first place. The main reason for this is that the TRAPS
> macr
On Mon, 10 May 2021 06:24:23 GMT, Mitsuru kariya
wrote:
> Also, should I issue the /contributor command?
I don't think you need to. I tried using it to add you as a contributor because
I thought it might be necessary since you don't have an openjdk username yet,
but I was told that it is not
On Fri, 7 May 2021 15:37:34 GMT, Lin Zang wrote:
> Having tried all these ways, I think maybe current solution with
> `unbufferedMode` is better. Because it is easy to calculate the array length
> in `calculateArrayMaxLength()` and hence know the size of the data to
> written. Then it can fill
On Thu, 6 May 2021 08:45:45 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> code refine and typo fix
I think you still need to undo the JMap.java chang
On Sun, 2 May 2021 16:07:26 GMT, Mitsuru kariya
wrote:
>> The current `hashCode` implementation of SA's Address subclasses ignores the
>> upper 32 bits of the long value.
>> This PR changes to use `Long.hashCode` instead.
>
> Mitsuru kariya has updated the pull request incrementally with one ad
On Mon, 26 Apr 2021 02:22:47 GMT, Hamlin Li wrote:
>> parallel -histo of jmap was added by JDK-8214535, it's better to support
>> parallel for jcmd GC.class_histogram too.
>
> Hamlin Li has updated the pull request incrementally with one additional
> commit since the last revision:
>
> refin
On Wed, 5 May 2021 01:35:11 GMT, Yasumasa Suenaga wrote:
> `ZAddress::address()` has been removed since
> [JDK-8235748](https://bugs.openjdk.java.net/browse/JDK-8235748), however SA
> has not followed it. Thus some SA tests would fail with ZGC.
> After this change, more than half of jtreg tests
On Tue, 11 May 2021 00:00:35 GMT, Chris Plummer wrote:
> The changes look good.
Thanks!
> I think it would be best if the 2nd review came from the GC team.
I think so too, I'm waiting for the review from GC folks.
-
PR: https://git.openjdk.java.net/jdk/pull/3868
> `jhsdb debugd` supports server name prefix with
> `sun.jvm.hotspot.rmi.serverNamePrefix` system property. It will be used as
> remote name for SA remote object. It is "SARemoteDebugger" by default.
>
> As a result, remote name will be constructed as following:
>
>
> //host[:port]/['_']
>
>
On Wed, 5 May 2021 08:41:48 GMT, Serguei Spitsyn wrote:
>> `jhsdb debugd` supports server name prefix with
>> `sun.jvm.hotspot.rmi.serverNamePrefix` system property. It will be used as
>> remote name for SA remote object. It is "SARemoteDebugger" by default.
>>
>> As a result, remote name will
On Tue, 11 May 2021 00:15:21 GMT, Yasumasa Suenaga wrote:
>> `jhsdb debugd` supports server name prefix with
>> `sun.jvm.hotspot.rmi.serverNamePrefix` system property. It will be used as
>> remote name for SA remote object. It is "SARemoteDebugger" by default.
>>
>> As a result, remote name wi
On Tue, 11 May 2021 00:52:12 GMT, Chris Plummer wrote:
>> Yasumasa Suenaga has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> co
On 11/05/2021 9:14 am, Serguei Spitsyn wrote:
On Wed, 5 May 2021 10:16:29 GMT, David Holmes wrote:
David,
This looks pretty good. At least, I do not see real problems.
It is really nice to make it more consistent.
Thanks,
Serguei
Thanks for the review Serguei!
David
-
Marked a
> Our code is littered with API's that take, or manifest, a Thread* and then
> assert/guarantee that it must be a JavaThread, rather than taking/manifesting
> a JavaThread in the first place. The main reason for this is that the TRAPS
> macro, used in relation to exception generation and process
On 11/05/2021 9:00 am, Serguei Spitsyn wrote:
On Wed, 5 May 2021 10:16:29 GMT, David Holmes wrote:
src/hotspot/share/jfr/recorder/checkpoint/types/jfrThreadState.cpp line 108:
106:
107: // caller needs ResourceMark
108: const char* get_java_thread_name(const JavaThread* t) {
Nit: Better to
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 30 commits:
- Merge branch 'master' into par-dump
- undo JMap.java
- code refine and typo fix
- Merge branch 'master' in
On Mon, 10 May 2021 23:29:36 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> code refine and typo fix
>
> I think you still need to undo the JMap.java changes since they are now being
> handled by #
> The current `hashCode` implementation of SA's Address subclasses ignores the
> upper 32 bits of the long value.
> This PR changes to use `Long.hashCode` instead.
Mitsuru kariya has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright
-
On Wed, 5 May 2021 01:35:11 GMT, Yasumasa Suenaga wrote:
> `ZAddress::address()` has been removed since
> [JDK-8235748](https://bugs.openjdk.java.net/browse/JDK-8235748), however SA
> has not followed it. Thus some SA tests would fail with ZGC.
> After this change, more than half of jtreg tests
22 matches
Mail list logo
