Re: [jdk17] RFR: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run [v2]

2021-07-13 Thread Anton Kozlov
On Tue, 13 Jul 2021 01:25:48 GMT, David Holmes wrote: >> Anton Kozlov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Subset of RawMonitor; comments added > > I can understand that raw_enter and raw_wait need this fix because they have

Re: [jdk17] RFR: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run [v2]

2021-07-13 Thread Anton Kozlov
> The change adds W^X transition in RawMonitor family of functions, fixing the > crash. RawMonitor functions are treated specially, so W^X transition is not > inserted automatically. A better fix would be in .xml description for entries > generation, but for now it is too risky. I hope to get th

Re: [jdk17] RFR: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run [v2]

2021-07-13 Thread Andrew Haley
On Tue, 13 Jul 2021 10:13:39 GMT, Anton Kozlov wrote: >> The change adds W^X transition in RawMonitor family of functions, fixing the >> crash. RawMonitor functions are treated specially, so W^X transition is not >> inserted automatically. A better fix would be in .xml description for >> entri

Integrated: Merge jdk17

2021-07-13 Thread Jesper Wilhelmsson
On Mon, 12 Jul 2021 23:12:29 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 17 -> JDK 18 This pull request has now been integrated. Changeset: 6b123b05 Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/6b123b059136b0c1efa62a23824b9aa253e6a519 Stats: 39 li

Re: RFR: 8269851: OperatingSystemMXBean getProcessCpuLoad reports incorrect process cpu usage in containers [v7]

2021-07-13 Thread Severin Gehwolf
On Tue, 13 Jul 2021 05:19:25 GMT, xpbob wrote: >> …ocess cpu usage in containers > > xpbob has updated the pull request incrementally with one additional commit > since the last revision: > > Set 1.0 for cpu set max https://github.com/jerboaa/jdk/actions/runs/1026610314 is a pre-integration

Re: RFR: 8269851: OperatingSystemMXBean getProcessCpuLoad reports incorrect process cpu usage in containers [v7]

2021-07-13 Thread Severin Gehwolf
On Tue, 13 Jul 2021 05:19:25 GMT, xpbob wrote: >> …ocess cpu usage in containers > > xpbob has updated the pull request incrementally with one additional commit > since the last revision: > > Set 1.0 for cpu set max Except for the missing comments in the new code blocks this looks good to m

Re: [jdk17] RFR: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run [v2]

2021-07-13 Thread Serguei Spitsyn
On Tue, 13 Jul 2021 10:13:39 GMT, Anton Kozlov wrote: >> The change adds W^X transition in RawMonitor family of functions, fixing the >> crash. RawMonitor functions are treated specially, so W^X transition is not >> inserted automatically. A better fix would be in .xml description for >> entri

Re: RFR: 8270067: AArch64: several clhsdb tests fail with -Xcomp

2021-07-13 Thread Chris Plummer
On Tue, 13 Jul 2021 01:41:03 GMT, Nick Gasson wrote: > > How did you even get the test to run without running into > > [JDK-8270199](https://bugs.openjdk.java.net/browse/JDK-8270199) > > Linux not macOS. Ah. OK. - PR: https://git.openjdk.java.net/jdk/pull/4737

Re: RFR: 8270067: AArch64: several clhsdb tests fail with -Xcomp

2021-07-13 Thread Chris Plummer
On Fri, 9 Jul 2021 08:37:00 GMT, Nick Gasson wrote: > Running the jtreg test serviceability/sa/ClhsdbWhere.java with -Xcomp > -XX:-TieredCompilation fails with the following exception: > > Error: java.lang.NullPointerException: Cannot invoke > "sun.jvm.hotspot.debugger.Address.getJLongAt(long

Re: [jdk17] RFR: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run [v2]

2021-07-13 Thread David Holmes
On Tue, 13 Jul 2021 10:13:39 GMT, Anton Kozlov wrote: >> The change adds W^X transition in RawMonitor family of functions, fixing the >> crash. RawMonitor functions are treated specially, so W^X transition is not >> inserted automatically. A better fix would be in .xml description for >> entri

Re: RFR: 8247351: [aarch64] NullPointerException during stack walking (clhsdb "where -a")

2021-07-13 Thread Nick Gasson
On Tue, 13 Jul 2021 17:49:40 GMT, Chris Plummer wrote: > This looks like a dup of > [https://bugs.openjdk.java.net/browse/JDK-8247351](JDK-8247351). If so, > please close this CR out as a dup and target this PR to JDK-8247351. Yes, I missed that one. Thanks. - PR: https://git.ope

Re: RFR: 8269909: getStack method in hprof.parser.Reader should use try-with-resource [v2]

2021-07-13 Thread Lin Zang
On Fri, 9 Jul 2021 08:21:21 GMT, Lin Zang wrote: >> 8269909: getStack method in hprof.parser.Reader should use try-with-resource > > Lin Zang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by t

Re: RFR: 8247351: [aarch64] NullPointerException during stack walking (clhsdb "where -a")

2021-07-13 Thread Chris Plummer
On Fri, 9 Jul 2021 08:37:00 GMT, Nick Gasson wrote: > Running the jtreg test serviceability/sa/ClhsdbWhere.java with -Xcomp > -XX:-TieredCompilation fails with the following exception: > > Error: java.lang.NullPointerException: Cannot invoke > "sun.jvm.hotspot.debugger.Address.getJLongAt(long

Re: RFR: 8247351: [aarch64] NullPointerException during stack walking (clhsdb "where -a")

2021-07-13 Thread Nick Gasson
On Tue, 13 Jul 2021 17:49:40 GMT, Chris Plummer wrote: >> Running the jtreg test serviceability/sa/ClhsdbWhere.java with -Xcomp >> -XX:-TieredCompilation fails with the following exception: >> >> Error: java.lang.NullPointerException: Cannot invoke >> "sun.jvm.hotspot.debugger.Address.getJLon

Re: RFR: 8269909: getStack method in hprof.parser.Reader should use try-with-resource [v3]

2021-07-13 Thread Lin Zang
> 8269909: getStack method in hprof.parser.Reader should use try-with-resource Lin Zang has updated the pull request incrementally with one additional commit since the last revision: revise code to handle the closing of embeded streams - Changes: - all: https://git.openjdk.java

Re: RFR: 8247351: [aarch64] NullPointerException during stack walking (clhsdb "where -a")

2021-07-13 Thread Chris Plummer
On Fri, 9 Jul 2021 08:37:00 GMT, Nick Gasson wrote: > Running the jtreg test serviceability/sa/ClhsdbWhere.java with -Xcomp > -XX:-TieredCompilation fails with the following exception: > > Error: java.lang.NullPointerException: Cannot invoke > "sun.jvm.hotspot.debugger.Address.getJLongAt(long

Re: RFR: 8269909: getStack method in hprof.parser.Reader should use try-with-resource [v3]

2021-07-13 Thread Chris Plummer
On Wed, 14 Jul 2021 02:38:38 GMT, Lin Zang wrote: >> 8269909: getStack method in hprof.parser.Reader should use try-with-resource > > Lin Zang has updated the pull request incrementally with one additional > commit since the last revision: > > revise code to handle the closing of embeded stre

Re: RFR: 8269851: OperatingSystemMXBean getProcessCpuLoad reports incorrect process cpu usage in containers [v8]

2021-07-13 Thread xpbob
> …ocess cpu usage in containers xpbob has updated the pull request incrementally with one additional commit since the last revision: Add comments - Changes: - all: https://git.openjdk.java.net/jdk/pull/4702/files - new: https://git.openjdk.java.net/jdk/pull/4702/files/fdd17

Re: RFR: 8269909: getStack method in hprof.parser.Reader should use try-with-resource [v3]

2021-07-13 Thread David Holmes
On Wed, 14 Jul 2021 02:38:38 GMT, Lin Zang wrote: >> 8269909: getStack method in hprof.parser.Reader should use try-with-resource > > Lin Zang has updated the pull request incrementally with one additional > commit since the last revision: > > revise code to handle the closing of embeded stre

Re: RFR: JDK-8268893: jcmd to trim the glibc heap [v4]

2021-07-13 Thread Thomas Stuefe
On Fri, 9 Jul 2021 04:57:27 GMT, Thomas Stuefe wrote: >> Proposal to add a Linux+glibc-only jcmd to manually induce malloc_trim(3) in >> the VM process. >> >> >> The glibc is somewhat notorious for retaining released C Heap memory: >> calling free(3) returns memory to the glibc, and most libc

Re: RFR: 8269909: getStack method in hprof.parser.Reader should use try-with-resource [v4]

2021-07-13 Thread Lin Zang
> 8269909: getStack method in hprof.parser.Reader should use try-with-resource Lin Zang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional

Re: RFR: 8269909: getStack method in hprof.parser.Reader should use try-with-resource [v3]

2021-07-13 Thread Lin Zang
On Wed, 14 Jul 2021 04:19:56 GMT, David Holmes wrote: >> Lin Zang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> revise code to handle the closing of embeded streams > > test/lib/jdk/test/lib/hprof/parser/Reader.java line 100: > >> 98:

Re: RFR: 8269909: getStack method in hprof.parser.Reader should use try-with-resource [v3]

2021-07-13 Thread David Holmes
On 14/07/2021 2:48 pm, Lin Zang wrote: On Wed, 14 Jul 2021 04:19:56 GMT, David Holmes wrote: Lin Zang has updated the pull request incrementally with one additional commit since the last revision: revise code to handle the closing of embeded streams test/lib/jdk/test/lib/hprof/parser/Re

Re: RFR: JDK-8268893: jcmd to trim the glibc heap [v4]

2021-07-13 Thread David Holmes
On Fri, 9 Jul 2021 04:57:27 GMT, Thomas Stuefe wrote: >> Proposal to add a Linux+glibc-only jcmd to manually induce malloc_trim(3) in >> the VM process. >> >> >> The glibc is somewhat notorious for retaining released C Heap memory: >> calling free(3) returns memory to the glibc, and most libc

Re: RFR: 8269909: getStack method in hprof.parser.Reader should use try-with-resource [v4]

2021-07-13 Thread David Holmes
On Wed, 14 Jul 2021 04:48:41 GMT, Lin Zang wrote: >> 8269909: getStack method in hprof.parser.Reader should use try-with-resource > > Lin Zang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by