Re: RFR: 8269909: getStack method in hprof.parser.Reader should use try-with-resource [v4]

2021-08-12 Thread Lin Zang
On Wed, 14 Jul 2021 05:05:27 GMT, David Holmes wrote: >> Lin Zang has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains five additional commits >> sin

Re: RFR: 8269909: getStack method in hprof.parser.Reader should use try-with-resource [v5]

2021-08-12 Thread Lin Zang
On Fri, 16 Jul 2021 11:53:15 GMT, Lin Zang wrote: >> 8269909: getStack method in hprof.parser.Reader should use try-with-resource > > Lin Zang has updated the pull request incrementally with one additional > commit since the last revision: > > rename variables Just got a quick update from Se

Re: RFR: 8269909: getStack method in hprof.parser.Reader should use try-with-resource [v5]

2021-08-12 Thread Serguei Spitsyn
On Fri, 16 Jul 2021 11:53:15 GMT, Lin Zang wrote: >> 8269909: getStack method in hprof.parser.Reader should use try-with-resource > > Lin Zang has updated the pull request incrementally with one additional > commit since the last revision: > > rename variables Hi Lin, Sorry for latency. I wa

Integrated: 8269909: getStack method in hprof.parser.Reader should use try-with-resource

2021-08-12 Thread Lin Zang
On Thu, 8 Jul 2021 08:16:51 GMT, Lin Zang wrote: > 8269909: getStack method in hprof.parser.Reader should use try-with-resource This pull request has now been integrated. Changeset: 09ab86b4 Author:Lin Zang Committer: Serguei Spitsyn URL: https://git.openjdk.java.net/jdk/commit/09a

Re: RFR: JDK-8272318: Improve performance of HeapDumpAllTest

2021-08-12 Thread Lin Zang
On Thu, 12 Aug 2021 06:10:45 GMT, Ralf Schmelter wrote: > > Is there a reason you don't want this change to also apply to HeapDumpTest? > > Since the GC.heap_dump already does a GC it is not really needed. Of course > doing the gc in HeapDumpTest is a smaller change, so I'm open for that. I pr