On Tue, 14 Sep 2021 00:33:32 GMT, Bernd Eckenfels
wrote:
>Maybe better use addFirst(), for example in CommandProcessor there is a
>comment that order matters (did not check it more closely), so it?s probably
>best to not reverse orders in any place?
In all other places (except HTMLReader), it
On Mon, 6 Sep 2021 07:17:58 GMT, Lin Zang wrote:
>> This PR rewrite the implementation of the HeapHprofBinWriter, which could
>> simplify the logic of current implementation.
>> please see detail description at
>> https://bugs.openjdk.java.net/browse/JDK-8269685.
>
> Lin Zang has updated the pu
On Mon, 13 Sep 2021 22:11:24 GMT, liach
wrote:
>> src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/RepositoryFiles.java
>> line 215:
>>
>>> 213: pathLookup.remove(remove);
>>> 214: }
>>> 215: added.sort((p1, p2) -> p1.compareTo(p2));
>>
>> 'added.sor
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8272992: Replace usages of Collections.sort with List.sort call in jdk.*
modules
---
On Mon, 13 Sep 2021 17:58:02 GMT, Rémi Forax wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8272992: Replace usages of Collections.sort with List.sort call in jdk.*
>> modules
>
> src/jdk.jfr/share/classes/jdk
On Mon, 19 Jul 2021 09:25:59 GMT, Ludovic Henry wrote:
>> When the signal sent for AsyncGetCallTrace or JFR would land on a runtime
>> stub (like arraycopy), a vtable stub, or the prolog of a compiled method,
>> it wouldn't be able to detect the sender (caller) frame for multiple
>> reasons.
On Wed, 9 Jun 2021 17:16:23 GMT, Ludovic Henry wrote:
> When the signal sent for AsyncGetCallTrace or JFR would land on a runtime
> stub (like arraycopy), a vtable stub, or the prolog of a compiled method, it
> wouldn't be able to detect the sender (caller) frame for multiple reasons.
> This
On Wed, 8 Sep 2021 13:39:08 GMT, Ralf Schmelter wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix build error
>
> src/hotspot/share/services/attachListener.cpp line 255:
>
>> 253: HeapDumper dumper(live_objects_
On Wed, 8 Sep 2021 05:02:18 GMT, Ralf Schmelter wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix build error
>
> I will start reviewing this today.
Hi Ralf @schmelter-sap ,
Thanks for your review and comments!
On Mon, 13 Sep 2021 23:48:57 GMT, Serguei Spitsyn wrote:
>> Hi Serguei,
>> I update the PR to make the `calculateGlobalJNIHandlesDumpRecordSize()`
>> method abstract.
>> For other empty ones that already there in original implementation, I
>> will leave them as they are. do you think
On Mon, 13 Sep 2021 16:12:48 GMT, Ralf Schmelter wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix build error
>
> src/hotspot/share/services/heapDumper.cpp line 1797:
>
>> 1795: if (o->is_instance()) {
>> 1796:
On Mon, 6 Sep 2021 08:03:22 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix build error
rebased with latest master, and made some change to fix the
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 49 commits:
- fix parallel issue
- Merge branch 'master' into pd-fix
- Merge branch 'master' of https://github.com/openjd
On Sun, 29 Aug 2021 21:14:19 GMT, Andrey Turbanov
wrote:
> Usage of thread-safe collection Stack is unnecessary. It's recommended to use
> ArrayDequeue if a thread-safe implementation is not needed.
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java line
988:
> 986:
On Tue, 14 Sep 2021 07:46:12 GMT, Andrey Turbanov
wrote:
>> Collections.sort is just a wrapper, so it is better to use an instance
>> method directly.
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8272992: Replace us
The memory allocated and hold in the paths local variable of function
appendBootClassPath() is never deallocated:
splitPathList(pathList, &count, &paths);
So, it is a memory leak which needs to be fixed.
The fix is to add one line at the end of function:
free(paths);
-
Commi
On Wed, 15 Sep 2021 01:05:10 GMT, Serguei Spitsyn wrote:
> The memory allocated and hold in the paths local variable of function
> appendBootClassPath() is never deallocated:
> splitPathList(pathList, &count, &paths);
> So, it is a memory leak which needs to be fixed.
> The fix is to add one
On Wed, 15 Sep 2021 01:05:10 GMT, Serguei Spitsyn wrote:
> The memory allocated and hold in the paths local variable of function
> appendBootClassPath() is never deallocated:
> splitPathList(pathList, &count, &paths);
> So, it is a memory leak which needs to be fixed.
> The fix is to add one
18 matches
Mail list logo
