RFR: 8273929: Remove GzipRandomAccess in heap dump test

2021-09-17 Thread Lin Zang
The class `GzipRandomAccess` is used to parse heap dump file generated from `jcmd`/`jmap` tools when testing. It has the limitation that only gzip file which has "blocksize" header field could be sucessfully parsed. We think this class can be removed for 2 reasons: 1. The gzip heap dump file gene

RFR: 8273915: Create 'nosafepoint' rank

2021-09-17 Thread Coleen Phillimore
Partition safepoint checking and nonchecking lock ranks. The nonchecking locks are always lower ranked than the safepoint checking locks because they cannot block. This moves some leaf locks to 'nosafepoint' rank and corrects relative ranking. Tested with tier1-6 and built and run tier1 tests w

RFR: 8273916: Remove 'special' ranking

2021-09-17 Thread Coleen Phillimore
This change removes the special ranking and folds it into nosafepoint. You have to look at commit #3 to see this actual part of the change that doesn't include JDK-8273915. This passes tier1-6 also. - Commit messages: - Remove "special" rank. - Partition safepoint checking and no

Re: RFR: 8266936: Add a finalization JFR event [v11]

2021-09-17 Thread Coleen Phillimore
On Mon, 13 Sep 2021 17:12:49 GMT, Markus Grönlund wrote: >> Greetings, >> >> Object.finalize() was deprecated in JDK9. There is an ongoing effort to >> replace and mitigate Object.finalize() uses in the JDK libraries; please see >> https://bugs.openjdk.java.net/browse/JDK-8253568 for more info

Re: RFR: 8273912: Add threadControl_dumpThread(jthread) function

2021-09-17 Thread Kevin Walls
On Thu, 16 Sep 2021 21:20:00 GMT, Chris Plummer wrote: > Trivial change to add an internal API that is useful when debugging. Only > included in debug builds, and has no impact on debug agent functionality. Marked as reviewed by kevinw (Committer). - PR: https://git.openjdk.java.n

Re: RFR: 8266936: Add a finalization JFR event [v11]

2021-09-17 Thread Markus Grönlund
On Fri, 17 Sep 2021 12:02:32 GMT, Coleen Phillimore wrote: >> Markus Grönlund has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - remove rehashing and rely on default grow_hint for table resize >> - mtStatistics > > src/hotspot/share/runt

RFR: 8273187: jtools tests fail with missing markerName check

2021-09-17 Thread Naoto Sato
Fixing failing regression tests caused by the JEP 400: UTF-8 by Default. `JcmdOutputEncodingTest` test case uses `file.encoding=UTF-8` in `C` locale. The output from the agent library is in `UTF-8` so it succeeded before the JEP has been implemented, as System.out used `UTF-8` converter. After t

RFR: 8273909: vmTestbase/nsk/jdi/Event/request/request001 can still fail with "ERROR: new event is not ThreadStartEvent"

2021-09-17 Thread Alex Menkov
The changes fixes discovered issues with getEventSetForThreadStartDeath method and its callers: - getEventSetForThreadStartDeath must resume suspended thread(s), otherwise it can never get desired event; - callers should not call addCountFilter; also simplifies getEventSetForThreadStartDeath. --

Re: RFR: 8273187: jtools tests fail with missing markerName check

2021-09-17 Thread Iris Clark
On Thu, 16 Sep 2021 01:08:45 GMT, Naoto Sato wrote: > Fixing failing regression tests caused by the JEP 400: UTF-8 by Default. > > `JcmdOutputEncodingTest` test case uses `file.encoding=UTF-8` in `C` locale. > The output from the agent library is in `UTF-8` so it succeeded before the > JEP has

Re: RFR: 8273187: jtools tests fail with missing markerName check

2021-09-17 Thread Serguei Spitsyn
On Thu, 16 Sep 2021 01:08:45 GMT, Naoto Sato wrote: > Fixing failing regression tests caused by the JEP 400: UTF-8 by Default. > > `JcmdOutputEncodingTest` test case uses `file.encoding=UTF-8` in `C` locale. > The output from the agent library is in `UTF-8` so it succeeded before the > JEP has

Re: RFR: 8273909: vmTestbase/nsk/jdi/Event/request/request001 can still fail with "ERROR: new event is not ThreadStartEvent"

2021-09-17 Thread Chris Plummer
On Fri, 17 Sep 2021 20:07:13 GMT, Alex Menkov wrote: > The changes fixes discovered issues with getEventSetForThreadStartDeath > method and its callers: > - getEventSetForThreadStartDeath must resume suspended thread(s), otherwise > it can never get desired event; > - callers should not call ad

Re: RFR: 8273187: jtools tests fail with missing markerName check

2021-09-17 Thread Joe Wang
On Thu, 16 Sep 2021 01:08:45 GMT, Naoto Sato wrote: > Fixing failing regression tests caused by the JEP 400: UTF-8 by Default. > > `JcmdOutputEncodingTest` test case uses `file.encoding=UTF-8` in `C` locale. > The output from the agent library is in `UTF-8` so it succeeded before the > JEP has

Re: RFR: 8273912: Add threadControl_dumpThread(jthread) function

2021-09-17 Thread Serguei Spitsyn
On Thu, 16 Sep 2021 21:20:00 GMT, Chris Plummer wrote: > Trivial change to add an internal API that is useful when debugging. Only > included in debug builds, and has no impact on debug agent functionality. Hi Kevin, It looks good and trivial. Thanks, Serguei - Marked as reviewed

Re: RFR: 8269685: Optimize HeapHprofBinWriter implementation [v9]

2021-09-17 Thread Serguei Spitsyn
On Fri, 17 Sep 2021 01:51:26 GMT, Lin Zang wrote: >> This PR rewrite the implementation of the HeapHprofBinWriter, which could >> simplify the logic of current implementation. >> please see detail description at >> https://bugs.openjdk.java.net/browse/JDK-8269685. > > Lin Zang has updated the p

Re: RFR: 8271356: Modify jdb to treat an empty command as a repeat of the previous command [v3]

2021-09-17 Thread Chris Plummer
On Fri, 3 Sep 2021 22:08:20 GMT, Chris Plummer wrote: > > Chris, do you think I should give the Chinese and Japanese localizations a > > shot? I do actually know a little Chinese, but the Japanese would basically > > just be whatever Google Translate says. Or maybe during the CSR review > > so

Re: RFR: 8273921: Refactor NSK/JDI tests to create thread using factory

2021-09-17 Thread Chris Plummer
On Wed, 15 Sep 2021 00:34:08 GMT, Leonid Mesnik wrote: > 8273921: Refactor NSK/JDI tests to create thread using factory I've gotten through about 1/3 of the test plus the new files, so thought I'd pass along my comments so far. Overall it looks good though. test/hotspot/jtreg/vmTestbase/nsk/jd