Re: RFR: 8269685: Optimize HeapHprofBinWriter implementation [v10]

2021-09-26 Thread Lin Zang
On Fri, 24 Sep 2021 19:01:02 GMT, Serguei Spitsyn wrote: >> Lin Zang has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains 12 commits: >> >> - Merge branch 'master' into hprof >> - code refine >> - code refine >> - Merge branch 'mas

Re: RFR: 8274196: Crashes in VM_HeapDumper::work after JDK-8252842 [v2]

2021-09-26 Thread Lin Zang
> The root cause for crash in ZGC is that the JNIHandles are processed before > object iteration. And ZGC would update the JNIHandles at object iteration > with read barrier. So the crash is cause by accessing the invalid address > which can be dummy info after zgc, and hence crash. > > The loc

Re: RFR: 8273929: Remove GzipRandomAccess in heap dump test

2021-09-26 Thread Lin Zang
On Wed, 22 Sep 2021 20:24:09 GMT, Chris Plummer wrote: >> The class `GzipRandomAccess` is used to parse heap dump file generated from >> `jcmd`/`jmap` tools when testing. >> It has the limitation that only gzip file which has "blocksize" header field >> could be sucessfully parsed. >> We think