Integrated: 8275735: [linux] Remove deprecated Metrics api (kernel memory limit)

2021-11-02 Thread Severin Gehwolf
On Thu, 28 Oct 2021 13:03:56 GMT, Severin Gehwolf wrote: > Please review this change to remove some API which no longer works as > expected as recent OCI runtimes start to drop support for `--kernel-memory` > switch. See the bug for references. This part of the API is not present in > hotspot

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Tobias Hartmann
On Mon, 1 Nov 2021 20:51:39 GMT, Evgeny Astigeevich wrote: > This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be > qualified. > Testing: > - `make test TEST="gtest"`: Passed > - `make run-test TEST="tier1"`: Passed > - `make run-test TEST="tier2"`: Passed > - `make run

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Volker Simonis
On Mon, 1 Nov 2021 20:51:39 GMT, Evgeny Astigeevich wrote: > This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be > qualified. > Testing: > - `make test TEST="gtest"`: Passed > - `make run-test TEST="tier1"`: Passed > - `make run-test TEST="tier2"`: Passed > - `make run

Integrated: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Evgeny Astigeevich
On Mon, 1 Nov 2021 20:51:39 GMT, Evgeny Astigeevich wrote: > This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be > qualified. > Testing: > - `make test TEST="gtest"`: Passed > - `make run-test TEST="tier1"`: Passed > - `make run-test TEST="tier2"`: Passed > - `make run

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Paul Hohensee
On Mon, 1 Nov 2021 20:51:39 GMT, Evgeny Astigeevich wrote: > This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be > qualified. > Testing: > - `make test TEST="gtest"`: Passed > - `make run-test TEST="tier1"`: Passed > - `make run-test TEST="tier2"`: Passed > - `make run

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Volker Simonis
On Mon, 1 Nov 2021 20:51:39 GMT, Evgeny Astigeevich wrote: > This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be > qualified. > Testing: > - `make test TEST="gtest"`: Passed > - `make run-test TEST="tier1"`: Passed > - `make run-test TEST="tier2"`: Passed > - `make run

Integrated: 8276367: ProblemList vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java

2021-11-02 Thread Daniel D . Daugherty
A trivial fix to ProblemList vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java - Commit messages: - 8276367: ProblemList vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java Changes: https

Re: Integrated: 8276367: ProblemList vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java

2021-11-02 Thread Daniel D . Daugherty
On Tue, 2 Nov 2021 16:47:08 GMT, Brian Burkhalter wrote: >> A trivial fix to ProblemList >> vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java > > Marked as reviewed by bpb (Reviewer). @bplb - Thanks for the fast review. - PR: https:/

Re: Integrated: 8276367: ProblemList vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java

2021-11-02 Thread Brian Burkhalter
On Tue, 2 Nov 2021 16:34:26 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java Marked as reviewed by bpb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6214

Integrated: 8276367: ProblemList vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java

2021-11-02 Thread Daniel D . Daugherty
On Tue, 2 Nov 2021 16:34:26 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java This pull request has now been integrated. Changeset: 01105d69 Author:Daniel D. Daugherty URL:

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Evgeny Astigeevich
On Tue, 2 Nov 2021 16:34:34 GMT, Volker Simonis wrote: >> This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be >> qualified. >> Testing: >> - `make test TEST="gtest"`: Passed >> - `make run-test TEST="tier1"`: Passed >> - `make run-test TEST="tier2"`: Passed >> - `make r

Re: RFR: 8249004: Reduce ThreadsListHandle overhead in relation to direct handshakes [v10]

2021-11-02 Thread Daniel D . Daugherty
> A fix to reduce ThreadsListHandle overhead in relation to handshakes and > we add sanity checks for ThreadsListHandles higher in the call stack. > > This fix was tested with Mach5 Tier[1-8]; Tier8 is still running. Daniel D. Daugherty has updated the pull request incrementally with one additio

Re: RFR: 8249004: Reduce ThreadsListHandle overhead in relation to direct handshakes [v6]

2021-11-02 Thread Daniel D . Daugherty
On Fri, 15 Oct 2021 18:31:26 GMT, Coleen Phillimore wrote: >> Daniel D. Daugherty has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8249004.cr1.patch > > This has more moving pieces than the last version. I'm a bit uneasy about > passing

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Evgeny Astigeevich
On Tue, 2 Nov 2021 05:49:30 GMT, Yi Yang wrote: >> This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be >> qualified. >> Testing: >> - `make test TEST="gtest"`: Passed >> - `make run-test TEST="tier1"`: Passed >> - `make run-test TEST="tier2"`: Passed >> - `make run-test

Re: RFR: 8276208: vmTestbase/nsk/jdb/repeat/repeat001/repeat001.java fails with "AssertionError: Unexpected output" [v2]

2021-11-02 Thread Daniel D . Daugherty
On Tue, 2 Nov 2021 01:07:30 GMT, Jakob Cornell wrote: >> This will fix a few issues with the tests added in #5290: >> >> - [x] intermittent failures >> - [x] tests should use `failure` method to report problems rather than >> throwing `AssertionError` > > Jakob Cornell has updated the pull requ

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Lutz Schmidt
On Mon, 1 Nov 2021 20:51:39 GMT, Evgeny Astigeevich wrote: > This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be > qualified. > Testing: > - `make test TEST="gtest"`: Passed > - `make run-test TEST="tier1"`: Passed > - `make run-test TEST="tier2"`: Passed > - `make run

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Lutz Schmidt
On Tue, 2 Nov 2021 17:03:50 GMT, Evgeny Astigeevich wrote: >> src/hotspot/share/code/codeHeapState.cpp line 2340: >> >>> 2338: >>> 2339: Klass* klass = method->method_holder(); >>> 2340: assert(klass->is_loader_alive(), "must be alive"); >> >> Are you sure `klass` is a

Re: RFR: 8276208: vmTestbase/nsk/jdb/repeat/repeat001/repeat001.java fails with "AssertionError: Unexpected output" [v2]

2021-11-02 Thread Ioi Lam
On Tue, 2 Nov 2021 01:07:30 GMT, Jakob Cornell wrote: >> This will fix a few issues with the tests added in #5290: >> >> - [x] intermittent failures >> - [x] tests should use `failure` method to report problems rather than >> throwing `AssertionError` > > Jakob Cornell has updated the pull requ

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Vladimir Kozlov
On Mon, 1 Nov 2021 20:51:39 GMT, Evgeny Astigeevich wrote: > This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be > qualified. > Testing: > - `make test TEST="gtest"`: Passed > - `make run-test TEST="tier1"`: Passed > - `make run-test TEST="tier2"`: Passed > - `make run

Integrated: JDK-8274930: sun/tools/jps/TestJps.java can fail with long VM arguments string

2021-11-02 Thread Alex Menkov
On Thu, 7 Oct 2021 21:46:47 GMT, Alex Menkov wrote: > The fix adds "-XX:PerfMaxStringConstLength" argument running target app > (default is 1024, 8K should be enough for any environments) This pull request has now been integrated. Changeset: bb92fb02 Author:Alex Menkov URL: https:/

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Vladimir Kozlov
On Mon, 1 Nov 2021 20:51:39 GMT, Evgeny Astigeevich wrote: > This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be > qualified. > Testing: > - `make test TEST="gtest"`: Passed > - `make run-test TEST="tier1"`: Passed > - `make run-test TEST="tier2"`: Passed > - `make run

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Evgeny Astigeevich
On Tue, 2 Nov 2021 22:05:01 GMT, Vladimir Kozlov wrote: > I don't think we need this assert just to print klass's name. May be follow > the code pattern for method's name and signature. Agree. I'll submit PR with the code: Symbol* className = klass->name(); const char* classNameS = (classNam

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Vladimir Kozlov
On Mon, 1 Nov 2021 20:51:39 GMT, Evgeny Astigeevich wrote: > This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be > qualified. > Testing: > - `make test TEST="gtest"`: Passed > - `make run-test TEST="tier1"`: Passed > - `make run-test TEST="tier2"`: Passed > - `make run

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Evgeny Astigeevich
On Tue, 2 Nov 2021 22:57:23 GMT, Vladimir Kozlov wrote: > Yes, I am currently testing similar fix: > > ``` > -Klass* klass = method->method_holder(); > -assert(klass->is_loader_alive(), "must be alive"); > +Klass* methHolder = method->method_holder(); > +

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Vladimir Kozlov
On Tue, 2 Nov 2021 23:03:22 GMT, Evgeny Astigeevich wrote: > Is NULL method holder an acceptable situation? Could it be a sign of a bug? You are right, all methods should have class holders. I just followed code pattern. > BTW, `Klass::external_name()` returns `` if `Klass::name()` is > `NUL

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Vladimir Kozlov
On Mon, 1 Nov 2021 20:51:39 GMT, Evgeny Astigeevich wrote: > This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be > qualified. > Testing: > - `make test TEST="gtest"`: Passed > - `make run-test TEST="tier1"`: Passed > - `make run-test TEST="tier2"`: Passed > - `make run

Re: RFR: 8249004: Reduce ThreadsListHandle overhead in relation to direct handshakes [v10]

2021-11-02 Thread David Holmes
On Tue, 2 Nov 2021 17:26:41 GMT, Daniel D. Daugherty wrote: >> A fix to reduce ThreadsListHandle overhead in relation to handshakes and >> we add sanity checks for ThreadsListHandles higher in the call stack. >> >> This fix was tested with Mach5 Tier[1-8]; Tier8 is still running. > > Daniel D. D