Re: [jdk18] RFR: 8132785: java/lang/management/ThreadMXBean/ThreadLists.java fails intermittently

2021-12-13 Thread Alan Bateman
On Mon, 13 Dec 2021 04:19:39 GMT, David Holmes wrote: > Investigation showed this test was experiencing interference from threads > created by other tests in agentvm mode. The simple solution is to run this > test isolated using othervm mode. Also added some diagnostics to the test > incase we

Re: [jdk18] RFR: 8132785: java/lang/management/ThreadMXBean/ThreadLists.java fails intermittently

2021-12-13 Thread Kevin Walls
On Mon, 13 Dec 2021 04:19:39 GMT, David Holmes wrote: > Investigation showed this test was experiencing interference from threads > created by other tests in agentvm mode. The simple solution is to run this > test isolated using othervm mode. Also added some diagnostics to the test > incase we

Re: RFR: 8277481: Obsolete seldom used CDS flags [v2]

2021-12-13 Thread Harold Seigel
On Fri, 10 Dec 2021 19:49:48 GMT, Harold Seigel wrote: >> Please review this change to obsolete deprecated CDS options >> UseSharedSpaces, RequireSharedSpaces, DynamicDumpSharedSpaces, and >> DumpSharedSpaces. The change was tested by running Mach5 tiers 1-2 on >> Linux, Mac OS, and Windows a

Integrated: 8277481: Obsolete seldom used CDS flags

2021-12-13 Thread Harold Seigel
On Fri, 10 Dec 2021 15:01:29 GMT, Harold Seigel wrote: > Please review this change to obsolete deprecated CDS options UseSharedSpaces, > RequireSharedSpaces, DynamicDumpSharedSpaces, and DumpSharedSpaces. The > change was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows > and M

Re: [jdk18] RFR: 8132785: java/lang/management/ThreadMXBean/ThreadLists.java fails intermittently

2021-12-13 Thread Daniel D . Daugherty
On Mon, 13 Dec 2021 04:19:39 GMT, David Holmes wrote: > Investigation showed this test was experiencing interference from threads > created by other tests in agentvm mode. The simple solution is to run this > test isolated using othervm mode. Also added some diagnostics to the test > incase we

Integrated: 8269556: sun/tools/jhsdb/JShellHeapDumpTest.java fails with RuntimeException 'JShellToolProvider' missing from stdout/stderr

2021-12-13 Thread Chris Plummer
On Fri, 10 Dec 2021 07:00:10 GMT, Chris Plummer wrote: > The test searches for "JShellToolProvider" in the main thread's stack trace, > which is pulled from an SA heap dump. Typically the main thread is blocked in > Object.wait(), so SA can determine its stack trace. However, the wait has a >

Re: [jdk18] RFR: 8132785: java/lang/management/ThreadMXBean/ThreadLists.java fails intermittently

2021-12-13 Thread Serguei Spitsyn
On Mon, 13 Dec 2021 04:19:39 GMT, David Holmes wrote: > Investigation showed this test was experiencing interference from threads > created by other tests in agentvm mode. The simple solution is to run this > test isolated using othervm mode. Also added some diagnostics to the test > incase we

[jdk18] Integrated: 8132785: java/lang/management/ThreadMXBean/ThreadLists.java fails intermittently

2021-12-13 Thread David Holmes
On Mon, 13 Dec 2021 04:19:39 GMT, David Holmes wrote: > Investigation showed this test was experiencing interference from threads > created by other tests in agentvm mode. The simple solution is to run this > test isolated using othervm mode. Also added some diagnostics to the test > incase we

Re: [jdk18] RFR: 8132785: java/lang/management/ThreadMXBean/ThreadLists.java fails intermittently

2021-12-13 Thread David Holmes
On Mon, 13 Dec 2021 04:19:39 GMT, David Holmes wrote: > Investigation showed this test was experiencing interference from threads > created by other tests in agentvm mode. The simple solution is to run this > test isolated using othervm mode. Also added some diagnostics to the test > incase we

RFR: 8202579: Revisit VM_Version and VM_Version_ext for overlap and consolidation

2021-12-13 Thread Coleen Phillimore
This change makes VM_Version_Ext part of VM_Version (the platform dependent part) and moves some duplicated code. x86 had the most code in VM_Version_Ext, so the most code moved there. There might be some unneeded functions but I didn't want to remove them with this change. Tier1 (tier2-4 test

RFR: 8244765: Undo exclusiveAccess.dirs changes for JDK-8220295 and see if there are still any testing issues

2021-12-13 Thread Chris Plummer
This changes removes (most) Attach API tests from exclusiveAccess.dirs so the tests can be run in parallel. I haven't seen any issues with this change, except the jstatd tests can fail due to an RMI issue. I filed https://bugs.openjdk.java.net/browse/JDK-8278625 to cover that issue. ---

Re: RFR: 8244765: Undo exclusiveAccess.dirs changes for JDK-8220295 and see if there are still any testing issues

2021-12-13 Thread Alex Menkov
On Mon, 13 Dec 2021 21:00:02 GMT, Chris Plummer wrote: > This changes removes (most) Attach API tests from exclusiveAccess.dirs so the > tests can be run in parallel. I haven't seen any issues with this change, > except the jstatd tests can fail due to an RMI issue. I filed > https://bugs.open

RFR: 8278643: CoreUtils.getCoreFileLocation() should print out the size of the core file found

2021-12-13 Thread Chris Plummer
Include the size of the core file when printing a message that it was found. - Commit messages: - Print the size of the core file found Changes: https://git.openjdk.java.net/jdk/pull/6822/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6822&range=00 Issue: https://bug

Re: RFR: 8278643: CoreUtils.getCoreFileLocation() should print out the size of the core file found

2021-12-13 Thread Alex Menkov
On Tue, 14 Dec 2021 01:14:45 GMT, Chris Plummer wrote: > Include the size of the core file when printing a message that it was found. Marked as reviewed by amenkov (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6822

RFR: Merge jdk18

2021-12-13 Thread Jesper Wilhelmsson
Forwardport JDK 18 -> JDK 19 - Commit messages: - Merge - 8132785: java/lang/management/ThreadMXBean/ThreadLists.java fails intermittently - 8273108: RunThese24H crashes with SEGV in markWord::displaced_mark_helper() after JDK-8268276 - 8278580: ProblemList javax/swing/JTree/490

Re: RFR: 8278643: CoreUtils.getCoreFileLocation() should print out the size of the core file found

2021-12-13 Thread Leonid Mesnik
On Tue, 14 Dec 2021 01:14:45 GMT, Chris Plummer wrote: > Include the size of the core file when printing a message that it was found. Marked as reviewed by lmesnik (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6822

Re: RFR: Merge jdk18 [v2]

2021-12-13 Thread Jesper Wilhelmsson
> Forwardport JDK 18 -> JDK 19 Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 29 additional commits since the last revision: - Me

Integrated: Merge jdk18

2021-12-13 Thread Jesper Wilhelmsson
On Tue, 14 Dec 2021 01:35:43 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 18 -> JDK 19 This pull request has now been integrated. Changeset: 8401a059 Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/8401a059bd01b32e3532f806d3d8b60e851c468a Stats: 119 l

Re: RFR: 8202579: Revisit VM_Version and VM_Version_ext for overlap and consolidation

2021-12-13 Thread David Holmes
On Mon, 13 Dec 2021 23:14:43 GMT, Coleen Phillimore wrote: > This change makes VM_Version_Ext part of VM_Version (the platform dependent > part) and moves some duplicated code. x86 had the most code in > VM_Version_Ext, so the most code moved there. There might be some unneeded > functions bu

RFR: 8273904: debug agent ArrayTypeImp::newInstance() fails to send reply packet if there is an error

2021-12-13 Thread Chris Plummer
ArrayTypeImp::newInstance() was returning false instead of true for one error condition, resulting in a failure to send a reply packet containing the error. See the bug description for details. - Commit messages: - ArrayTypeImp::newInstance() should always return true, even if ther

RFR: 8269838: BasicTypeDataBase.findDynamicTypeForAddress(addr, basetype) can be simplified

2021-12-13 Thread Chris Plummer
SA had a bunch of vtable related code that searched for the vtable pointer of a hotspot object in a few places. This was all related to weird ways that Solaris would store the vtable pointer. In the case of https://bugs.openjdk.java.net/browse/JDK-8269830, this extra vtable searching code intro