Re: RFR: 8244670: convert clhsdb "whatis" command from javascript to java [v3]

2021-12-21 Thread Kevin Walls
On Mon, 20 Dec 2021 17:46:45 GMT, Chris Plummer wrote: >> "whatis" is one of the old clhsdb commands that was written in javascript >> and lost when Nashorn support was removed. The old "whatis" is the same as >> the old "findpc", but also called LoadObject.lookup() on the address and >> also

Re: RFR: 8279024: Remove javascript references from clhsdb.html

2021-12-21 Thread Kevin Walls
On Tue, 21 Dec 2021 02:17:10 GMT, Chris Plummer wrote: > clhsdb no longer supports javascript. Remove some remaining references in the > docs. I also removed some script references. Marked as reviewed by kevinw (Committer). - PR: https://git.openjdk.java.net/jdk/pull/6903

Re: RFR: 8279024: Remove javascript references from clhsdb.html

2021-12-21 Thread Serguei Spitsyn
On Tue, 21 Dec 2021 02:17:10 GMT, Chris Plummer wrote: > clhsdb no longer supports javascript. Remove some remaining references in the > docs. I also removed some script references. Marked as reviewed by sspitsyn (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6903

[jdk18] RFR: 8279007: jstatd fails to start because SecurityManager is disabled

2021-12-21 Thread Kevin Walls
jstatd now in jdk18 fails to start unless we specifically allow or set a SecurityManager. This update to the launcher makefile adds JAVA_ARGS to permit a SecurityManager. - Commit messages: - 8279007: jstatd fails to start because SecurityManager is disabled Changes: https://git.op

Re: [jdk18] RFR: 8279007: jstatd fails to start because SecurityManager is disabled

2021-12-21 Thread Alan Bateman
On Tue, 21 Dec 2021 13:00:26 GMT, Kevin Walls wrote: > jstatd now in jdk18 fails to start unless we specifically allow or set a > SecurityManager. > This update to the launcher makefile adds JAVA_ARGS to permit a > SecurityManager. This looks okay in that it is now worked exactly as it did in

Re: [jdk18] RFR: 8279007: jstatd fails to start because SecurityManager is disabled

2021-12-21 Thread Sean Mullan
On Tue, 21 Dec 2021 13:00:26 GMT, Kevin Walls wrote: > jstatd now in jdk18 fails to start unless we specifically allow or set a > SecurityManager. > This update to the launcher makefile adds JAVA_ARGS to permit a > SecurityManager. You should also remove `-Djava.security.manager=allow` from th

Re: RFR: 8244669: convert clhsdb "mem" command from javascript to java [v3]

2021-12-21 Thread Chris Plummer
> clhsdb lost support for the "mem" command when javascript support was removed > from SA. This PR is re-adding it by implementing it in Java. The description > of the CR contains all the details. > > Regarding the clhsdb.html changes for the "examine" command, they are just > correctly specify

[jdk18] RFR: 8279081: ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on 2 platforms

2021-12-21 Thread Daniel D . Daugherty
A trivial fix to ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on 2 platforms - Commit messages: - 8279081: ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on 2 platforms Changes: https://git.openjdk.java.net/jdk18/pull/61/files Webrev: https://webrevs.openj

Re: [jdk18] RFR: 8279007: jstatd fails to start because SecurityManager is disabled

2021-12-21 Thread Kevin Walls
On Tue, 21 Dec 2021 15:12:19 GMT, Sean Mullan wrote: > You should also remove `-Djava.security.manager=allow` from the jstatd test > (`test/jdk/sun/tools/jstatd/JstatdTest.java`) as it is not needed now. Yes of course! Thanks. - PR: https://git.openjdk.java.net/jdk18/pull/53

Re: [jdk18] RFR: 8279007: jstatd fails to start because SecurityManager is disabled [v2]

2021-12-21 Thread Kevin Walls
> jstatd now in jdk18 fails to start unless we specifically allow or set a > SecurityManager. > This update to the launcher makefile adds JAVA_ARGS to permit a > SecurityManager. Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: Remove

Re: [jdk18] RFR: 8279081: ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on 2 platforms

2021-12-21 Thread Alexander Zvegintsev
On Tue, 21 Dec 2021 19:56:07 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on > 2 platforms Marked as reviewed by azvegint (Reviewer). - PR: https://git.openjdk.java.net/jdk18/pull/61

Re: [jdk18] RFR: 8279081: ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on 2 platforms

2021-12-21 Thread Serguei Spitsyn
On Tue, 21 Dec 2021 19:56:07 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on > 2 platforms Hi Dan, This is good and trivial. Thanks, Serguei - Marked as reviewed by sspitsyn (Reviewer). PR: https://git.openjdk.java.

Re: [jdk18] RFR: 8279081: ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on 2 platforms

2021-12-21 Thread Daniel D . Daugherty
On Tue, 21 Dec 2021 20:36:05 GMT, Alexander Zvegintsev wrote: >> A trivial fix to ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java >> on 2 platforms > > Marked as reviewed by azvegint (Reviewer). @azvegint and @sspitsyn - Thanks for the reviews! - PR: https://git.openjdk

[jdk18] Integrated: 8279081: ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on 2 platforms

2021-12-21 Thread Daniel D . Daugherty
On Tue, 21 Dec 2021 19:56:07 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on > 2 platforms This pull request has now been integrated. Changeset: 84dc Author:Daniel D. Daugherty URL: https://git.openjdk.java.net/jd

Re: [jdk18] RFR: 8279007: jstatd fails to start because SecurityManager is disabled [v2]

2021-12-21 Thread Serguei Spitsyn
On Tue, 21 Dec 2021 20:28:52 GMT, Kevin Walls wrote: >> jstatd now in jdk18 fails to start unless we specifically allow or set a >> SecurityManager. >> This update to the launcher makefile adds JAVA_ARGS to permit a >> SecurityManager. > > Kevin Walls has updated the pull request incrementally

Re: [jdk18] RFR: 8279007: jstatd fails to start because SecurityManager is disabled [v2]

2021-12-21 Thread Sean Mullan
On Tue, 21 Dec 2021 20:28:52 GMT, Kevin Walls wrote: >> jstatd now in jdk18 fails to start unless we specifically allow or set a >> SecurityManager. >> This update to the launcher makefile adds JAVA_ARGS to permit a >> SecurityManager. > > Kevin Walls has updated the pull request incrementally

Re: [jdk18] RFR: 8278239: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine failed with EXCEPTION_ACCESS_VIOLATION at 0x000000000000000d

2021-12-21 Thread Vladimir Kozlov
On Tue, 21 Dec 2021 20:51:04 GMT, Coleen Phillimore wrote: > This is the fix for https://github.com/openjdk/jdk/pull/6900 retargeted to > JDK 18. > > Thanks to @stefank and @fisk for the diagnosis. ZGC is looking at metadata in > unloaded nmethods, but redefinition doesn't keep this metadata f

Re: RFR: 8244669: convert clhsdb "mem" command from javascript to java [v3]

2021-12-21 Thread Serguei Spitsyn
On Tue, 21 Dec 2021 19:58:53 GMT, Chris Plummer wrote: >> clhsdb lost support for the "mem" command when javascript support was >> removed from SA. This PR is re-adding it by implementing it in Java. The >> description of the CR contains all the details. >> >> Regarding the clhsdb.html changes

Re: RFR: 8244669: convert clhsdb "mem" command from javascript to java [v3]

2021-12-21 Thread Serguei Spitsyn
On Tue, 21 Dec 2021 19:58:53 GMT, Chris Plummer wrote: >> clhsdb lost support for the "mem" command when javascript support was >> removed from SA. This PR is re-adding it by implementing it in Java. The >> description of the CR contains all the details. >> >> Regarding the clhsdb.html changes

Integrated: 8244670: convert clhsdb "whatis" command from javascript to java

2021-12-21 Thread Chris Plummer
On Sat, 18 Dec 2021 01:08:04 GMT, Chris Plummer wrote: > "whatis" is one of the old clhsdb commands that was written in javascript and > lost when Nashorn support was removed. The old "whatis" is the same as the > old "findpc", but also called LoadObject.lookup() on the address and also > trie

Re: [jdk18] RFR: 8278239: vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine failed with EXCEPTION_ACCESS_VIOLATION at 0x000000000000000d

2021-12-21 Thread Serguei Spitsyn
On Tue, 21 Dec 2021 20:51:04 GMT, Coleen Phillimore wrote: > This is the fix for https://github.com/openjdk/jdk/pull/6900 retargeted to > JDK 18. > > Thanks to @stefank and @fisk for the diagnosis. ZGC is looking at metadata in > unloaded nmethods, but redefinition doesn't keep this metadata f

Re: RFR: 8244669: convert clhsdb "mem" command from javascript to java [v3]

2021-12-21 Thread Chris Plummer
On Tue, 21 Dec 2021 21:27:24 GMT, Serguei Spitsyn wrote: >> Chris Plummer has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Fix issue with address range patterns. For some reason they have always >> allowed some extra lower case letters

Re: RFR: 8244669: convert clhsdb "mem" command from javascript to java [v3]

2021-12-21 Thread Chris Plummer
On Tue, 21 Dec 2021 21:23:09 GMT, Serguei Spitsyn wrote: >> Chris Plummer has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Fix issue with address range patterns. For some reason they have always >> allowed some extra lower case letters

Re: RFR: 8244669: convert clhsdb "mem" command from javascript to java [v4]

2021-12-21 Thread Chris Plummer
> clhsdb lost support for the "mem" command when javascript support was removed > from SA. This PR is re-adding it by implementing it in Java. The description > of the CR contains all the details. > > Regarding the clhsdb.html changes for the "examine" command, they are just > correctly specify

Re: RFR: 8244669: convert clhsdb "mem" command from javascript to java [v4]

2021-12-21 Thread Serguei Spitsyn
On Tue, 21 Dec 2021 23:12:45 GMT, Chris Plummer wrote: >> clhsdb lost support for the "mem" command when javascript support was >> removed from SA. This PR is re-adding it by implementing it in Java. The >> description of the CR contains all the details. >> >> Regarding the clhsdb.html changes

Re: RFR: 8244669: convert clhsdb "mem" command from javascript to java [v3]

2021-12-21 Thread Serguei Spitsyn
On Tue, 21 Dec 2021 23:01:20 GMT, Chris Plummer wrote: >> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java >> line 560: >> >>> 558: } else { >>> 559: out.println(); >>> 560: } >> >> I wonder if it is possi

Re: RFR: 8244669: convert clhsdb "mem" command from javascript to java [v3]

2021-12-21 Thread Chris Plummer
On Tue, 21 Dec 2021 21:28:43 GMT, Serguei Spitsyn wrote: >> Chris Plummer has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Fix issue with address range patterns. For some reason they have always >> allowed some extra lower case letters

Integrated: 8279024: Remove javascript references from clhsdb.html

2021-12-21 Thread Chris Plummer
On Tue, 21 Dec 2021 02:17:10 GMT, Chris Plummer wrote: > clhsdb no longer supports javascript. Remove some remaining references in the > docs. I also removed some script references. This pull request has now been integrated. Changeset: d0ea7c9d Author:Chris Plummer URL: https://git