Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed [v2]

2022-01-10 Thread Kevin Walls
> Remove the use of Security Manager from jstatd. > Add use of an ObjectInputFilter to restrict RMI. > > Also we can undo the property-setting Launcher.gmk change from: 8279007: > jstatd fails to start because SecurityManager is disabled > ..as that is no longer needed. > > Docs/man page update

RFR: 8279669: test/jdk/com/sun/jdi/TestScaffold.java: Fixed condition

2022-01-10 Thread zzambers
Condition is obviously wrong, because if name starts with "java." other 2 conditions are always true. Intent, as I understand it, was to redefine class where debug event took place (in case of test classes), unless it took place in class of jdk itself, in which case redefine test's main class (i

Re: RFR: 8279669: test/jdk/com/sun/jdi/TestScaffold.java: Fixed condition

2022-01-10 Thread Severin Gehwolf
On Wed, 1 Dec 2021 19:19:02 GMT, zzambers wrote: > Condition is obviously wrong, because if name starts with "java." other 2 > conditions are always true. Intent, as I understand it, was to redefine class > where debug event took place (in case of test classes), unless it took place > in class

Re: RFR: 8279669: test/jdk/com/sun/jdi/TestScaffold.java: Fixed condition

2022-01-10 Thread Severin Gehwolf
On Mon, 10 Jan 2022 10:13:56 GMT, Severin Gehwolf wrote: > @robilad Could you please OCA check this, please? err, nvm. I see those labels have been removed. Sorry for the noise. - PR: https://git.openjdk.java.net/jdk/pull/6652

Re: RFR: 8279669: test/jdk/com/sun/jdi/TestScaffold.java: Fixed condition

2022-01-10 Thread Severin Gehwolf
On Wed, 1 Dec 2021 19:19:02 GMT, zzambers wrote: > Condition is obviously wrong, because if name starts with "java." other 2 > conditions are always true. Intent, as I understand it, was to redefine class > where debug event took place (in case of test classes), unless it took place > in class

Re: RFR: 8176567: nsk/jdi/ReferenceType/instances/instances002: TestFailure: Unexpected size of referenceType.instances(nsk.share.jdi.TestInterfaceImplementer1): 11, expected: 10

2022-01-10 Thread Alex Menkov
On Sun, 2 Jan 2022 04:06:05 GMT, Chris Plummer wrote: > The test is failing because it is detecting an extra instance of > `TestClass1`. The test (the debugger side) first tells the debuggee to create > 10 instances of `TestClass1`. The debugger then uses JDI > `ClassType.newInstance()` to cre

Re: RFR: 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition

2022-01-10 Thread Alex Menkov
On Wed, 1 Dec 2021 19:19:02 GMT, zzambers wrote: > Condition is obviously wrong, because if name starts with "java." other 2 > conditions are always true. Intent, as I understand it, was to redefine class > where debug event took place (in case of test classes), unless it took place > in class

Re: RFR: 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition

2022-01-10 Thread Serguei Spitsyn
On Wed, 1 Dec 2021 19:19:02 GMT, zzambers wrote: > Condition is obviously wrong, because if name starts with "java." other 2 > conditions are always true. Intent, as I understand it, was to redefine class > where debug event took place (in case of test classes), unless it took place > in class

RFR: 8279124: VirtualMachineImpl should check signal handler has installed before sending SIGQUIT

2022-01-10 Thread Xin Liu
There is a handshake protocol between attach and HotSpot. Linux VirtualMachineImpl sends SIGQUIT(3) if the AttachListener has not been initialized. It expects "Signal Dispatcher" to handle SIGBREAK(same as SIGQUIT) and create AttachListener. However, it is possible that attach starts "handshake