Re: RFR: JDK-8280503: Use allStatic.hpp instead of allocation.hpp where possible [v3]

2022-01-25 Thread Thomas Stuefe
On Mon, 24 Jan 2022 20:32:56 GMT, Ioi Lam wrote: > All builds in our CI passed. Thanks a lot, Ioi! - PR: https://git.openjdk.java.net/jdk/pull/7188

Integrated: JDK-8280503: Use allStatic.hpp instead of allocation.hpp where possible

2022-01-25 Thread Thomas Stuefe
On Sat, 22 Jan 2022 13:33:24 GMT, Thomas Stuefe wrote: > JDK-8249944 moved AllStatic to its own header. We should use that one instead > of allocation.hpp where possible to reduce header dependencies. > > This patch: > - replaces includes of allocation.hpp with allstatic.hpp where appropiate >

Re: RFR: 8280166: Extend java/lang/instrument/GetObjectSizeIntrinsicsTest.java test cases [v3]

2022-01-25 Thread Aleksey Shipilev
On Tue, 18 Jan 2022 19:36:18 GMT, Chris Plummer wrote: >> Aleksey Shipilev has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> co

Integrated: 8280166: Extend java/lang/instrument/GetObjectSizeIntrinsicsTest.java test cases

2022-01-25 Thread Aleksey Shipilev
On Tue, 18 Jan 2022 18:33:29 GMT, Aleksey Shipilev wrote: > While working on JDK-8280003, I noticed that > java/lang/instrument/GetObjectSizeIntrinsicsTest.java does not test arrays > with more than 1-byte size elements, and no large arrays (past 4G limit) are > tested either. It would be bett

Re: RFR: 8269542: JDWP: EnableCollection support is no longer spec compliant after JDK-8255987 [v3]

2022-01-25 Thread Chris Plummer
On Thu, 20 Jan 2022 04:22:28 GMT, Chris Plummer wrote: >> The JDWP spec mentions nothing about `DisableCollection` and >> `EnableCollection` tracking the depth or nesting of the commands. This means >> that `EnableCollection` should enable collection no matter how many >> `DisableCollection` c

Integrated: 8269542: JDWP: EnableCollection support is no longer spec compliant after JDK-8255987

2022-01-25 Thread Chris Plummer
On Tue, 18 Jan 2022 20:25:41 GMT, Chris Plummer wrote: > The JDWP spec mentions nothing about `DisableCollection` and > `EnableCollection` tracking the depth or nesting of the commands. This means > that `EnableCollection` should enable collection no matter how many > `DisableCollection` comma

RFR: 8280601: ClhsdbThreadContext.java test is triggering codecache related assert in PointerFinder.find()

2022-01-25 Thread Chris Plummer
It's possible for an address to be in the codecache but not in any CodeBlob. Don't assert in this case. Note I couldn't reproduce this failure. Not sure why since it seemed to reproduce pretty readily in our CI tier7, and I ran with the same options. - Commit messages: - Don't ass

RFR: 8076089: Cleanup: Inline & remove sun.management.Util.newException

2022-01-25 Thread Jaikiran Pai
Can I please get a review for this cleanup that's requested in https://bugs.openjdk.java.net/browse/JDK-8076089? The change here removes a package private method `sun.management.Util.newException(Exception e)` and inlines its implementation at the caller locations. Given the nature of this cha

Re: RFR: 8270199: Most SA tests are skipped on macosx-aarch64 because all executables are signed [v2]

2022-01-25 Thread Chris Plummer
On Wed, 19 Jan 2022 18:22:13 GMT, Chris Plummer wrote: >> For any SA test that attaches to an OSX process (this would be all SA tests >> except for those that test core file support), there is a check to make sure >> that the target jvm process is not a signed binary. If it is, >> SkippedExcep

Re: RFR: 8240908: RetransformClass does not know about MethodParameters attribute [v2]

2022-01-25 Thread Chris Plummer
On Mon, 24 Jan 2022 10:40:44 GMT, Alex Menkov wrote: >> Changes: >> - ClassFileReconstituter is updated to restore "MethodParameters" attribute; >> - handling of the attribute in VM_RedefineClasses is moved to be consistent >> with other code (like local variable table); >> - copied ClassTransfo

Re: RFR: 8240908: RetransformClass does not know about MethodParameters attribute [v2]

2022-01-25 Thread Serguei Spitsyn
On Mon, 24 Jan 2022 10:40:44 GMT, Alex Menkov wrote: >> Changes: >> - ClassFileReconstituter is updated to restore "MethodParameters" attribute; >> - handling of the attribute in VM_RedefineClasses is moved to be consistent >> with other code (like local variable table); >> - copied ClassTransfo