Re: RFR: 8278423: ExtendedDTraceProbes should be deprecated [v8]

2022-02-10 Thread Emanuel Peter
> Deprecated ExtendedDTraceProbes. > Edited help messages and man pages accordingly, added the 3 flags to man > pages. > Added flag to VMDeprecatedOptions test. > Replaced the flag with 3 flags in SDTProbesGNULinuxTest.java. > > Checked that tests are not affected. Emanuel Peter has updated the

Re: RFR: 8278423: ExtendedDTraceProbes should be deprecated [v7]

2022-02-10 Thread Emanuel Peter
On Thu, 10 Feb 2022 05:54:17 GMT, David Holmes wrote: >> Emanuel Peter has updated the pull request incrementally with one additional >> commit since the last revision: >> >> updated warning messages and added 3 flags to man-pages > > src/hotspot/share/runtime/globals.hpp line 1868: > >> 186

Re: RFR: 8278423: ExtendedDTraceProbes should be deprecated [v8]

2022-02-10 Thread David Holmes
On Thu, 10 Feb 2022 08:46:50 GMT, Emanuel Peter wrote: >> Deprecated ExtendedDTraceProbes. >> Edited help messages and man pages accordingly, added the 3 flags to man >> pages. >> Added flag to VMDeprecatedOptions test. >> Replaced the flag with 3 flags in SDTProbesGNULinuxTest.java. >> >> Chec

Re: RFR: 8281267: VM HeapDumper dumps array classes several times

2022-02-10 Thread Alex Menkov
On Wed, 9 Feb 2022 20:17:22 GMT, Chris Plummer wrote: >> ClassLoaderDataGraph::classes_do description says: >> // Walking classes through the ClassLoaderDataGraph include array classes. >> So do_load_class callback should not dump arrays for the classes and dumper >> doesn't need to call Univers

Re: RFR: 8281267: VM HeapDumper dumps array classes several times [v2]

2022-02-10 Thread Alex Menkov
> ClassLoaderDataGraph::classes_do description says: > // Walking classes through the ClassLoaderDataGraph include array classes. > So do_load_class callback should not dump arrays for the classes and dumper > doesn't need to call Universe::basic_type_classes_do (array classes for > primitive typ

Re: RFR: 8281267: VM HeapDumper dumps array classes several times [v2]

2022-02-10 Thread Alex Menkov
On Wed, 9 Feb 2022 19:38:43 GMT, Chris Plummer wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> updated test > > test/hotspot/jtreg/serviceability/HeapDump/DuplicateArrayClassesTest.java > line 58: > >> 56:

RFR: 8281585: Remove unused imports under test/lib and jtreg/gc

2022-02-10 Thread Leo Korinth
Remove unused imports under test/lib and jtreg/gc. They create lots of warnings if editing using an IDE. Tests in hotspot_gc passed. - Commit messages: - 8281585: Remove unused imports under test/lib and jtreg/gc Changes: https://git.openjdk.java.net/jdk/pull/7426/files Webrev: ht

Re: RFR: 8281585: Remove unused imports under test/lib and jtreg/gc

2022-02-10 Thread David Holmes
On Thu, 10 Feb 2022 15:39:53 GMT, Leo Korinth wrote: > Remove unused imports under test/lib and jtreg/gc. They create lots of > warnings if editing using an IDE. Tests in hotspot_gc passed. Looks fine. The proof of these changes is in compiling the files - how did you test the non-gc-test chan

Re: RFR: 8281585: Remove unused imports under test/lib and jtreg/gc

2022-02-10 Thread David Holmes
On Thu, 10 Feb 2022 15:39:53 GMT, Leo Korinth wrote: > Remove unused imports under test/lib and jtreg/gc. They create lots of > warnings if editing using an IDE. Tests in hotspot_gc passed. Forgot to mention copyright years need updating before integrating! Thanks. - PR: https://g

Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v2]

2022-02-10 Thread Yi Yang
On Tue, 18 Jan 2022 02:59:11 GMT, David Holmes wrote: >> Yi Yang has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new commit si

Re: RFR: 8278423: ExtendedDTraceProbes should be deprecated [v8]

2022-02-10 Thread Vladimir Kozlov
On Thu, 10 Feb 2022 08:46:50 GMT, Emanuel Peter wrote: >> Deprecated ExtendedDTraceProbes. >> Edited help messages and man pages accordingly, added the 3 flags to man >> pages. >> Added flag to VMDeprecatedOptions test. >> Replaced the flag with 3 flags in SDTProbesGNULinuxTest.java. >> >> Chec

Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v6]

2022-02-10 Thread David Holmes
On Thu, 27 Jan 2022 09:17:09 GMT, Yi Yang wrote: >> Add VM.classes to print details of all classes, output looks like: >> >> 1. jcmd VM.classes >> >> KlassAddr Size State Flags LoaderName ClassName >> 0x000800c0b400 62 inited W bootstrap >> java.lang.invoke.LambdaForm$MH/0x000800c0b400

Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v6]

2022-02-10 Thread David Holmes
On Thu, 27 Jan 2022 16:00:54 GMT, Ioi Lam wrote: >> Yi Yang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix > > src/hotspot/share/oops/instanceKlass.cpp line 2081: > >> 2079: _st->print(INTPTR_FORMAT " ", p2i(k)); >> 2080: // k