Re: RFR: 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition

2022-02-23 Thread Severin Gehwolf
On Tue, 22 Feb 2022 12:10:46 GMT, zzambers wrote: >> @zzambers do you plan to backport these changes to the old releases and to >> the jdk8 where this test started to fail? > > @mrserb, I have just created jdk8 backport yesterday and I will probably do > other ones soon. Sorry for the delay. @

RFR: 8206187: javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java fails with Port already in use

2022-02-23 Thread Kevin Walls
Test fails occasionally due to a port clash. Presumably the port that was returned by Utils.getFreePort(), is no longer free. The test creates a ProcessBuilder with the parameters for JMX, including port number, and uses that to create a new Process. It should retry with a new port if we fail due

Re: RFR: 8282200: ShouldNotReachHere() reached by AsyncGetCallTrace after JDK-8280422 [v2]

2022-02-23 Thread Johannes Bechberger
> Fixes the mentioned bug by replacing the check in AsyncGetCallTrace using the > newly introduced method `JavaThread::thread_from_jni_environment`. Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision: Add changes by David Holmes

Re: RFR: 8282200: ShouldNotReachHere() reached by AsyncGetCallTrace after JDK-8280422

2022-02-23 Thread Johannes Bechberger
On Mon, 21 Feb 2022 14:43:27 GMT, Johannes Bechberger wrote: > Fixes the mentioned bug by replacing the check in AsyncGetCallTrace using the > newly introduced method `JavaThread::thread_from_jni_environment`. I've updated it. Thanks again. - PR: https://git.openjdk.java.net/jdk/

Re: RFR: 8282076: Merge some debug agent changes from the loom repo

2022-02-23 Thread Alex Menkov
On Thu, 17 Feb 2022 21:32:14 GMT, Chris Plummer wrote: > There are some minor debug agent changes in the loom repo that are not > virtual thread specific, and I would like to merge them into the jdk repo. > This will make the future real merge of loom into jdk a bit cleaner. > > The biggest c

Re: RFR: 8282200: ShouldNotReachHere() reached by AsyncGetCallTrace after JDK-8280422 [v3]

2022-02-23 Thread Johannes Bechberger
> Fixes the mentioned bug by replacing the check in AsyncGetCallTrace using the > newly introduced method `JavaThread::thread_from_jni_environment`. Johannes Bechberger has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differ

Re: RFR: 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition

2022-02-23 Thread zzambers
On Wed, 23 Feb 2022 10:21:03 GMT, Severin Gehwolf wrote: >> @mrserb, I have just created jdk8 backport yesterday and I will probably do >> other ones soon. Sorry for the delay. > > @zzambers the `/backport` command works on a commit, not PR. I.e. go to > https://github.com/openjdk/jdk/commit/4c

Re: RFR: 8282200: ShouldNotReachHere() reached by AsyncGetCallTrace after JDK-8280422 [v3]

2022-02-23 Thread Johannes Bechberger
On Wed, 23 Feb 2022 15:52:31 GMT, Johannes Bechberger wrote: >> Fixes the mentioned bug by replacing the check in AsyncGetCallTrace using >> the newly introduced method `JavaThread::thread_from_jni_environment`. > > Johannes Bechberger has refreshed the contents of this pull request, and > pre

Re: RFR: 8282076: Merge some debug agent changes from the loom repo

2022-02-23 Thread Leonid Mesnik
On Thu, 17 Feb 2022 21:32:14 GMT, Chris Plummer wrote: > There are some minor debug agent changes in the loom repo that are not > virtual thread specific, and I would like to merge them into the jdk repo. > This will make the future real merge of loom into jdk a bit cleaner. > > The biggest c

Re: RFR: 8281614: serviceability/sa/ClhsdbFindPC.java fails with java.lang.RuntimeException: 'In code in NMethod for jdk/test/lib/apps/LingeredApp.steadyState' missing from stdout/stderr [v2]

2022-02-23 Thread Daniel D . Daugherty
On Wed, 23 Feb 2022 05:56:18 GMT, Chris Plummer wrote: >> This test has 4 test cases/modes: two core files test cases and two process. >> Each runs with and w/o `-Xcomp`. The `-Xcomp` test cases are not suppose to >> run when `-XX:+DeoptimizeALot` is used, because the test does some checks >>

Re: RFR: 8282076: Merge some debug agent changes from the loom repo [v2]

2022-02-23 Thread Chris Plummer
> There are some minor debug agent changes in the loom repo that are not > virtual thread specific, and I would like to merge them into the jdk repo. > This will make the future real merge of loom into jdk a bit cleaner. > > The biggest change is moving some code into the new filterAndHandleEve

Re: RFR: 8206187: javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java fails with Port already in use

2022-02-23 Thread Mark Sheppard
On Wed, 23 Feb 2022 13:59:19 GMT, Kevin Walls wrote: > Test fails occasionally due to a port clash. > Presumably the port that was returned by Utils.getFreePort(), is no longer > free. > The test creates a ProcessBuilder with the parameters for JMX, including port > number, and uses that to cre

Re: RFR: 8206187: javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java fails with Port already in use

2022-02-23 Thread Alex Menkov
On Wed, 23 Feb 2022 13:59:19 GMT, Kevin Walls wrote: > Test fails occasionally due to a port clash. > Presumably the port that was returned by Utils.getFreePort(), is no longer > free. > The test creates a ProcessBuilder with the parameters for JMX, including port > number, and uses that to cre

Re: RFR: 8282200: ShouldNotReachHere() reached by AsyncGetCallTrace after JDK-8280422 [v3]

2022-02-23 Thread David Holmes
On Wed, 23 Feb 2022 15:52:31 GMT, Johannes Bechberger wrote: >> Fixes the mentioned bug by replacing the check in AsyncGetCallTrace using >> the newly introduced method `JavaThread::thread_from_jni_environment`. > > Johannes Bechberger has refreshed the contents of this pull request, and > pre

Integrated: 8282076: Merge some debug agent changes from the loom repo

2022-02-23 Thread Chris Plummer
On Thu, 17 Feb 2022 21:32:14 GMT, Chris Plummer wrote: > There are some minor debug agent changes in the loom repo that are not > virtual thread specific, and I would like to merge them into the jdk repo. > This will make the future real merge of loom into jdk a bit cleaner. > > The biggest c

Re: RFR: 8282200: ShouldNotReachHere() reached by AsyncGetCallTrace after JDK-8280422 [v3]

2022-02-23 Thread Johannes Bechberger
On Wed, 23 Feb 2022 20:18:45 GMT, David Holmes wrote: >> Johannes Bechberger has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. The pull request >> contains one n

Re: RFR: 8282200: ShouldNotReachHere() reached by AsyncGetCallTrace after JDK-8280422 [v4]

2022-02-23 Thread David Holmes
On Wed, 23 Feb 2022 21:59:35 GMT, Johannes Bechberger wrote: >> Fixes the mentioned bug by replacing the check in AsyncGetCallTrace using >> the newly introduced method `JavaThread::thread_from_jni_environment`. > > Johannes Bechberger has updated the pull request incrementally with one > addi

Re: RFR: 8282200: ShouldNotReachHere() reached by AsyncGetCallTrace after JDK-8280422 [v4]

2022-02-23 Thread Johannes Bechberger
> Fixes the mentioned bug by replacing the check in AsyncGetCallTrace using the > newly introduced method `JavaThread::thread_from_jni_environment`. Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision: Remove old code

Integrated: 8281614: serviceability/sa/ClhsdbFindPC.java fails with java.lang.RuntimeException: 'In code in NMethod for jdk/test/lib/apps/LingeredApp.steadyState' missing from stdout/stderr

2022-02-23 Thread Chris Plummer
On Sat, 19 Feb 2022 04:00:30 GMT, Chris Plummer wrote: > This test has 4 test cases/modes: two core files test cases and two process. > Each runs with and w/o `-Xcomp`. The `-Xcomp` test cases are not suppose to > run when `-XX:+DeoptimizeALot` is used, because the test does some checks > that