These files are not used in the jdk repository and it'd be a good
cleanup to remove them:
jdk/src/share/classes/com/sun/tools/hat/MANIFEST.mf
jdk/src/share/classes/com/sun/tools/hat/README.txt
jdk/src/share/classes/com/sun/tools/hat/build.xml
https://bugs.openjdk.java.net/browse/JDK-8044034
Looks good. Would be good to put a FIXME on the comment as well so we don’t
forget to remove it.
On May 26, 2014, at 12:25 PM, Vladimir Ivanov vladimir.x.iva...@oracle.com
wrote:
https://bugs.openjdk.java.net/browse/JDK-8034935
http://cr.openjdk.java.net/~vlivanov/8034935/webrev.00
Thanks, Chris.
Will replicate FIXME comment at the end of method comment preamble as well.
Best regards,
Vladimir Ivanov
On 5/27/14 9:05 PM, Christian Thalinger wrote:
Looks good. Would be good to put a FIXME on the comment as well so we don’t
forget to remove it.
On May 26, 2014, at 12:25
Looks good!
Thanks,
/Staffan
On 27 maj 2014, at 18:52, Mandy Chung mandy.ch...@oracle.com wrote:
These files are not used in the jdk repository and it'd be a good cleanup to
remove them:
jdk/src/share/classes/com/sun/tools/hat/MANIFEST.mf
Reviewed; thank you. — John
On May 26, 2014, at 12:25 PM, Vladimir Ivanov vladimir.x.iva...@oracle.com
wrote:
http://cr.openjdk.java.net/~vlivanov/8034935/webrev.00
Vladimir,
It looks good.
Thanks,
Serguei
On 5/26/14 12:25 PM, Vladimir Ivanov wrote:
https://bugs.openjdk.java.net/browse/JDK-8034935
http://cr.openjdk.java.net/~vlivanov/8034935/webrev.00
Citing John's explanation of motivation for this change (from the bug):
There is a coupling from