Re: RFR : 8131061 - Use of -Dcom.sun.management.snmp needs to be examined for modules

Hi Harsha, This looks reasonable. Some comments: sun/management/Agent.java 567ServiceLoader providers = ServiceLoader.load(AgentProvider.class); It should call ServiceLoader::loadInstalled since it should only load the providers from the platform modules. You can also simplify line

Re: 8164523: Clean up metadata for event based tracing

Hi, On 08/20/2016 08:49 PM, Erik Gahlin wrote: Hi, Could I have review of this fix to the event tracing metadata. The patch touches many files, but it doesn't change the control flow, only class and field names. Webrev: http://cr.openjdk.java.net/~egahlin/8164523/ Looks good to me!

RFR : JDK-8066635 - Fix deprecation warnings in java.management module

Hello, Please review changes for fixing deprecation warnings. Bug ID : https://bugs.openjdk.java.net/browse/JDK-8066635 Webrev : http://cr.openjdk.java.net/~sballal/sponsorship/8066635/webrev.00/ Amit

Re: RFR JDK-8152589 : java/lang/management/ThreadMXBean/Locks.java fails intermittently, blocked on wrong object

Hello, Please review the below webrev incorporating David's comments. http://cr.openjdk.java.net/~hb/8152589/webrev.01/ Regards Harsha On Wednesday 17 August 2016 11:45 AM, Harsha Wardhana B wrote: Hi David, I will incorporate changes suggested by you. Let's wait for few more review

RFR: 8161448: 4 JNI exception pending defect groups in DiagnosticCommandImpl.c

Hello All, Please review the below parfait fixes for DiagnosticCommandImpl.c Issue : https://bugs.openjdk.java.net/browse/JDK-8161448 webrev : http://cr.openjdk.java.net/~hb/8161448/webrev.00/ Regards Harsha

RE: 8164523: Clean up metadata for event based tracing

Hi Erik, This looks good, thanks for cleaning this up. Thanks Markus -Original Message- From: Erik Gahlin Sent: den 20 augusti 2016 20:49 To: serviceability-dev@openjdk.java.net Subject: 8164523: Clean up metadata for event based tracing Hi, Could I have review of this fix to the