Re: RFR: JDK-8169232: SA: TestCpoolForInvokeDynamic.java fails with sun.jvm.hotspot.debugger.DebuggerException: binary search bug: should have found entry 1
Hi Jini, This looks good to me. Thanks, Serguei On 11/17/16 19:52, Jini Susan George wrote: Could I get one more reviewer to take a look at this, please? Thanks, Jini. -Original Message- From: Dmitry Samersoff Sent: Wednesday, November 16, 2016 4:06 PM To: Jini Susan George; serviceability-dev@openjdk.java.net Subject: Re: RFR: JDK-8169232: SA: TestCpoolForInvokeDynamic.java fails with sun.jvm.hotspot.debugger.DebuggerException: binary search bug: should have found entry 1 Jini, Looks good to me! -Dmitry On 2016-11-16 07:28, Jini Susan George wrote: Requesting a review of a possible fix for the following issue: https://bugs.openjdk.java.net/browse/JDK-8169232 Webrev: http://cr.openjdk.java.net/~jgeorge/8169232/webrev.00/ Details have been outlined in the bug. Thanks, - Jini Susan George -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources.
Re: RFR - 8169575: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java failing with jtreg tip
Thumbs up. Fred On 11/18/2016 10:43 AM, Harsha Wardhana B wrote: Hello, Please review below webrev incorporating Roger's comment. http://cr.openjdk.java.net/~hb/8169575/webrev.01/ -Harsha On Friday 18 November 2016 09:08 PM, Frederic Parain wrote: "exitVM.*" should be fine to avoid future maintenance burden. Thank you for pointing this out Roger. Fred On 11/18/2016 10:32 AM, Harsha Wardhana B wrote: Hi Roger, I was not sure about adding exitVM.* as that would give permissions for all exit codes. Maybe Fred can comment since he is the test case author. -Harsha On Friday 18 November 2016 08:58 PM, Roger Riggs wrote: Hi Harsha, The addition of the permission for "getProperty.jdk.jar.disabledAlgorithms" is fine. But the addition of a permission for exitVM.95 to satisfy the need of the test harness to exit cleanly should instead be fixed by changing the "exitVM.97" to "exitVM.*" to avoid future maintenance in the case where the test harness changes its exit status. Roger On 11/18/2016 4:47 AM, Harsha Wardhana B wrote: Hello All, Please review below fix for issue https://bugs.openjdk.java.net/browse/JDK-8169575 having webrev at, http://cr.openjdk.java.net/~hb/8169575/webrev.00/ Regards Harsha
Re: RFR - 8169575: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java failing with jtreg tip
+1 On 11/18/2016 10:43 AM, Harsha Wardhana B wrote: Hello, Please review below webrev incorporating Roger's comment. http://cr.openjdk.java.net/~hb/8169575/webrev.01/ -Harsha On Friday 18 November 2016 09:08 PM, Frederic Parain wrote: "exitVM.*" should be fine to avoid future maintenance burden. Thank you for pointing this out Roger. Fred On 11/18/2016 10:32 AM, Harsha Wardhana B wrote: Hi Roger, I was not sure about adding exitVM.* as that would give permissions for all exit codes. Maybe Fred can comment since he is the test case author. -Harsha On Friday 18 November 2016 08:58 PM, Roger Riggs wrote: Hi Harsha, The addition of the permission for "getProperty.jdk.jar.disabledAlgorithms" is fine. But the addition of a permission for exitVM.95 to satisfy the need of the test harness to exit cleanly should instead be fixed by changing the "exitVM.97" to "exitVM.*" to avoid future maintenance in the case where the test harness changes its exit status. Roger On 11/18/2016 4:47 AM, Harsha Wardhana B wrote: Hello All, Please review below fix for issue https://bugs.openjdk.java.net/browse/JDK-8169575 having webrev at, http://cr.openjdk.java.net/~hb/8169575/webrev.00/ Regards Harsha
Re: RFR - 8169575: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java failing with jtreg tip
Hello, Please review below webrev incorporating Roger's comment. http://cr.openjdk.java.net/~hb/8169575/webrev.01/ -Harsha On Friday 18 November 2016 09:08 PM, Frederic Parain wrote: "exitVM.*" should be fine to avoid future maintenance burden. Thank you for pointing this out Roger. Fred On 11/18/2016 10:32 AM, Harsha Wardhana B wrote: Hi Roger, I was not sure about adding exitVM.* as that would give permissions for all exit codes. Maybe Fred can comment since he is the test case author. -Harsha On Friday 18 November 2016 08:58 PM, Roger Riggs wrote: Hi Harsha, The addition of the permission for "getProperty.jdk.jar.disabledAlgorithms" is fine. But the addition of a permission for exitVM.95 to satisfy the need of the test harness to exit cleanly should instead be fixed by changing the "exitVM.97" to "exitVM.*" to avoid future maintenance in the case where the test harness changes its exit status. Roger On 11/18/2016 4:47 AM, Harsha Wardhana B wrote: Hello All, Please review below fix for issue https://bugs.openjdk.java.net/browse/JDK-8169575 having webrev at, http://cr.openjdk.java.net/~hb/8169575/webrev.00/ Regards Harsha
Re: RFR - 8169575: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java failing with jtreg tip
"exitVM.*" should be fine to avoid future maintenance burden. Thank you for pointing this out Roger. Fred On 11/18/2016 10:32 AM, Harsha Wardhana B wrote: Hi Roger, I was not sure about adding exitVM.* as that would give permissions for all exit codes. Maybe Fred can comment since he is the test case author. -Harsha On Friday 18 November 2016 08:58 PM, Roger Riggs wrote: Hi Harsha, The addition of the permission for "getProperty.jdk.jar.disabledAlgorithms" is fine. But the addition of a permission for exitVM.95 to satisfy the need of the test harness to exit cleanly should instead be fixed by changing the "exitVM.97" to "exitVM.*" to avoid future maintenance in the case where the test harness changes its exit status. Roger On 11/18/2016 4:47 AM, Harsha Wardhana B wrote: Hello All, Please review below fix for issue https://bugs.openjdk.java.net/browse/JDK-8169575 having webrev at, http://cr.openjdk.java.net/~hb/8169575/webrev.00/ Regards Harsha
Re: RFR - 8169575: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java failing with jtreg tip
Hi Roger, I was not sure about adding exitVM.* as that would give permissions for all exit codes. Maybe Fred can comment since he is the test case author. -Harsha On Friday 18 November 2016 08:58 PM, Roger Riggs wrote: Hi Harsha, The addition of the permission for "getProperty.jdk.jar.disabledAlgorithms" is fine. But the addition of a permission for exitVM.95 to satisfy the need of the test harness to exit cleanly should instead be fixed by changing the "exitVM.97" to "exitVM.*" to avoid future maintenance in the case where the test harness changes its exit status. Roger On 11/18/2016 4:47 AM, Harsha Wardhana B wrote: Hello All, Please review below fix for issue https://bugs.openjdk.java.net/browse/JDK-8169575 having webrev at, http://cr.openjdk.java.net/~hb/8169575/webrev.00/ Regards Harsha
Re: RFR - 8169575: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java failing with jtreg tip
Hi Harsha, The addition of the permission for "getProperty.jdk.jar.disabledAlgorithms" is fine. But the addition of a permission for exitVM.95 to satisfy the need of the test harness to exit cleanly should instead be fixed by changing the "exitVM.97" to "exitVM.*" to avoid future maintenance in the case where the test harness changes its exit status. Roger On 11/18/2016 4:47 AM, Harsha Wardhana B wrote: Hello All, Please review below fix for issue https://bugs.openjdk.java.net/browse/JDK-8169575 having webrev at, http://cr.openjdk.java.net/~hb/8169575/webrev.00/ Regards Harsha
Re: RFR - 8169575: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java failing with jtreg tip
Looks good to me. Fred On 11/18/2016 04:47 AM, Harsha Wardhana B wrote: Hello All, Please review below fix for issue https://bugs.openjdk.java.net/browse/JDK-8169575 having webrev at, http://cr.openjdk.java.net/~hb/8169575/webrev.00/ Regards Harsha
Re: JDK 9 RFR of JDK-8169949: Remove java/lang/instrument/BootClassPath/BootClassPathTest.sh from ProblemList.txt
Looks fine. Roger On 11/18/2016 1:57 AM, Amy Lu wrote: Please review the patch to bring back test: java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Mac OSX As mentioned in JDK-8072130, failure is not reproducible. I also tested it with different version of macOS, test all pass. JPRT results for all platforms are good, test pass. bug: https://bugs.openjdk.java.net/browse/JDK-8169949 Thanks, Amy --- old/test/ProblemList.txt2016-11-18 14:51:43.0 +0800 +++ new/test/ProblemList.txt2016-11-18 14:51:43.0 +0800 @@ -132,8 +132,6 @@ java/lang/instrument/RedefineBigClass.sh 8065756 generic-all java/lang/instrument/RetransformBigClass.sh 8065756 generic-all -java/lang/instrument/BootClassPath/BootClassPathTest.sh 8072130 macosx-all - java/lang/management/MemoryMXBean/Pending.java 8158837 generic-all java/lang/management/MemoryMXBean/PendingAllGC.sh 8158837 generic-all
RFR - 8169575: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java failing with jtreg tip
Hello All, Please review below fix for issue https://bugs.openjdk.java.net/browse/JDK-8169575 having webrev at, http://cr.openjdk.java.net/~hb/8169575/webrev.00/ Regards Harsha
