Re: RFR: [SA testbug]: JDK-8175512: new TestPrintMdo.java fails with -XX:TieredStopAtLevel=1

2017-02-26 Thread Dmitry Samersoff 
Looks good to me!

On 2017-02-27 08:01, Jini George wrote:
> Requesting a review for the one line fix for the following testbug:
> 
> https://bugs.openjdk.java.net/browse/JDK-8175512
> Webrev: http://cr.openjdk.java.net/~jgeorge/8175512/webrev.00/
> 
> Thanks,
> Jini.


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.

RFR: [SA testbug]: JDK-8175512: new TestPrintMdo.java fails with -XX:TieredStopAtLevel=1

2017-02-26 Thread Jini George 

Requesting a review for the one line fix for the following testbug:

https://bugs.openjdk.java.net/browse/JDK-8175512
Webrev: http://cr.openjdk.java.net/~jgeorge/8175512/webrev.00/

Thanks,
Jini.

RFR - [RFE] JDK-8007141 : Introduce Dynamic MBean exposing the perf counters

2017-02-26 Thread Harsha Wardhana B 

Hi All,

Please review the below RFE,

JDK-8007141  : Introduce Dynamic MBean exposing the 
perf counters.


with webrev at,

http://cr.openjdk.java.net/~hb/8007141/webrev.00/

Appreciate if I can get inputs for below.

1. Location of HotSpotPerfCounterMBean. It is located at 
src/jdk.management/share/classes/com/sun/management/internal. It can be 
moved to src/jdk.management/share/classes/com/sun/management if required.


2. Javadoc comments for HotSpotPerfCounterMBean. Not sure if it is adequate.

3. Description for each attribute of MBean. I am using getUnits(), 
getVariability(), and getFlags() for description. I am not sure if that 
is the right description. Appreciate inputs from someone who knows perf 
counters well.


Thanks

Harsha