RFR(M) : 8177507 : line number sensitive tests for jdi should be unified

2017-03-24 Thread Igor Ignatyev
http://cr.openjdk.java.net/~iignatyev/8177507/webrev.00 > 295 lines changed: 176 ins; 15 del; 104 mod; Hi all, could you please review this fix for 8177507? due to their nature, some of jdi tests are line number sensitive. unfortunately different tests indicate that differently, so it's quite

Re: RFR(S) : 8177374 : fix module dependency declaration in jdk_svc tests

2017-03-24 Thread Igor Ignatyev
> On Mar 24, 2017, at 12:10 AM, Alan Bateman wrote: > On 23/03/2017 22:06, Igor Ignatyev wrote: >> >>> I can see what the information tags might be grouped but @library and >>> @modules should also be grouped with the @compile/@run/@build). >> from my point of view,

Re: PRE-RFR: 8177154: Default configuration should disallow loading agents

2017-03-24 Thread serguei.spit...@oracle.com
Alan, Thank you for the suggestions. I've updated my repository accordingly. Thanks, Serguei On 3/24/17 01:59, Alan Bateman wrote: On 24/03/2017 08:45, serguei.spit...@oracle.com wrote: Please, pre-review the JDK 9 fix for: https://bugs.openjdk.java.net/browse/JDK-8177154 JDK webrev:

Re: PRE-RFR: 8177154: Default configuration should disallow loading agents

2017-03-24 Thread Mario Torre
On Fri, Mar 24, 2017 at 12:15 PM, Alan Bateman wrote: > I expect it will have to be relaxed at some point to allow root FWIW, we had the need for such use case in Thermostat and we had to work around this requirement, Elliot even sent a patch some time ago. With that

Re: PRE-RFR: 8177154: Default configuration should disallow loading agents

2017-03-24 Thread Mario Torre
On Fri, Mar 24, 2017 at 10:48 AM, Alan Bateman wrote: > On 24/03/2017 09:34, Remi Forax wrote: > >> : >> >> One of strong feature that makes choosing Java on server is that you can >> attach, at runtime, a monitoring/troubleshooting tool when an event occurs, >> please do

Re: PRE-RFR: 8177154: Default configuration should disallow loading agents

2017-03-24 Thread Alan Bateman
On 24/03/2017 12:09, Andrew Dinn wrote: : I am unclear as to why you say there was never an intention to 'use the attach API from regular applications or libraries'. Perhaps this was just a bad design decision in the way VirtualMachine.attach or the native code which underpins it was crafted.

Re: PRE-RFR: 8177154: Default configuration should disallow loading agents

2017-03-24 Thread Andrew Dinn
On 24/03/17 11:15, Alan Bateman wrote: > Just to re-cap, the Attach API has several users: > > 1. The troubleshooting tools such as jcmd, jstack, and jmap > 2. Management tools that use the API to start a JMX agent > 3. Tools that load JVM TI or java agents into running VMs. > > The proposal

Re: PRE-RFR: 8177154: Default configuration should disallow loading agents

2017-03-24 Thread Alan Bateman
On 24/03/2017 10:09, Andrew Dinn wrote: : The point I think Remi is making is that /pragmatically/ we will be back in pre-JDK6 land with the current proposed default. You blithely use the words 'the launch script can specify' above. In practice, your use of the definite article belies the fact

Re: PRE-RFR: 8177154: Default configuration should disallow loading agents

2017-03-24 Thread Andrew Dinn
On 24/03/17 09:48, Alan Bateman wrote: > This does not send us back to the pre JDK 6. The changes have no impact > on the troubleshooting tools and no impact on management tools that use > the attach API to start the JMX agent in the running VM. The change is > simply to make loading of arbitrary

Re: PRE-RFR: 8177154: Default configuration should disallow loading agents

2017-03-24 Thread Alan Bateman
On 24/03/2017 09:34, Remi Forax wrote: : One of strong feature that makes choosing Java on server is that you can attach, at runtime, a monitoring/troubleshooting tool when an event occurs, please do not send us back to the pre Java 6 world ! This does not send us back to the pre JDK 6. The

Re: PRE-RFR: 8177154: Default configuration should disallow loading agents

2017-03-24 Thread Remi Forax
Please, can we have a discussion on the merit of not of allowing loadAgent by default before discussing about how to implement that. There is only one interesting method in VirtualMachine, loadAgent, and if this method do not work by default, there is no point to have the whole API. If you have

Re: PRE-RFR: 8177154: Default configuration should disallow loading agents

2017-03-24 Thread Alan Bateman
On 24/03/2017 08:45, serguei.spit...@oracle.com wrote: Please, pre-review the JDK 9 fix for: https://bugs.openjdk.java.net/browse/JDK-8177154 JDK webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8177154-agents.jdk0/ Hotspot webrev:

Re: RFR(S) : 8177374 : fix module dependency declaration in jdk_svc tests

2017-03-24 Thread Alan Bateman
On 23/03/2017 22:06, Igor Ignatyev wrote: Hi Alan, I can see what the information tags might be grouped but @library and @modules should also be grouped with the @compile/@run/@build). from my point of view, there are 3 different groups of tags: - information tags: @test, @bug, @key,