RE: [PATCH] attach in linux should be relative to /proc/pid/root and namespace aware

2017-08-17 Thread Chris Plummer
Hi TJ, JDK-8179498 is assigned to me. I've been playing around with your changes to make sure they work fine, and plan on sponsoring the commit. I did run into one issue. It ended up being user error, but highlights a gap in the jcmd docker support. More specifically, "jcmd -l" and "jcmd "

RFR (S) 8185687: Fix minor bugs in jvmti specification

2017-08-17 Thread serguei.spit...@oracle.com
Please, review a fix for the bug:   https://bugs.openjdk.java.net/browse/JDK-8185687 Webrev:   http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8185687-jvmti-spec.1/ Summary:   The DocCheck utility reports 4 errors in

Re: RFR(XS): 8185112: [TESTBUG] Servicability tests cannot parse float if non US locale.

2017-08-17 Thread Volker Simonis
Thanks Goetz - looks good now! And sorry for the delay :) Volker On Thu, Aug 3, 2017 at 11:30 AM, Lindenmaier, Goetz wrote: > Hi Volker, > >> OK, I don't want to unnecessarily block this change but IMO if we >> don't need the integer parsing function at all we should