Re: RFR: 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents [v9]

2020-10-09 Thread Vladimir Kozlov
On Thu, 8 Oct 2020 16:55:31 GMT, Richard Reingruber wrote: >> Hi, >> >> this is the continuation of the review of the implementation for: >> >> https://bugs.openjdk.java.net/browse/JDK-8227745 >> https://bugs.openjdk.java.net/browse/JDK-8233915 >> >> It allows for JIT optimizations based on

Re: RFR: 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents [v9]

2020-10-09 Thread Vladimir Kozlov
On Thu, 8 Oct 2020 16:55:31 GMT, Richard Reingruber wrote: >> Hi, >> >> this is the continuation of the review of the implementation for: >> >> https://bugs.openjdk.java.net/browse/JDK-8227745 >> https://bugs.openjdk.java.net/browse/JDK-8233915 >> >> It allows for JIT optimizations based on

Integrated: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible)

2020-10-09 Thread Severin Gehwolf
On Fri, 2 Oct 2020 16:34:49 GMT, Severin Gehwolf wrote: > An issue similar to > [JDK-8239559](https://bugs.openjdk.java.net/browse/JDK-8239559) has been > discovered. On the > affected system, `/proc/self/mountinfo` contains a line such as this one: > > 35 26 0:26 / /sys/fs/cgroup/systemd

Re: RFR: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible) [v8]

2020-10-09 Thread Severin Gehwolf
> An issue similar to > [JDK-8239559](https://bugs.openjdk.java.net/browse/JDK-8239559) has been > discovered. On the > affected system, `/proc/self/mountinfo` contains a line such as this one: > > 35 26 0:26 / /sys/fs/cgroup/systemd rw,nosuid,nodev,noexec,relatime - cgroup > systemd

Re: RFR: 8252103: Parallel heap inspection for ParallelScavengeHeap

2020-10-09 Thread Lin Zang
On Fri, 9 Oct 2020 14:16:51 GMT, Lin Zang wrote: >> Hi Lin, >> >> Sorry for not getting to this sooner. One of the reasons is that I haven't >> had time to explore a better solution, but >> the above notification triggered me to at least share my thoughts. >> I would like us to avoid having

Re: RFR: 8252103: Parallel heap inspection for ParallelScavengeHeap

2020-10-09 Thread Lin Zang
On Fri, 9 Oct 2020 11:10:14 GMT, Stefan Johansson wrote: >> Dear All, >> May I ask your help to review this PR? Thanks! >> -Lin > > Hi Lin, > > Sorry for not getting to this sooner. One of the reasons is that I haven't > had time to explore a better solution, but > the above notification

Integrated: 8253900: SA: wrong size computation when JVM was built without AOT

2020-10-09 Thread Ziviani
On Fri, 25 Sep 2020 13:13:44 GMT, Ziviani wrote: > TestInstanceKlassSize was failing because, for PowerPC, the following code > (instanceKlass.cpp) always compiles to > `return false;` bool InstanceKlass::has_stored_fingerprint() const { > #if INCLUDE_AOT > return should_store_fingerprint()

Re: RFR: 8252103: Parallel heap inspection for ParallelScavengeHeap

2020-10-09 Thread Stefan Johansson
On Fri, 11 Sep 2020 07:25:37 GMT, Lin Zang wrote: >> - Parallel heap iteration support for PSS >> - JBS: https://bugs.openjdk.java.net/browse/JDK-8252103 > > Dear All, > May I ask your help to review this PR? Thanks! > -Lin Hi Lin, Sorry for not getting to this sooner. One of the reasons is

Re: RFR: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible) [v6]

2020-10-09 Thread Severin Gehwolf
On Fri, 9 Oct 2020 09:51:29 GMT, Aleksey Shipilev wrote: >> I don't think so. It starts out as `false` and is being set to true on lines >> 180 and 174. So we could change it to >> `return false` here iff lines 174 and 180 would `return true`. > > Yes, that's what I meant: instead of dragging

Re: RFR: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible) [v7]

2020-10-09 Thread Severin Gehwolf
> An issue similar to > [JDK-8239559](https://bugs.openjdk.java.net/browse/JDK-8239559) has been > discovered. On the > affected system, `/proc/self/mountinfo` contains a line such as this one: > > 35 26 0:26 / /sys/fs/cgroup/systemd rw,nosuid,nodev,noexec,relatime - cgroup > systemd

Re: RFR: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible) [v6]

2020-10-09 Thread Aleksey Shipilev
On Fri, 9 Oct 2020 09:46:55 GMT, Severin Gehwolf wrote: >> src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemFactory.java >> line 183: >> >>> 181: } >>> 182: } >>> 183: return relevantControllerFound; >> >> If I am reading the code right, then

Re: RFR: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible) [v6]

2020-10-09 Thread Severin Gehwolf
On Fri, 9 Oct 2020 09:23:22 GMT, Aleksey Shipilev wrote: >> Severin Gehwolf has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Return false in case of no pattern match > >

Re: RFR: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible) [v6]

2020-10-09 Thread Aleksey Shipilev
On Thu, 8 Oct 2020 13:38:59 GMT, Severin Gehwolf wrote: >> An issue similar to >> [JDK-8239559](https://bugs.openjdk.java.net/browse/JDK-8239559) has been >> discovered. On the >> affected system, `/proc/self/mountinfo` contains a line such as this one: >> >> 35 26 0:26 /

Integrated: 8253180: ZGC: Implementation of JEP 376: ZGC: Concurrent Thread-Stack Processing

2020-10-09 Thread Erik Österlund
On Tue, 22 Sep 2020 11:43:41 GMT, Erik Österlund wrote: > This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack > Processing" (cf. > https://openjdk.java.net/jeps/376). > Basically, this patch modifies the epilog safepoint when returning from a > frame (supporting interpreter

Re: RFR: 8253180: ZGC: Implementation of JEP 376: ZGC: Concurrent Thread-Stack Processing [v13]

2020-10-09 Thread Erik Österlund
> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack > Processing" (cf. > https://openjdk.java.net/jeps/376). > Basically, this patch modifies the epilog safepoint when returning from a > frame (supporting interpreter frames, c1, c2, > and native wrapper frames), to compare the

Re: RFR: JDK-8247589: Implementation of Alpine Linux/x64 Port [v6]

2020-10-09 Thread David Holmes
On Thu, 8 Oct 2020 10:52:53 GMT, Aleksei Voitylov wrote: >> continuing the review thread from here >> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068546.html >> >>> The download side of using JNI in these tests is that it complicates the >>> setup a bit for those that