Re: RFR(S) : 8183040 : update jdk/test/lib/Platform.java to use NIO file API

2020-06-09 Thread Brian Burkhalter
Hi Igor, > On Jun 9, 2020, at 4:47 PM, Igor Ignatyev wrote: > > could you please review this small clean up of testlibrary classes which > updates j.t.lib.Platform and j.t.l.SA.SATestUtils (as it now contains the > methods which 8183040 was about) to use NIO file API? > > testing: test/hotspo

6504660: HPI panic callback is dead code

2019-03-08 Thread Brian Burkhalter
Looping in serviceability-dev@openjdk.java.net. Thanks, Brian > Begin forwarded message: > > From: Claes Redestad > Subject: Re: 6504660: HPI panic callback is dead code > Date: March 7, 2019 at 9:43:45 AM GMT > To: Brian Burkhalter , core-libs-dev > > >

hg: jdk8/tl/jdk: 8010430: Math.round has surprising behavior for odd values of ulp 1

2013-09-20 Thread brian . burkhalter
Changeset: 917fffe971c8 Author:bpb Date: 2013-09-11 17:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/917fffe971c8 8010430: Math.round has surprising behavior for odd values of ulp 1 Summary: If the effective floating point exponent is zero return the significand includin

hg: jdk8/tl/jdk: 8024331: j.u.Map.computeIfPresent() default/nondefault implementations don't throw NPE if the remappingFunction is null and the key is absent

2013-09-20 Thread brian . burkhalter
mmary: Explicitly check for null remappingFunction parameter. Reviewed-by: mduigou, forax, psandoz Contributed-by: Brian Burkhalter ! src/share/classes/java/util/HashMap.java ! src/share/classes/java/util/Map.java ! test/java/util/Map/Defaults.java

hg: jdk8/tl/jdk: 8016252: More defensive HashSet.readObject

2013-10-09 Thread brian . burkhalter
Changeset: b86e6700266e Author:bpb Date: 2013-10-09 11:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b86e6700266e 8016252: More defensive HashSet.readObject Summary: Add data validation checks in readObject(). Reviewed-by: alanb, mduigou, chegar Contributed-by: Brian

hg: jdk8/tl/jdk: 7189139: BigInteger's staticRandom field can be a source of bottlenecks.

2013-10-09 Thread brian . burkhalter
andoz Contributed-by: Brian Burkhalter ! src/share/classes/java/math/BigInteger.java

hg: jdk8/tl/jdk: 8010371: getaddrinfo can fail with EAI_SYSTEM/EAGAIN, causes UnknownHostException to be thrown

2013-10-15 Thread brian . burkhalter
. Reviewed-by: alanb, chegar, michaelm, dsamersoff Contributed-by: Brian Burkhalter ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/windows/native/java/net/Inet4AddressImpl.c ! src/windows/native/java/net/Inet6AddressImpl.c

hg: jdk8/tl/jdk: 8026832: Clean up straggling doclint warnings in java.math

2013-10-17 Thread brian . burkhalter
Changeset: e76bb2436b04 Author:bpb Date: 2013-10-17 15:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e76bb2436b04 8026832: Clean up straggling doclint warnings in java.math Summary: Fix empty paragraph tag warnings. Reviewed-by: lancea ! src/share/classes/java/math/BigDe

hg: jdk8/tl/jdk: 8026806: Incomplete test of getaddrinfo() return value could lead to incorrect exception for Windows Inet 6

2013-10-22 Thread brian . burkhalter
Changeset: 9758edb6976f Author:bpb Date: 2013-10-22 10:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9758edb6976f 8026806: Incomplete test of getaddrinfo() return value could lead to incorrect exception for Windows Inet 6 Summary: Check getaddrinfo return value before ca

hg: jdk8/tl/jdk: 7179567: JCK8 tests: api/java_net/URLClassLoader/index.html#Ctor3 failed with NPE; ...

2013-10-22 Thread brian . burkhalter
Changeset: 2be08cdd1ced Author:bpb Date: 2013-10-22 11:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2be08cdd1ced 7179567: JCK8 tests: api/java_net/URLClassLoader/index.html#Ctor3 failed with NPE 6445180: URLClassLoader does not describe the behavior of several methods w

hg: jdk8/tl/jdk: 6910473: java.math.BigInteger.bitLength() may return negative "int" on large numbers; ...

2013-10-30 Thread brian . burkhalter
Changeset: 0734e1584d9d Author:bpb Date: 2013-10-30 17:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0734e1584d9d 6910473: java.math.BigInteger.bitLength() may return negative "int" on large numbers 8021203: BigInteger.doubleValue/floatValue returns 0.0 instead of Infini

hg: jdk8/tl/jdk: 8027625: test/java/math/BigInteger/ExtremeShiftingTests.java needs @run tag to specify heap size

2013-11-04 Thread brian . burkhalter
Changeset: 92fb6baaebc4 Author:bpb Date: 2013-11-04 08:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/92fb6baaebc4 8027625: test/java/math/BigInteger/ExtremeShiftingTests.java needs @run tag to specify heap size Summary: Add @run tag to specify heap size Reviewed-by: alan

hg: jdk8/tl/jdk: 8022181: Tune algorithm crossover thresholds in BigInteger

2013-12-03 Thread brian . burkhalter
Changeset: c138b0d33980 Author:bpb Date: 2013-12-03 12:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c138b0d33980 8022181: Tune algorithm crossover thresholds in BigInteger Summary: Change multiplication, squaring, division, and base conversion thresholds to values which

hg: jdk8/tl/jdk: 2 new changesets

2013-12-05 Thread brian . burkhalter
Changeset: d3c4e8fe98c3 Author:bpb Date: 2013-12-05 07:44 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d3c4e8fe98c3 8029514: java/math/BigInteger/BigIntegerTest.java failing since thresholds adjusted in 8022181 Summary: Ensure the value returned by getLower() is unsigned.

Re: JDK 9 RFR of 8038163: Build failure on Mac OS 10.9.2 (Mavericks) due to warning treated as error

2014-03-21 Thread Brian Burkhalter
On Mar 21, 2014, at 12:44 PM, Staffan Larsen wrote: > Looks good to me. Thanks. > The version with JNI_TRUE/JNI_FALSE is more correct, but I’m fine with either > one. Updated to this form: http://cr.openjdk.java.net/~bpb/8038163/webrev.01/ > (note: this review request should have been sen

Re: RFR: 8253497: Core Libs Terminology Refresh [v2]

2020-12-15 Thread Brian Burkhalter
On Tue, 15 Dec 2020 01:46:08 GMT, Brent Christian wrote: >> This is part of an effort in the JDK to replace archaic/non-inclusive words >> with more neutral terms (see JDK-8253315 for details). >> >> Here are the changes covering core libraries code and tests. Terms were >> changed as follows

Re: RFR: 8253497: Core Libs Terminology Refresh [v3]

2020-12-15 Thread Brian Burkhalter
On Tue, 15 Dec 2020 22:21:12 GMT, Brent Christian wrote: >> This is part of an effort in the JDK to replace archaic/non-inclusive words >> with more neutral terms (see JDK-8253315 for details). >> >> Here are the changes covering core libraries code and tests. Terms were >> changed as follows

Re: Integrated: 8276367: ProblemList vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java

2021-11-02 Thread Brian Burkhalter
On Tue, 2 Nov 2021 16:34:26 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java Marked as reviewed by bpb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6214

Re: RFR: 8277346: ProblemList 7 serviceability/sa tests on macosx-x64

2021-11-17 Thread Brian Burkhalter
On Wed, 17 Nov 2021 20:43:46 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList 7 serviceability/sa tests on macosx-x64. Marked as reviewed by bpb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6438

Re: [jdk18] Integrated: 8278521: ProblemList java/lang/management/ThreadMXBean/ThreadLists.java

2021-12-09 Thread Brian Burkhalter
On Thu, 9 Dec 2021 21:57:13 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > java/lang/management/ThreadMXBean/ThreadLists.java on all configs. Marked as reviewed by bpb (Reviewer). - PR: https://git.openjdk.java.net/jdk18/pull/3

Re: RFR: 8283800: Simplify String.indexOf/lastIndexOf calls

2022-03-28 Thread Brian Burkhalter
On Sun, 20 Mar 2022 12:45:34 GMT, Andrey Turbanov wrote: > In a few places String.indexOf/lastIndexOf methods are called with default > parameter for index: `0` for `indexOf`, length() for `lastIndexOf`. > I propose to cleanup such calls. It makes code a bit easier to read. In case > of `indexO

Re: Integrated: 8284015: ProblemList containers/docker/TestJcmd.java on linux-x64

2022-03-30 Thread Brian Burkhalter
On Wed, 30 Mar 2022 15:09:08 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList containers/docker/TestJcmd.java on linux-x64. Marked as reviewed by bpb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8042

Re: RFR: 8284853: Fix varios 'expected' typo

2022-04-13 Thread Brian Burkhalter
On Wed, 13 Apr 2022 20:36:48 GMT, Andrey Turbanov wrote: > Found various typos of expected: `exepected`, `exept`, `epectedly`, > `expeced`, `Unexpeted`, etc. Expect the Unexpeted. - Marked as reviewed by bpb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8231

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v8]

2022-04-27 Thread Brian Burkhalter
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in the