Re: Access to jdk.hotspot.agent classes in Java 9?

2018-11-21 Thread David Griffiths
gt; David Holmes > > On 21/11/2018 2:48 am, Daniel D. Daugherty wrote: > > Adding serviceability-dev@... since this is the Serviceability Agent... > > > > Dan > > > > > > On 11/20/18 11:33 AM, David Griffiths wrote: > >> Hi, I'm writing some code t

Suggested improvement to X86Frame.getInterpreterFrameBCI

2018-11-21 Thread David Griffiths
Hi, I'm new to this mailing list and working on a project that makes use of the SA classes to get stack traces from a paused in flight JVM (we can't use JDWP). I have observed that if the top frame is in the interpreter it reports the BCI and line number incorrectly. This is because X86Frame.getInt

Re: Suggested improvement to X86Frame.getInterpreterFrameBCI

2018-11-21 Thread David Griffiths
'm not a reviewer for OpenJDK so this is really just my > 2cents, > Jc > > On Wed, Nov 21, 2018 at 9:17 AM David Griffiths > wrote: > >> Hi, I'm new to this mailing list and working on a project that makes use >> of the SA classes to get stack traces from a pau

Re: Suggested improvement to X86Frame.getInterpreterFrameBCI

2018-11-21 Thread David Griffiths
PS: should have added a new X86Frame constructor really, may have just been put off because there is already a four address constructor so would have had to add dummy argument or something. On Wed, 21 Nov 2018 at 19:15, David Griffiths wrote: > Hi, thanks, apart from adding a setter for R13

Re: Suggested improvement to X86Frame.getInterpreterFrameBCI

2018-11-22 Thread David Griffiths
tch for the review (With > a first cut look, there seems to be missing pieces). > > I have created a bug for this: > > https://bugs.openjdk.java.net/browse/JDK-8214226 > > Thank you, > Jini > > On 11/22/2018 12:50 AM, David Griffiths wrote: > > PS: should have ad

Re: Suggested improvement to X86Frame.getInterpreterFrameBCI

2018-12-03 Thread David Griffiths
rote: > >> Your patch looks good to me, David. I can sponsor this for you if we get >> one more review. >> >> Thanks, >> Jini. >> >> On 11/22/2018 5:42 PM, David Griffiths wrote: >> > Thanks Jini, please find patch for Java 9 attached (

Re: Suggested improvement to X86Frame.getInterpreterFrameBCI

2018-12-05 Thread David Griffiths
-) > > But these are nits :), > Jc > > On Fri, Nov 30, 2018 at 6:21 AM Jini George > wrote: > >> Your patch looks good to me, David. I can sponsor this for you if we get >> one more review. >> >> Thanks, >> Jini. >> >> On 11/22/201

Re: getPCDescNearDbg returns incorrect PCDesc

2019-01-17 Thread David Griffiths
: > >> Hi David, >> >> re-posting to serviceability mailing list since you're referring to a >> method from >> >> https://docs.oracle.com/javase/jp/8/docs/serviceabilityagent/sun/jvm/hotspot/code/NMethod.html >> >> Best regards, >> Martin >

Re: getPCDescNearDbg returns incorrect PCDesc

2019-01-17 Thread David Griffiths
s: - PcDescTest.run(int) @bci=7, line=18 (Compiled frame; information may be imprecise) - PcDescTest.() @bci=12, line=10 (Compiled frame) - PcDescTest.main(java.lang.String[]) @bci=4, line=5 (Interpreted frame) but as you can see the caller line is now incorrect. Cheers, David On Thu, 17 Jan 2019 at

Re: getPCDescNearDbg returns incorrect PCDesc

2019-01-17 Thread David Griffiths
= nm.getScopeDescNearDbg(f.getPC()); } else { scope = nm.getScopeDescAt(f.getPC()); } because mayBeImprecise is only set for the top frame. Cheers, David On Thu, 17 Jan 2019 at 11:35, David Griffiths wrote: > > Here is example as promised. First the test program: &

Re: getPCDescNearDbg returns incorrect PCDesc

2019-01-21 Thread David Griffiths
ith > your proposed fix ? > > I have not been able to delve deeper into this yet. Your fix for the > callers (calling getScopeDescAt() instead of getScopeDescNearDbg()) > seems correct to me. > > Thanks, > Jini. > > On 1/17/2019 5:05 PM, David Griffiths wrote: > >

Is RegisterMap updated?

2019-01-29 Thread David Griffiths
Hi, in CompiledVFrame.createStackValue there is the following code: // First find address of value Address valueAddr = loc.isRegister() // Value was in a callee-save register ? getRegisterMap().getLocation(new VMReg(loc.getRegisterNumber())) // Else value was di

Re: Is RegisterMap updated?

2019-01-29 Thread David Griffiths
that calls setLocation). Cheers, David On Tue, 29 Jan 2019 at 13:41, Andrew Haley wrote: > > On 1/29/19 11:24 AM, David Griffiths wrote: > > Hi, in CompiledVFrame.createStackValue there is the following code: > > > > // First find address of value > >

Re: Is RegisterMap updated?

2019-01-29 Thread David Griffiths
Oops, ignore that last message! On Tue, 29 Jan 2019 at 15:41, David Griffiths wrote: > > Oh, I'm looking at the jdk8u code which has the following code commented out: > > /* > if (map.getUpdateMap()) { > // Tell GC to use argument oopmaps for some run

Re: Is RegisterMap updated?

2019-01-30 Thread David Griffiths
d in a register (the other ones are on the stack). Not sure what a register number of 16 equates to on x86, is that supposed to correspond to "not set" or something? Cheers, David On Tue, 29 Jan 2019 at 13:41, Andrew Haley wrote: > > On 1/29/19 11:24 AM, Da

Re: Is RegisterMap updated?

2019-02-01 Thread David Griffiths
Had a nice simple little reproduction test, went to try it on Java 9 and... oh no, sun.jvm.hotspot.jdi.SACoreAttachingConnector has disappeared! Has it gone for good? Cheers, David On Wed, 30 Jan 2019 at 10:38, Andrew Haley wrote: > > On 1/30/19 10:00 AM, David Griffiths wrote: >

Re: Is RegisterMap updated?

2019-02-02 Thread David Griffiths
enjdk.java.net/browse/JDK-8158050). Could you let us > know as to why are you using SA-JDI ? > > Thanks, > Jini. > > On 2/1/2019 9:56 PM, David Griffiths wrote: > > Had a nice simple little reproduction test, went to try it on Java 9 > > and... oh no, sun.jvm