Hi Mandy,
Regarding the javac changes - should those be switched on/off depending
the Target? Or, if one compiles with e.g. --release 14, will the newly
generated output still work on JDK 14?
Jan
On 27. 03. 20 0:57, Mandy Chung wrote:
Please review the implementation of JEP 371: Hidden Class
Changeset: 41599b57d262
Author:jlahoda
Date: 2013-09-20 16:33 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/41599b57d262
8023835: TreeMaker.QualIdent() too leafy
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java
+ test/tools/javac/tree/MakeQ
Changeset: 8d1c48de706d
Author:jlahoda
Date: 2013-09-19 17:05 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8d1c48de706d
8022567: Javac Should Generate Warnings For Raw Array Type
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/comp/Check.java
! test/tools/ja
Changeset: 9235ae08a449
Author:jlahoda
Date: 2013-09-26 20:07 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9235ae08a449
8025491: Javac regression test
tools/javac/T8003967/DetectMutableStaticFields.java failing
Summary: Making HtmlTree.NONENCODING_CHARS final
Reviewe
Changeset: b7d8b71e1658
Author:jlahoda
Date: 2013-09-27 17:28 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b7d8b71e1658
8022765: Compiler crashes with exception on wrong usage of an annotation.
Summary: Error recovery for incorrect annotation attribute values - ensure
Changeset: c13305cf8528
Author:jlahoda
Date: 2013-10-04 08:29 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c13305cf8528
8025118: Annotation processing api returns default modifier for interface
without default methods
Summary: TypeElement.getModifiers() should not co
Changeset: 0be3f1820e8b
Author:jlahoda
Date: 2013-10-09 13:06 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0be3f1820e8b
8025141: java.lang.ClassFormatError: Illegal field modifiers in class (...)
Summary: Should not generate non-public $assertionsDisabled field into
Changeset: 872c4a898b38
Author:jlahoda
Date: 2013-10-11 15:49 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/872c4a898b38
6278240: Exception from AnnotationValue.getValue() should list the found type
not the required type
Reviewed-by: darcy, jfranck, jjg
! src/share/c
Changeset: 87b5bfef7edb
Author:jlahoda
Date: 2013-10-14 22:11 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/87b5bfef7edb
8014016: javac is too late detecting invalid annotation usage
Summary: Adding new queue to Annotate for validation tasks, performing
annotation val
Changeset: 79649bf21a92
Author:jlahoda
Date: 2013-10-15 16:23 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/79649bf21a92
8026180: com.sun.source.tree.NewArrayTree refers to
com.sun.tools.javac.util.List
Summary: Correcting import in NewArrayTree, adding test protectin
Changeset: 19e8eebfbe52
Author:jlahoda
Date: 2013-10-15 22:15 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/19e8eebfbe52
8026510: The name of com.sun.tools.javac.comp.Annotate.Annotator is confusing
Summary: A mostly automated rename Annotate.Annotator->Annotate.Worker
Changeset: b05db8c815e8
Author:jlahoda
Date: 2013-10-23 07:50 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b05db8c815e8
8026508: Invokedynamic instructions don't get line number table entries
Summary: Setting or correcting positions for many trees produced by
LambdaT
Changeset: abc3eaccba73
Author:jlahoda
Date: 2013-10-23 23:02 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/abc3eaccba73
8027191: Fix for JDK-8026861 refers to an incorrect bug number
Summary: Reverting changeset b05db8c815e8, so that it can be applied again with
a co
Changeset: 8b4e1421a9b7
Author:jlahoda
Date: 2013-11-01 21:43 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8b4e1421a9b7
8027310: Annotation Processor crashes with NPE
Summary: JCAnnotation.attribute is null when annotation type is unavailable
Reviewed-by: jjg, jfranck
Changeset: 75c8cde12ab6
Author:jlahoda
Date: 2013-11-06 17:48 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/75c8cde12ab6
8027281: Incorrect invokespecial generated for JCK lang
EXPR/expr636/expr63602m* tests
Summary: When invoking interface default method via a superc
Changeset: 6e0f31d61e56
Author:jlahoda
Date: 2013-11-09 15:24 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6e0f31d61e56
8027142: Invokedynamic instructions don't get line number table entries
Summary: When emitting invokedynamic instruction, write pendingStatPos, if s
Changeset: 7c89d200781b
Author:jlahoda
Date: 2013-11-20 13:44 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7c89d200781b
6557966: Multiple upper bounds of the TypeVariable
Summary: Adjusting javax.lang.model javadoc regarding IntersectionType,
IntersectionType.accept
Changeset: 8acb838c9b79
Author:jlahoda
Date: 2013-11-26 15:27 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8acb838c9b79
8026374: javac accepts void as a method parameter
Summary: Changing Check.validate to reject void types.
Reviewed-by: jjg, vromero
! src/share/clas
Changeset: a746587a1ff1
Author:jlahoda
Date: 2013-12-03 18:50 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a746587a1ff1
8028699: Compiler crash during speculative attribution of annotated type
Summary: Moving the checkForDeclarationAnnotations check into
Attr.TypeAnn
On Fri, 25 Sep 2020 15:47:30 GMT, Peter Levart wrote:
>> [CSR: Record Classes](https://bugs.openjdk.java.net/browse/JDK-8253605)
>
> Hi @vicente-romero-oracle , note that besides tests, there is also a JMH
> benchmark that measures the performance of
> records deserialization (org.openjdk.bench.
cy
>> Co-authored-by: Chris Hegarty
>> Co-authored-by: Jan Lahoda
>
> Vicente Romero has updated the pull request incrementally with one additional
> commit since the last revision:
>
> adding missing changes to some tests
Marked as reviewed by jlahoda (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/290
On Sun, 2 May 2021 02:10:26 GMT, Vicente Romero wrote:
>> Please review this PR that intents to make sealed classes a final feature in
>> Java. This PR contains compiler and VM changes. In line with similar PRs,
>> which has made preview features final, this one is mostly removing preview
>> r
On Thu, 13 Jan 2022 14:01:04 GMT, Pavel Rappo wrote:
>> - Most of the typos are of a trivial kind: missing whitespace.
>> - If any of the typos should be fixed in the upstream projects instead,
>> please say so; I will drop those typos from the patch.
>> - As I understand it, ` ` in ImageInputSt
23 matches
Mail list logo
