Re: 8196989: Revamp G1 JMX MemoryPool and GarbageCollector MXBean definitions

2018-10-23 Thread Man Cao
Hi Paul, I looked at the code in detail, and didn't find any major problem. A few small issues below. I'm not a Reviewer, though. File Separator-- In http://cr.openjdk.java.net/~phh/8196989/webrev.04/src/hotspot/share/gc/g1/g1Monitoring

RFR (S): 8223177: Data race on JvmtiEnvBase::_tag_map in double-checked locking

2019-04-30 Thread Man Cao
Hi all, Can I have reviews for this small change that adds memory fences for double-checked locking? We found this race while working on the Java ThreadSanitizer project. Webrev: https://cr.openjdk.java.net/~manc/8223177/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8223177 -Man