f verbosity but of audience, we'll leave it
as it is.
Thanks,
Rachel
Thanks,
Marcus
Thanks,
Coleen
On 10/15/15 6:33 PM, Ioi Lam wrote:
On 10/15/15 10:51 AM, Rachel Protacio wrote:
Hi, Ioi,
Thanks for the comments. While all valid points, the decision by
the serviceability team
_len];
vsprintf(buf, fmt, args);
I don't think this would work anyway. A char[] needs a static size.
Thanks,
Rachel
-Dmitry
On 2015-10-26 23:58, Rachel Protacio wrote:
Hello, all,
Please review this fix to the faulty write function from the Unified
Logging framework.
Summary: In logg
DK-8138916
Includes own acceptance test, and passes JPRT and remote hotspot/test
tests.
Thank you,
Rachel
On 10/28/2015 4:08 PM, Rachel Protacio wrote:
Thanks for the review and all the feedback!
Rachel
On 10/28/2015 4:05 PM, Dmitry Samersoff wrote:
Rachel,
Looks good for me!
-Dmitry
On 2015-1
Webrev: http://cr.openjdk.java.net/~rprotacio/8139564.03/
Thank you,
Rachel
On 10/29/2015 6:35 AM, Marcus Larsson wrote:
Hi,
On 2015-10-28 21:59, Rachel Protacio wrote:
Including serviceability-dev. Recap:
Summary: In logging/log.hpp, the logging vwrite function previously
asserted that the b
5-11-04 10:49, Marcus Larsson wrote:
Looks good, thank you for fixing this!
Regards,
Marcus
On 2015-11-02 19:03, Rachel Protacio wrote:
Thanks for the comments, Marcus. I've undone the "logtest" tag and
instead created an InternalVMTest in log.cpp that writes the
518-character s
ith a call to fgets should
fix this.
Regards,
Marcus
On 2015-11-04 10:49, Marcus Larsson wrote:
Looks good, thank you for fixing this!
Regards,
Marcus
On 2015-11-02 19:03, Rachel Protacio wrote:
Thanks for the comments, Marcus. I've undone the "logtest" tag and
instead created
Great, thank you, Marcus!
Rachel
On 11/4/2015 2:59 PM, Marcus Larsson wrote:
Looks good!
Regards,
Marcus
On 2015-11-04 20:49, Rachel Protacio wrote:
Updated webrev with this fgets change:
http://cr.openjdk.java.net/~rprotacio/8139564.04/
Passes JPRT tests.
Thank you,
Rachel
On 11/4/2015
Hello,
Please see my small changeset to add two develop levels to UL.
Summary: This adds develop (that is, non-product) logging levels to the
Unified Logging framework in order to support performance, footprint,
and usefulness-of-output considerations while maintaining the ability
for the use
Hi,
Please review the following small logging enhancement.
Summary: The former -XX:+TraceVMOperation flag is updated to the unified
logging framework and is now replaced with -Xlog:vmoperation in product
mode.
Open webrev: http://cr.openjdk.java.net/~rprotacio/8143157/
Bug: https://bugs.open
he
function, even, to make it only evaluate once?
There really is nothing quite like typing code into an editor with
misaligned columns.
Anyway, the change looks pretty good to me.
-Max
On 11/18/2015 4:22 AM, David Holmes wrote:
Hi Rachel,
On 18/11/2015 5:50 AM, Rachel Protacio wrote:
Hi,
Please
Hello!
On 11/19/2015 3:48 AM, kirk.pepperd...@gmail.com wrote:
Hi David,
You enable the logging with "-Xlog:vmoperation=debug". If you leave of
the "=" portion, it is by default parsed as "=info". We don't
believe this vmoperation logging needs to come out by default in the
case where someone
onTestMain
[0.262s][debug ][vmoperation] begin VM_Operation
(0x7f01a029a700): G1CollectFull, mode: safepoint, requested by
thread 0x7f0198018000
[0.278s][debug ][vmoperation] end VM_Operation
(0x7f01a029a700): G1CollectFull, mode: safepoint, requested by
thread 0
w:
[VM_Operation (0xf6773e40): GenCollectForAllocation, mode: safepoint,
requested by thread 0xf660f400]
Thanks,
David
On 21/11/2015 5:27 AM, Rachel Protacio wrote:
Thank you, David, Kirk, Marcus, Max, and Coleen, for all your comments.
Updated webrev: http://cr.openjdk.java.net/~rprotaci
Hello,
Please review my conversion of -XX:+TraceExceptions to
-Xlog:exceptions=info. The existing (product) flag is aliased to the
logging flag at the info level.
If you have any questions on the alias table (in the arguments.cpp and
.hpp files), Max will chime in as he is the one who implem
Hi,
Thanks for the review. Replies inline.
Updated webrev: http://cr.openjdk.java.net/~rprotacio/8141211.01/
On 12/8/2015 10:53 PM, David Holmes wrote:
Hi Rachel,
On 9/12/2015 1:42 AM, Rachel Protacio wrote:
Hello,
Please review my conversion of -XX:+TraceExceptions to
-Xlog:exceptions=info
Hi,
(Sorry if this sent twice. Thunderbird is acting up.)
Thanks for the review. Replies inline.
Updated webrev: http://cr.openjdk.java.net/~rprotacio/8141211.01/
On 12/8/2015 10:53 PM, David Holmes wrote:
Hi Rachel,
On 9/12/2015 1:42 AM, Rachel Protacio wrote:
Hello,
Please review my
Hello!
Please review another product flag logging change. This one's pretty
small. Converts TraceMonitorInflation to -Xlog:monitorinflation=debug
internally, with an alias for the old option. I've again patched in
Max's alias table code in the arguments.cpp and .hpp files since my
previous ch
Hi David,
Thanks for the review! Updated webrev:
http://cr.openjdk.java.net/~rprotacio/8145153.01/
On 12/10/2015 7:53 PM, David Holmes wrote:
Hi Rachel,
On 11/12/2015 8:21 AM, Rachel Protacio wrote:
Hello!
Please review another product flag logging change. This one's pretty
ply
updated it. http://cr.openjdk.java.net/~rprotacio/8141211.01
Thanks,
Rachel
On 12/9/2015 1:12 PM, Rachel Protacio wrote:
Hi,
(Sorry if this sent twice. Thunderbird is acting up.)
Thanks for the review. Replies inline.
Updated webrev: http://cr.openjdk.java.net/~rprotacio/8141211.01/
On 12/
schema in particular
works fine.
Replies inline.
On 12/13/2015 11:08 PM, David Holmes wrote:
Hi Rachel,
On 12/12/2015 7:38 AM, Rachel Protacio wrote:
Hello! An update and updated webrev.
I've rewritten the two portions of code that had used ttyLockers to
print in one function-call, since
Hi,
On 12/16/2015 3:52 PM, David Holmes wrote:
Hi Rachel,
On 16/12/2015 6:26 AM, Rachel Protacio wrote:
Hi,
Thanks for the comments, David.
I had messed up my uploading before and had not actually updated the
open html. So for real this time, the most recent webrev is at
http
lto:david.hol...@oracle.com>> wrote:
On 18/12/2015 7:14 PM, Bengt Rutisson wrote:
On 2015-12-18 06:44, David Holmes wrote:
On 17/12/2015 6:41 PM, Bengt Rutisson wrote:
On 2015-12-16 22:43, Coleen Phillimore wrote:
On 12/16/15 4:01 PM, John Rose wrote:
On Dec 15, 2015, at 12:26 PM, Rachel Protacio
you,
Rachel
On 12/16/2015 6:39 PM, David Holmes wrote:
Hi Rachel,
On 17/12/2015 7:33 AM, Rachel Protacio wrote:
Hi,
On 12/16/2015 3:52 PM, David Holmes wrote:
Hi Rachel,
On 16/12/2015 6:26 AM, Rachel Protacio wrote:
Hi,
Thanks for the comments, David.
I had messed up my uploading bef
Thank you, David!
Rachel
On 12/22/2015 11:26 PM, David Holmes wrote:
Thanks Rachel - looks good.
David
On 22/12/2015 7:46 AM, Rachel Protacio wrote:
Hi,
Please take a look at my updated changeset! Webrev:
http://cr.openjdk.java.net/~rprotacio/8141211.02/
I've fixed the multi
24 matches
Mail list logo
