Re: RFR: 8254723: add diagnostic command to write Linux perf map file [v2]

2020-10-27 Thread Xin Liu
On Wed, 21 Oct 2020 09:13:08 GMT, Nick Gasson wrote: >> When using the Linux "perf" tool to do system profiling, symbol names of >> running Java methods cannot be decoded, resulting in unhelpful output >> such as: >> >> 10.52% [JIT] tid 236748 [.] 0x7f6fdb75d223 >> >> Perf can read a simp

Re: RFR: 8254723: add diagnostic command to write Linux perf map file [v2]

2020-10-27 Thread Xin Liu
On Tue, 27 Oct 2020 17:08:18 GMT, Xin Liu wrote: >> Nick Gasson has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update for review comments > > src/hotspot/share/code/codeCache.cpp line 1566: > &

Re: RFR: 8265047: Inconsistent warning message in jcmd VM.log

2021-05-04 Thread Xin Liu
On Tue, 13 Apr 2021 04:23:52 GMT, Koichi Sakata wrote: > When reconfiguring log output options of an existing log setting with jcmd > VM.log and the file name, a warning message is shown. However, when > reconfiguring them with jcmd VM.log and the output index, the message is not > shown. > >

Re: RFR: 8269652: Factor out the common code for creating system j.l.Thread objects

2021-07-02 Thread Xin Liu
On Fri, 2 Jul 2021 07:03:50 GMT, David Holmes wrote: > Please review this simple refactoring to share the common code used to create > j.l.Thread instances for the internal VM JavaThreads. (Also fix a missing > space from my previous change in thread.cpp.) > > It is all very straight-forward.

Re: RFR: 8269652: Factor out the common code for creating system j.l.Thread objects

2021-07-03 Thread Xin Liu
On Fri, 2 Jul 2021 07:03:50 GMT, David Holmes wrote: > Please review this simple refactoring to share the common code used to create > j.l.Thread instances for the internal VM JavaThreads. (Also fix a missing > space from my previous change in thread.cpp.) > > It is all very straight-forward.

Re: RFR: 8279134: Fix Amazon copyright in various files

2021-12-23 Thread Xin Liu
On Wed, 22 Dec 2021 09:07:24 GMT, Sergey Bylokhov wrote: > This bug is similar to https://bugs.openjdk.java.net/browse/JDK-8244094 > > Currently, some of the files in the OpenJDK repo have Amazon copyright > notices which are all slightly different and do not conform to Amazons > preferred cop

RFR: 8279124: VirtualMachineImpl should check signal handler has installed before sending SIGQUIT

2022-01-10 Thread Xin Liu
There is a handshake protocol between attach and HotSpot. Linux VirtualMachineImpl sends SIGQUIT(3) if the AttachListener has not been initialized. It expects "Signal Dispatcher" to handle SIGBREAK(same as SIGQUIT) and create AttachListener. However, it is possible that attach starts "handshake

Re: RFR: 8279124: VirtualMachineImpl should check signal handler has installed before sending SIGQUIT

2022-01-18 Thread Xin Liu
On Mon, 17 Jan 2022 06:11:22 GMT, David Holmes wrote: >> There is a handshake protocol between attach and HotSpot. Linux >> VirtualMachineImpl sends SIGQUIT(3) if the AttachListener has not been >> initialized. It expects "Signal Dispatcher" to handle SIGBREAK(same as >> SIGQUIT) and create At

Re: RFR: 8279124: VirtualMachineImpl should check signal handler has installed before sending SIGQUIT [v2]

2022-01-18 Thread Xin Liu
t; at > jdk.attach/sun.tools.attach.VirtualMachineImpl.(VirtualMachineImpl.java:105) > at > jdk.attach/sun.tools.attach.AttachProviderImpl.attachVirtualMachine(AttachProviderImpl.java:58) > at > jdk.attach/com.sun.tools.attach.VirtualMachine.attach(VirtualMachine.java:207) >

Re: RFR: 8279124: VirtualMachineImpl should check signal handler has installed before sending SIGQUIT

2022-01-18 Thread Xin Liu
On Mon, 17 Jan 2022 09:52:04 GMT, Thomas Stuefe wrote: >>> I propose a simpler and more robust way to fix it though >> >> Great, this is the kind of thing I was heading towards with the conversation >> in the bug text. Although not sure why I could not reproduce the problem, >> with various d

Re: RFR: 8279124: VirtualMachineImpl should check signal handler has installed before sending SIGQUIT [v2]

2022-01-18 Thread Xin Liu
On Wed, 19 Jan 2022 06:49:54 GMT, Thomas Stuefe wrote: >> Xin Liu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Intercept SIGQUIT in the early stage of HotSpot. > > src/hotspot/os/posix/signals_posix.c

Re: RFR: 8279124: VirtualMachineImpl should check signal handler has installed before sending SIGQUIT

2022-01-18 Thread Xin Liu
On Mon, 17 Jan 2022 09:52:04 GMT, Thomas Stuefe wrote: > > > I propose a simpler and more robust way to fix it though > > > > > > Great, this is the kind of thing I was heading towards with the > > conversation in the bug text. Although not sure why I could not reproduce > > the problem, with

Re: RFR: 8279124: VirtualMachineImpl should check signal handler has installed before sending SIGQUIT [v2]

2022-01-19 Thread Xin Liu
On Wed, 19 Jan 2022 06:47:12 GMT, Thomas Stuefe wrote: >> Xin Liu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Intercept SIGQUIT in the early stage of HotSpot. > > src/hotspot/os/posix/signals_p

Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v2]

2022-01-19 Thread Xin Liu
On Wed, 19 Jan 2022 07:18:03 GMT, Ioi Lam wrote: > > > > It seems it would be useful to support the verbose output with just a > > > > single class that is specified, although that would suggest that the > > > > dcmd name should then be something other than `VM.classes`. > > > > > > > > > Thi

Re: RFR: 8279124: VirtualMachineImpl should check signal handler has installed before sending SIGQUIT [v3]

2022-01-19 Thread Xin Liu
t; at > jdk.attach/sun.tools.attach.VirtualMachineImpl.(VirtualMachineImpl.java:105) > at > jdk.attach/sun.tools.attach.AttachProviderImpl.attachVirtualMachine(AttachProviderImpl.java:58) > at > jdk.attach/com.sun.tools.attach.VirtualMachine.attach(VirtualMachine.java:207) >

Re: RFR: 8279124: VM does not handle SIGQUIT during initialization [v2]

2022-01-19 Thread Xin Liu
On Wed, 19 Jan 2022 08:36:38 GMT, Thomas Stuefe wrote: >> I would not print anything here, first because it is in the signal handler >> and secondly I don't think it is needed. No real thread dump usages are >> going to hit a VM that hasn't initialized yet IMO. > >> This is in the signal handle

Re: RFR: 8279124: VM does not handle SIGQUIT during initialization [v3]

2022-01-19 Thread Xin Liu
On Wed, 19 Jan 2022 09:10:56 GMT, Xin Liu wrote: >> In early stage of initialization, HotSpot doesn't handle SIGQUIT. The >> default signal preposition on Linux is to quit the process and generate >> coredump. >> >> There are 2 applications for this signal.

Re: RFR: 8279124: VM does not handle SIGQUIT during initialization [v4]

2022-01-19 Thread Xin Liu
jdk.jcmd/sun.tools.jcmd.JCmd.main(JCmd.java:97) > $openjdk version "19-internal" 2022-09-20 > OpenJDK Runtime Environment (fastdebug build 19-internal+0-adhoc.xxinliu.jdk) > OpenJDK 64-Bit Server VM (fastdebug build 19-internal+0-adhoc.xxinliu.jdk, > mixed mode, sharing) &

Re: RFR: 8279124: VM does not handle SIGQUIT during initialization [v3]

2022-01-19 Thread Xin Liu
On Wed, 19 Jan 2022 12:39:31 GMT, Kevin Walls wrote: >> Xin Liu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Only install JVM_HANDLE_XXX_SIGNAL when ReduceSignalUsage is >> false(default value). >

Re: RFR: 8279124: VM does not handle SIGQUIT during initialization [v5]

2022-01-19 Thread Xin Liu
jdk.jcmd/sun.tools.jcmd.JCmd.main(JCmd.java:97) > $openjdk version "19-internal" 2022-09-20 > OpenJDK Runtime Environment (fastdebug build 19-internal+0-adhoc.xxinliu.jdk) > OpenJDK 64-Bit Server VM (fastdebug build 19-internal+0-adhoc.xxinliu.jdk, > mixed mode, sharing) >

Re: RFR: 8279124: VM does not handle SIGQUIT during initialization [v2]

2022-01-19 Thread Xin Liu
On Wed, 19 Jan 2022 12:06:49 GMT, David Holmes wrote: >> Sorry for being difficult, but I would not do UL logging here. UL is >> heavyweight, and a shifting target too, because folks like to extend it with >> new capabilities. God knows what log_info really does (initialization, >> network tra

Re: RFR: 8279124: VM does not handle SIGQUIT during initialization [v5]

2022-01-20 Thread Xin Liu
On Thu, 20 Jan 2022 07:00:23 GMT, David Holmes wrote: >> Xin Liu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove log_info from the signal handler. > > src/hotspot/os/posix/signals_posix.cpp l

Re: RFR: 8279124: VM does not handle SIGQUIT during initialization [v6]

2022-01-20 Thread Xin Liu
jdk.jcmd/sun.tools.jcmd.JCmd.main(JCmd.java:97) > $openjdk version "19-internal" 2022-09-20 > OpenJDK Runtime Environment (fastdebug build 19-internal+0-adhoc.xxinliu.jdk) > OpenJDK 64-Bit Server VM (fastdebug build 19-internal+0-adhoc.xxinliu.jdk, > mixed mode

Re: RFR: 8279124: VM does not handle SIGQUIT during initialization [v7]

2022-01-21 Thread Xin Liu
jdk.jcmd/sun.tools.jcmd.JCmd.main(JCmd.java:97) > $openjdk version "19-internal" 2022-09-20 > OpenJDK Runtime Environment (fastdebug build 19-internal+0-adhoc.xxinliu.jdk) > OpenJDK 64-Bit Server VM (fastdebug build 19-internal+0-adhoc.xxinliu.jdk, > mixed mode, sharing)

Integrated: 8279124: VM does not handle SIGQUIT during initialization

2022-01-23 Thread Xin Liu
On Mon, 10 Jan 2022 05:19:26 GMT, Xin Liu wrote: > In early stage of initialization, HotSpot doesn't handle SIGQUIT. The default > signal preposition on Linux is to quit the process and generate coredump. > > There are 2 applications for this signal. > 1. There's a h