Re: DumpJFR tool

Hi Yasumasa, The DumpJFR tool relied on SA, which was too much of a burden to maintain (slowing down the development of new JFR features). I think tool was removed in Oracle JDK 9, at least it was completely broken at that time. Functionality has been added that allows JFR to dump an emerge

Re: DumpJFR tool

On 2019-10-24 16:52, Yasumasa Suenaga wrote: On 2019/10/24 22:50, Erik Gahlin wrote: Hi Yasumasa, The DumpJFR tool relied on SA, which was too much of a burden to maintain (slowing down the development of new JFR features). I think tool was removed in Oracle JDK 9, at least it was

Re: 8233197(S): Invert JvmtiExport::post_vm_initialized() and Jfr:on_vm_start() start-up order for correct option parsing

Looks good. Erik On 2019-11-20 21:54, Markus Gronlund wrote: "It does not look as a good idea to change the JVMTI phase like above.   If you need the ONLOAD phase just to enable capabilities then it is better to do it in the real ONLOAD phase.   Do I miss anything important here?   Please

Re: RFR(s): 8243451: nsk.share.jdi.Debugee.isJFR_active() is incorrect and corresponsing logic seems to be broken

Hi Fairoz, If the test needs to run with builds where the JFR module is not present(?), you need to do the check using reflection. If not, looks good. Erik > On 1 Jun 2020, at 10:27, Fairoz Matte wrote: > > Hi, > > Please review this small test infra change to identify at runtime the JFR i

Re: RFR(s): 8243451: nsk.share.jdi.Debugee.isJFR_active() is incorrect and corresponsing logic seems to be broken

e wrote: Hi Erik, Thanks for your quick response, Below is the updated webrev to handle if jfr module is not present http://cr.openjdk.java.net/~fmatte/8243451/webrev.01/ Thanks, Fairoz -----Original Message- From: Erik Gahlin Sent: Monday, June 1, 2020 2:31 PM To: Fairoz Matte Cc: servi

Re: JDK-8171311 Current state

The reason to put this into the JDK is to standardize the protocol. If you want to build a client today, you must build one for every adapter because they have different ways to represent URLs etc. The JDK is in unique position to set the standard, since the implementation comes by default.

Re: 8215534: [testbug] some jfr test don't check @requires vm.hasJFR

Looks good. Erik Hi, These tests lack @requires vm.hasJFR, thus they are failing on AIX. http://cr.openjdk.java.net/~goetz/wr18/8215334-JFR_requires/01/ Please review. I will push this to jdk12 as it is a testbug if I miss the RDP deadline. Best regards, Goetz.

Re: [RFR]: Per thread IO statistics in JFR

Hi Gunter, Sounds like a useful enhancement! Do you have an idea of what the overhead might be? Does it work on Mac OS X? I haven't done a proper review, but you could change the contentType to "bits-per-second”. That is what we use for the Network Utilization event which reports statistics

Re: Protocol version of Attach API

On 2019-02-26 07:47, Thomas Stüfe wrote: Hi David, Yasumasa, > Do we support connection to later VMs from earlier JDK tools? I could not find the spec about this. So I asked to serviceability folks before filing this to JBS :-) Just to chime in on that, I do not know if it is sp

Re: [PATCH] attach in linux should be relative to /proc/pid/root and namespace aware

I am not a (R)eviewer, so I can't give it my blessings, but I can sponsor it. I will create a webrev so it easier to review. Erik I have attached a patch that allows jcmd to work against a java process running inside a Docker container. Apologies if this is not in the correct format. It was

Re: [PATCH] attach in linux should be relative to /proc/pid/root and namespace aware

I noticed thatgetNamespacePid throws IOException and InvalidPathException. Perhaps we want to catch those, so we can default to the original pid if there is a I/O related problem. Erik Hey, I’ve attached a version rebased on jdk10, it also (currently) applies cleanly to jdk9. While there is

Re: RFR: JDK-8185003 JMX: Add a version of ThreadMXBean.dumpAllThreads with a maxDepth argument

Looks good, not a reviewer. Nit, saw that spaces before commas were missing in some method calls, i.e. ",-1" instead of ", -1" Erik Hi, kindly review the changes made. https://bugs.openjdk.java.net/browse/JDK-8185003 webrev: http://cr.openjdk.java.net/~uvangapally/webrev/2017/8185003/web

Re: JEP review : JDK-8171311 - REST APIs for JMX

Hi Harsha, Looping in jmx-dev. > byte[], short[], int[], float[], double[] Should long[] be included there as well? > The REST adapter will come with a simple and lightweight JSON parser. Is this an internal parser or will it be exposed as an API? If so, how does it relate to JEP 198: Light-

Re: jmx-dev JEP review : JDK-8171311 - REST APIs for JMX

y a drop in replacement for the standard RMI based JMX connector but it’s not far off. Kind regards, Kirk On Sep 5, 2017, at 6:30 PM, Erik Gahlin <mailto:erik.gah...@oracle.com> wrote: Hi Harsha, Looping in jmx-dev. byte[], short[], int[], float[], double[]

Re: jmx-dev JEP review : JDK-8171311 - REST APIs for JMX

iance on RMI. Consolidating all of the options under a single flag looks like another interesting win. Kind regards, Kirk On Sep 11, 2017, at 4:08 PM, Harsha Wardhana B <mailto:harsha.wardhan...@oracle.com>> wrote: Hi Erik, On Monday 11 September 2017 07:14 PM, Erik Gahlin wro

Re: RFR: 8187042: Events to show which objects are associated with biased object revocations

dk.java.net/browse/JDK-8187042> > Webrev (courtesy of Erik Gahlin): > http://cr.openjdk.java.net/~egahlin/8187042/ > <http://cr.openjdk.java.net/~egahlin/8187042/> > > Best regards, > Robin

RFR(XS): 8189274: Allow cutoff attribute for event based tracing

Hi, Could I have a review of this small change that will add the capability to use a cutoff attribute on an event. Webrev: http://cr.openjdk.java.net/~egahlin/8189274/ Bug: https://bugs.openjdk.java.net/browse/JDK-8189274 Thanks Erik

Re: RFR(XS): 8173917: Safepoint ID is not consistent across event-based tracing events

Look good. Should I push this change before the new events? Thanks Erik > On 13 Oct 2017, at 16:54, Robin Westberg wrote: > > Hi all, > > Please review the following change that aligns the safepointId value for the > SafepointStateSynchronization event to be consistent with the other related

RFR(S): 8189425: Minor updates in support of closed changes

Hi, Could I have a review of this change that will adjust an assertion and remove a lock associated with JFR. Webrev: http://cr.openjdk.java.net/~egahlin/8189425_0 Bug: https://bugs.openjdk.java.net/browse/JDK-8189425 Thanks Erik

RFR: 8189440: Event tracing macros for allocation and weak oops processing

Hi, Could I have a review of a change that adds two macros to be used with event-based JVM tracing. Bug: https://bugs.openjdk.java.net/browse/JDK-8189440 Webrev: http://cr.openjdk.java.net/~egahlin/8189440_0 Thanks Erik

Re: RFR: 8189440: Event tracing macros for allocation and weak oops processing

Hi David, Hi Erik, On 18/10/2017 12:34 PM, Erik Gahlin wrote: Hi, Could I have a review of a change that adds two macros to be used with event-based JVM tracing. Bug: https://bugs.openjdk.java.net/browse/JDK-8189440 Webrev: http://cr.openjdk.java.net/~egahlin/8189440_0 Reviewed

Re: RFR(S): 8189425: Minor updates in support of closed changes

Hi David, Hi Erik, On 18/10/2017 12:23 PM, Erik Gahlin wrote: Hi, Could I have a review of this change that will adjust an assertion and Can you explain the adjustment please. We have closed code that modifies the mark word and then changes it back during a safepoint. When the mark word

Re: RFR(S): 8189425: Minor updates in support of closed changes

Thanks for the review, David and Markus! Erik Hi Erik, Looks good. Thanks Markus -Original Message- From: Erik Gahlin Sent: den 18 oktober 2017 22:05 To: David Holmes; serviceability-dev@openjdk.java.net Subject: Re: RFR(S): 8189425: Minor updates in support of closed changes Hi

Re: RFR(S): 8189368: Add information on current bias holder for BiasedLockRevocation event

Looks good. Erik Hi all, Please review the following changes which add a new field to the BiasedLockRevocation event, previousOwner, containing information on which thread (if any) owned the bias before it was revoked. Issue: https://bugs.openjdk.java.net/browse/JDK-8189368 Webrev: http://c

RFR (XS): 8179083: Uninitialized notifier in Java Monitor Wait tracing event

Hi, Could I have fix of this small change. Webrev: http://cr.openjdk.java.net/~egahlin/8179083/ Bug: https://bugs.openjdk.java.net/browse/JDK-8179083 Thanks Erik

Re: Question about DiagnosticCommand.jfrCheck

Hi Martin, There will be a JEP outlining how things will work in OpenJDK. When it comes to Oracle JDK, it is too early to say and should not be discussed on this mailing list, but feel free to mail me when there is a JEP. Cheers! Erik Hi I have a question about plans for com.sun.manageme

Re: RFR: JDK-8187498: Add a -Xmanagement flag as syntactic sugar for -Dcom.sun.management.jmxremote.* properties

Hi Harsha, Very nice to see progress on this! Before reviewing, the minimal command line to start up the default management server now becomes -Xmanagement:ssl=false,authenticate=false and if you use a property that doesn't exist, or that is mandatory, you will get an error message stating

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi Robin, I can sponsor this. I wonder if we should change the name of the event to "Shutdown" instead? It will give us flexibility to add other shutdown related fields in the future. Could you change the label and field to "Status Code" and statusCode. Event fields should have headline-st

Re: RFR : JDK-8196744 : JMX: Not enough JDP packets received before timeout

Looks OK. Erik Hi All, Please find the fix below for the Jdp test-case. issue: https://bugs.openjdk.java.net/browse/JDK-8196028 webrev : http://cr.openjdk.java.net/~hb/8196028/webrev.00/ Fix details : The test was receiving JDP packets from other VM and hence the multi-cast socket was not t

Re: jcmd - executing multiple commands at the same safepoint?

Not sure if this will have an impact, but we have plans to add parameterization to JFR.start. It will work like the recording wizard in JMC. All the the widgets you see in the dialog will be available from command line. For instance, you will be able to do something like this (syntax and namin

Re: RFR(XS): 8066814: Reduce accessibility in TraceEvent

Looks good Erik Markus Grönlund skrev 2014-12-17 15:45: Greetings, Kindly asking for reviews for the following changeset: Bug: https://bugs.openjdk.java.net/browse/JDK-8066814 Webrev: http://cr.openjdk.java.net/~mgronlun/8066814/webrev01/ Description: TraceEvent currently ex

Re: RFR(L): 8071908, 8071909: Port internal Diagnostic Command tests and test framework to jtreg (plus some testlibrary changes)

Looks good! Erik Mikael Auno skrev 2015-01-30 10:44: Hi, could I please some reviews for this test port? Issues: https://bugs.openjdk.java.net/browse/JDK-8071908 https://bugs.openjdk.java.net/browse/JDK-8071909 Webrev: http://cr.openjdk.java.net/~miauno/8071908_8071909/webrev.00/ Rea

Re: RFR: JDK-8075056 Remove Version.java.template from jconsole

Looks good, jconsole now compile in Eclipse! Erik Staffan Larsen skrev 2015-03-12 13:54: The build for jconsole currently takes a template file and inserts the version number of the build into the file. We can simplify this by removing the template file and reading the java.runtime.version sys

Re: RFR(XXS): 8064923: [TESTBUG] jps doesn't display anything on embedded platforms and it causes some tests to fail

Looks good. Erik Yekaterina Kantserova skrev den 18/03/15 17:37: Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8064923 webrev: http://cr.openjdk.java.net/~ykantser/8064923/webrev.00/ Thanks, Katja

Re: RFR 8054890: Serviceability: New diagnostic commands 'VM.set_flag' and 'JVMTI.data_dump'

Looks good! Erik Jaroslav Bachorik skrev 2015-03-19 10:59: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8054890 Webrev: http://cr.openjdk.java.net/~jbachorik/8054890/webrev.00 This patch is about adding 2 new diagnostic commands - VM.set_flag and JVMTI

Re: RFR(S): JDK-8074146 jdb has succeded to read an unreadable file

Looks good Erik Dmitry Samersoff skrev 2015-04-16 17:59: Everybody, Please review: http://cr.openjdk.java.net/~dsamersoff/JDK-8074146/webrev.01/ With current testing infrastructure it's hard to make file unreadable on all platforms. From the other side codepath triggered by file open er

Re: RFR(XXS): 8130057: serviceability/sa/TestStackTrace.java should be quarantined

Looks good Erik Yekaterina Kantserova skrev den 14/07/15 11:44: Hi, Could I please have a review of this very small fix. bug: https://bugs.openjdk.java.net/browse/JDK-8130057 webrev: http://cr.openjdk.java.net/~ykantser/8130057/webrev.00/ Thanks, Katja

Re: RFR 8134641: serviceability/dcmd/compiler/CodelistTest.java fails on sun.misc.Unsafe.getUnsafe

Looks good, not a (R)eviewer. Erik Den 09/09/15 kl. 12:54, skrev Alexander Kulyakhtin: Hi, Could someone, please, review the small, test-only fix in the mail below? Best regards, Alexander - Original Message - From: alexander.kulyakh...@oracle.com To: serviceability-dev@openjdk.java.

Re: RFR(XS): 8066814: Reduce accessibility in TraceEvent

Looks good, not a reviewer. Erik On 2014-12-17 15:45, Markus Grönlund wrote: Greetings, Kindly asking for reviews for the following changeset: Bug: https://bugs.openjdk.java.net/browse/JDK-8066814 Webrev: http://cr.openjdk.java.net/~mgronlun/8066814/webrev01/

Re: RFR(XS): 8143235: Remove libjfr mapfile

Looks good, not a reviewer. Erik On 2015-11-18 21:09, Markus Gronlund wrote: Greetings, Kindly asking for reviews for the following: Bug: https://bugs.openjdk.java.net/browse/JDK-8143235 Summary: Remove libjfr mapfile (cleanup) + adds “jdk.management.jfr” to boot modules Patch is attac

Re: 8143226 (M): Minor updates to Event Based tracing

Looks good, not a reviewer. Erik On 2015-11-18 14:30, Markus Gronlund wrote: Greetings, Kindly asking for reviews for the following bug: https://bugs.openjdk.java.net/browse/JDK-8143226 Webrev: http://cr.openjdk.java.net/~mgronlun/8143226/webrev01/

Re: RFR: JDK-8145788: JVM crashes with -XX:+EnableTracing

Sorry for the delay, we are looking into it. Erik On 2016-01-06 07:36, David Holmes wrote: > Pinging the serviceability tracing experts please! > > David > > On 24/12/2015 12:25 AM, Yasumasa Suenaga wrote: >> Hi David, >> 1. Initialize JavaThread before calling apply_ergo() in create_vm

Re: RFR(xs): 8147442: Event-based tracing to allow for tracing Klass creation

Looks good! Erik On 2016-01-15 10:52, Markus Gronlund wrote: Greetings, Please review this small change in order to allow for the Event-based tracing framework to trace the creation of Klass’es. Bug: https://bugs.openjdk.java.net/browse/JDK-8147442 Webrev: http://cr.openjdk.java.net/~mg

Re: RFR(XXS): 8151053: com/sun/jdi/StepTest.java fails in 2016-03-01 JDK9-hs-rt nightly

Looks good. Not a reviewer. Erik On 2016-03-02 20:49, Markus Gronlund wrote: Greetings, Could a please ask for reviews for the following simple fix to resolve a test issue associated with com/sun/jdi/StepTest.java Bug: https://bugs.openjdk.java.net/browse/JDK-8151053 Comment: Need to fil

RFR(XS) serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java failing because expects HPROF JAVA PROFILE 1.0.1 file format

Hi, Could I have a review of a fix for "8150986: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java failing because expects HPROF JAVA PROFILE 1.0.1 file format" https://bugs.openjdk.java.net/browse/JDK-8150986 It's a test update to accommodate the removal of 1.0.1 HPROF file format su

Re: RFR(XS) serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java failing because expects HPROF JAVA PROFILE 1.0.1 file format

ssage- From: Erik Gahlin Sent: den 2 mars 2016 23:08 To: serviceability-dev@openjdk.java.net Subject: RFR(XS) serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java failing because expects HPROF JAVA PROFILE 1.0.1 file format Hi, Could I have a review of a fix for "8150986: service

Re: RFR(XXS): 8151100: Test java/lang/instrument/NativeMethodPrefixAgent.java can't attempt to do CheckIntrinsics

Looks good! Erik Den 03/03/16 kl. 01:15, skrev Markus Gronlund: Greetings, Could a please ask for reviews for the following simple fix to resolve a test issue associated with test/java/lang/instrument/NativeMethodPrefixAgent.java Bug: https://bugs.openjdk.java.net/browse/JDK-8151100 Webr

Re: RFR(XS): 8152119: Event-based tracing to allow for tracing Klass definition

Looks good. Not a reviewer. Erik On 2016-03-17 19:43, Markus Gronlund wrote: Greetings, Kindly asking for reviews for the following change to allow for tracing Klass definitions. Bug: https://bugs.openjdk.java.net/browse/JDK-8152119 Webrev: http://cr.openjdk.java.net/~mgronlun/8152119/web

Re: RFR: 8149790: NegativeArraySizeException with hprof

Looks good, not a Reviewer. Do you really need curly braces in the switch clauses? Erik On 2016-04-15 16:40, Andreas Eriksson wrote: Hi, Please review this test fix for 8149790: NegativeArraySizeException with hprof https://bugs.openjdk.java.net/browse/JDK-8149790 http://cr.openjdk.java.ne

RFR (XS): 8154794,,Add support for experimental fields/events to event-based tracing

Hi, Could I have a review of this small fix that adds support for experimental events and experimental fields for event based tracing. Bug: https://bugs.openjdk.java.net/browse/JDK-8154794 Webrev: http://cr.openjdk.java.net/~egahlin/8154794/ Thanks Erik

Re: RFR: 8149790: NegativeArraySizeException with hprof

On 2016-04-21 15:47, Andreas Eriksson wrote: Hi, On 2016-04-15 20:21, Erik Gahlin wrote: Looks good, not a Reviewer. Thanks. Do you really need curly braces in the switch clauses? In JavaValueArray.java they were needed before my change but not after. Do you want me to remove them? In

Re: RFR(XS): 8158033: notify_tracing() misplaced for intended purpose

Looks good! Not a (R)eviewer Erik On 2016-05-27 11:33, Markus Gronlund wrote: Greetings, Please review this small fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8158033 Webrev: http://cr.openjdk.java.net/~mgronlun/8158033/webrev/

Re: RFR(XXS): 8162945: HotspotDiagnosticMXBean getFlags erroneously reports OutOfMemory

Looks ok (not a reviewer) Erik On 2016-08-02 14:58, Markus Gronlund wrote: Greetings, Please review this small fix to address some new issues seen in testing where OOM is erroneously being reported: Bug: https://bugs.openjdk.java.net/browse/JDK-8162945 Changeset: # HG changeset patch #

8164523: Clean up metadata for event based tracing

Hi, Could I have review of this fix to the event tracing metadata. The patch touches many files, but it doesn't change the control flow, only class and field names. Webrev: http://cr.openjdk.java.net/~egahlin/8164523/ Bug: https://bugs.openjdk.java.net/browse/JDK-8164523 Thanks Erik

Re: RFR: JDK-8165493: SA: Add method in GrowableArray.java to be able to access the 'data' field

Could you change to: return dataField.getValue(getAddress()); Otherwise it looks good. No need to upload new webrev. Not a (R)eviewer. Thanks Erik On 2016-09-08 23:40, Poonam Bajaj Parhar wrote: Hello, Please review this small change that adds an accessor method to GrowableArray class for i

Re: RFR: JDK-8166202: Tracefile gensrc cannot handle closed src dir in different location

Looks good. Erik The xml/xsl source files used to generate sources for trace in hotspot have hard coded relative paths in them that make assumptions on where the oracle closed files are located. The source files should not make these kind of assumptions since that makes it difficult to change

Re: [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

Looks good. Erik On Sep 30, 2016, at 8:45 AM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. This is request to deprecate the obsolete flags inside InputEvent. This constants were marked as obsolete in jdk1.4 and were replaced by the new one. In jdk1.4 the documentation wer

Re: RFR(S): 8170672: Event-based tracing to support classloader instances

Looks good. Erik Greetings, Kindly asking for reviews for the following changeset: Bug/Enh: https://bugs.openjdk.java.net/browse/JDK-8170672 Webrev: http://cr.openjdk.java.net/~mgronlun/8170672/webrev01/ (this work is covered by a

Re: RFR : JDK-8174196 : sun/management/jdp tests are not running properly

Looks good. Erik Hello, Please review following test case fix Bug ID : https://bugs.openjdk.java.net/browse/JDK-8174196 Webrev : http://cr.openjdk.java.net/~asapre/webrev/2017/JDK-8174196/webrev.00/ Thanks, Amit

Re: RFR : JDK-7132577 - javax/management/monitor/MultiMonitorTest.java fails in JDK8-B22

Looks good. Erik Hello, Please review this test bug fix which eliminates test case’s own timeout mechanism to default jtreg timeout. Bug ID : https://bugs.openjdk.java.net/browse/JDK-7132577 Webrev : http://cr.openjdk.java.net/~asapre/webrev/2017/JDK-7132577/webrev.00/

Re: RFR - [RFE] JDK-8007141 : Introduce Dynamic MBean exposing the perf counters

Hi Harsha, How will perf counters be supported? Can they be removed at anytime, or only at major releases etc. Do we have tests for them? I think it would be good know, and perhaps state somewhere so we don't break people's code. Erik Hi All, Please review the below RFE, JDK-8007141

Re: RFR - [RFE] JDK-8007141 : Introduce Dynamic MBean exposing the perf counters

Harsha On Monday 27 February 2017 07:39 PM, Erik Gahlin wrote: Hi Harsha, How will perf counters be supported? Can they be removed at anytime, or only at major releases etc. Do we have tests for them? I think it would be good know, and perhaps state somewhere so we don't break people's c

Re: RFR: 7172176 java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing

ityHashMap, since same message can be (and is) used by several keys - removed test from problem list Thanks Erik Erik Gahlin skrev 2012-06-08 21:59: Mandy Chung skrev 2012-06-08 21:23: Erik, Tested in JPRT with "-testset core -onlytests '.*jdk_tools2.*'" on all platforms,

Re: RFR: 6815130 intermittent ThreadMXBean/Locks.java failure

Looks good, but I think it's better for tests to spin forever if they can't reach a state and let the test harness deal with it, but I'm fine with it, since it was that way before. Erik Jaroslav Bachorik skrev 2013-09-03 13:15: Please, review the following patch of the intermittently failin

Re: RFR: 6696975: JTop plugin fails if connected readonly to target JVM

Thanks for the review Erik Mandy Chung skrev 2013-09-27 21:10: On 9/27/13 11:58 AM, Michel Trudeau wrote: Here is the latest change: http://cr.openjdk.java.net/~egahlin/6696975_2/ The change looks okay to me. This will rely on your manual testing to verify the fix :) Mandy

Re: RFR 7144200: java/lang/management/ClassLoadingMXBean/LoadCounts.java failed with JFR enabled

I don't think the test should run with JFR enabled. I would ask SQE not to run unit tests with JFR and only add /othervm. Erik Jaroslav Bachorik skrev 10/7/13 3:59 PM: The test captures the number of loaded classes right at the start and then checks the diffs when it's finished. However, it se

RFR: 7105883: JDWP: agent crash if there exists a ThreadGroup with null name

Hi, Could I please have a review of this fix. An empty string is returned if the thread name is null. The protocol should be updated to support INVALID_STRING for the Thread Reference Command <#Error_INVALID_STRING>, but that is a larger effort and probably better to do when fixing other prot

hg: jdk8/tl/jdk: 7105883: JDWP: agent crash if there exists a ThreadGroup with null name

Changeset: c077a2810782 Author:egahlin Date: 2013-10-23 10:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c077a2810782 7105883: JDWP: agent crash if there exists a ThreadGroup with null name Reviewed-by: sla, jbachorik ! src/share/back/ThreadGroupReferenceImpl.c + test/co

Re: RFR(S): 7145419 com/sun/jdi/JdbMethodExitTest.sh fails when a background thread is generating events.

Looks good, if we can assume main thread has id = 1 (main thread must use first j.l.Thread object that is created) /Erik Staffan Larsen skrev 2013-10-29 15:41: This test fails if there are background threads that run while the test is running. I've modified the test to use the "trace" comman

Re: RFR 8027358: sun/management/jmxremote/bootstrap/LocalManagementTest.java failing since JDK-8004926

Looks good. /Erik Jaroslav Bachorik skrev 2013-10-29 18:28: Please, review this test fix. In agentvm mode the test can not rely on the co-location of the test class and the auxiliary classes the test class wants to start. It is necessary to explicitly provide the test class path when startin

RFR: 8027209: javax/management/monitor/ThreadPoolAccTest.java fails intermittently

Could I have a review of this intermittently failing test. Instead of doing Thread.sleep(2000) and assume principal is visible/set the test now spins until principal is available. I also cleaned up code to avoid warnings. Thanks Erik Webrev: http://cr.openjdk.java.net/~egahlin/8027209_2/ Bu

RFR: 6849945: VM Periodic Task Thread CPU time = -1ns in HotspotThreadMBean.getInternalThreadCpuTimes

Could I have a review of this intermittently failing test. There is a race between a thread being created and the request to get its CPU time. The "/proc/..." structure might not be ready at that time and the routine will return -1. Fix is to spin in test until we get a CPU time that is not -

Re: RFR: 8027209: javax/management/monitor/ThreadPoolAccTest.java fails intermittently

/othervm ThreadPoolAccTest 53 */ The original one does not use "other" in @run. Thanks, Katja On 10/30/2013 03:13 PM, Erik Gahlin wrote: Could I have a review of this intermittently failing test. Instead of doing Thread.sleep(2000) and assume principal is visible/set the test now s

RFR: 6959636: testcase failing on windows javax/management/loading/LibraryLoader/LibraryLoaderTest.java,

Could I please have a review, fix is to run test in separate vm. I also removed warnings and allowed the exception to propagate. Thanks Erik Webrev: http://cr.openjdk.java.net/~egahlin/6959636_1/ Bug: https://bugs.openjdk.java.net/browse/JDK-6959636

RFR: 8027209: javax/management/monitor/ThreadPoolAccTest.java fails intermittently

Could I have a review of this intermittently failing test. Instead of doing Thread.sleep(2000) and assume principal is visible/set the test now spins until principal is available. I also cleaned up code to avoid warnings. Thanks Erik Webrev: http://cr.openjdk.java.net/~egahlin/8027209_3/ Bu

RFR: 6543856: MonitorVmStartTerminate.sh fails intermittently

Could I please have a review of this intermittently failing test. Removed Thread.sleep and instead used two count down latches. Also did some cleaning up; removed an unused import, added generics etc. Thanks Erik Webrev: http://cr.openjdk.java.net/~egahlin/6543856_1/ Bug: https://bugs.openjd

hg: jdk8/tl/jdk: 8027209: javax/management/monitor/ThreadPoolAccTest.java fails intermittently

Changeset: 41dcb0c2e194 Author:egahlin Date: 2013-11-12 14:52 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41dcb0c2e194 8027209: javax/management/monitor/ThreadPoolAccTest.java fails intermittently Reviewed-by: sla, jbachorik ! test/javax/management/monitor/ThreadPoolAccTe

hg: jdk8/tl/jdk: 6543856: MonitorVmStartTerminate.sh fails intermittently

Changeset: 4cff9f59644f Author:egahlin Date: 2013-11-12 17:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4cff9f59644f 6543856: MonitorVmStartTerminate.sh fails intermittently Reviewed-by: sla, dholmes ! test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java !

hg: jdk8/tl/jdk: 6849945: VM Periodic Task Thread CPU time = -1ns in HotspotThreadMBean.getInternalThreadCpuTimes()

Changeset: d9f827e4d20c Author:egahlin Date: 2013-11-12 18:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d9f827e4d20c 6849945: VM Periodic Task Thread CPU time = -1ns in HotspotThreadMBean.getInternalThreadCpuTimes() Reviewed-by: sla ! test/sun/management/HotspotThreadM

RFR(S): 6954510: TEST_BUG: Testcase failure com/sun/jdi/BreakpointWithFullGC.sh

Could I please have a review of a regression test that fails intermittently because a full GC is not always triggered. Fix is to call System.gc() Webrev: http://cr.openjdk.java.net/~egahlin/6954510_1 Bug: https://bugs.openjdk.java.net/browse/JDK-6954510 Thanks Erik

Re: 8028239: test/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh with NoClassDefFoundError

My fault, thanks for fixing. Looks good. Erik Alan Bateman skrev 2013-11-12 22:35: This test was liberated earlier today via JDK- 6543856 [1]. Unfortunately it is failing again, this time with a NoClassDefFoundError because it can't locate the JavaProcess class. The issue can be quickly fix

hg: jdk8/tl/jdk: 6959636: testcase failing on windows javax/management/loading/LibraryLoader/LibraryLoaderTest.java

Changeset: ddaa9a8acaed Author:egahlin Date: 2013-11-13 15:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ddaa9a8acaed 6959636: testcase failing on windows javax/management/loading/LibraryLoader/LibraryLoaderTest.java Reviewed-by: sla, jbachorik ! test/ProblemList.txt !

hg: jdk8/tl/jdk: 6954510: TEST_BUG: Testcase failure com/sun/jdi/BreakpointWithFullGC.sh

Changeset: 256b3395346b Author:egahlin Date: 2013-11-13 18:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/256b3395346b 6954510: TEST_BUG: Testcase failure com/sun/jdi/BreakpointWithFullGC.sh Reviewed-by: sla, sspitsyn ! test/com/sun/jdi/BreakpointWithFullGC.sh

RFR: 7141544: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails

Could I have a review of a test that fails intermittently with an OOM. The fix is to reduce the amount allocated objects. Bug: https://bugs.openjdk.java.net/browse/JDK-7141544 Webrev: http://cr.openjdk.java.net/~egahlin/7141544_1/ Erik

RFR: 8028505: Put sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh on ProblemList.txt

Could I please have a review. Thanks Erik Bug: https://bugs.openjdk.java.net/browse/JDK-8028505 Webrev: http://cr.openjdk.java.net/~egahlin/8028505/

Re: RFR: 8028505: Put sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh on ProblemList.txt

Thanks for explaining. Here is an updated webrev http://cr.openjdk.java.net/~egahlin/8028505_2/ Erik Alan Bateman skrev 2013-11-18 13:54: On 18/11/2013 12:53, Erik Gahlin wrote: Could I please have a review. Thanks Erik Bug: https://bugs.openjdk.java.net/browse/JDK-8028505 Webrev: http

Re: RFR 8028433: [TESTBUG] add -XX:+UsePerfData to some sun.management tests

Looks good. Erik Jaroslav Bachorik skrev 2013-11-18 15:57: Please, review this simple test change. Issue : https://bugs.openjdk.java.net/browse/JDK-8028433 Webrev: http://cr.openjdk.java.net/~jbachorik/8028433/webrev.00 The tests relying on the availability of the perf counters need to add -

RFR: 6402201: ProcessAttachTest.sh needs better synchronization

Could I have a review of this test fix. It appears it takes more than 10 s to write to a file on slow machines. Instead of sleeping 10 s the test now polls for the file to appear. There may be other issues with the test, but it's hard to know without ruling this race out. Thanks Erik Testin

hg: jdk8/tl/jdk: 8028505: Put sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh on ProblemList.txt

Changeset: d6195774dd1f Author:egahlin Date: 2013-11-19 11:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d6195774dd1f 8028505: Put sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh on ProblemList.txt Reviewed-by: alanb ! test/ProblemList.txt

Re: RFR: 6402201: ProcessAttachTest.sh needs better synchronization

Thanks for your feedback Here is an updated webrev where the file is renamed. http://cr.openjdk.java.net/~egahlin/6402201_2/ Erik Alan Bateman skrev 2013-11-19 09:45: On 18/11/2013 23:29, Erik Gahlin wrote: Could I have a review of this test fix. It appears it takes more than 10 s to write

hg: jdk8/tl/jdk: 7141544: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails

Changeset: 894a4bae9e33 Author:egahlin Date: 2013-11-20 12:32 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/894a4bae9e33 7141544: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails Reviewed-by: sla ! test/com/sun/jdi/BreakpointWithFullGC.sh

Re: RFR: 6402201: ProcessAttachTest.sh needs better synchronization

Thanks, didn't know about ATOMIC_MOVE. it will be useful for other tests as well. http://cr.openjdk.java.net/~egahlin/6402201_3/ Erik Alan Bateman skrev 2013-11-20 12:43: On 20/11/2013 11:25, Erik Gahlin wrote: Thanks for your feedback Here is an updated webrev where the file is re

hg: jdk8/tl/jdk: 6402201: ProcessAttachTest.sh needs better synchronization

Changeset: 91ec3bc92793 Author:egahlin Date: 2013-11-21 13:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/91ec3bc92793 6402201: ProcessAttachTest.sh needs better synchronization Reviewed-by: alanb ! test/ProblemList.txt ! test/com/sun/jdi/ProcessAttachDebuggee.java ! test

Re: RFR(XS): 8030184 Remove unneeded "content_type" declarations from tracetypes.xml

Looks good, not a Reviewer. Erik Staffan Larsen skrev 2013-12-16 13:38: tracetypes.xml has declarations of a couple of content_types that are never used. bug: https://bugs.openjdk.java.net/browse/JDK-8030184 webrev: http://cr.openjdk.java.net/~sla/8030184/webrev.00/ Thanks, /Staffan

Re: RFR(S): JDK-8032250 : Add trace event for VM flag changes

Looks good. Erik Staffan Larsen skrev 2014-01-22 16:02: Erik discovered that I used traced events with signed values for some unsigned flag types. So, new revision: http://cr.openjdk.java.net/~sla/8032250/webrev.02/ Thanks, /Staffan On 22 jan 2014, at 15:08, Staffan Larsen wrote: Erik He

Re: RFR(S): JDK-8032250 : Add trace event for VM flag changes

128 > 129 Field identifiers should use Java naming convention, oldValue and newValue. Erik Staffan Larsen skrev 2014-01-21 14:47: This is a patch to capture a trace event whenever a manageable VM flag is changed in runtime. webrev: http://cr.openjdk.java.net/~sla/8032250/webrev.00/ bug: h

Re: RFR 8034168: ThreadMXBean/Locks.java failed, blocked on wrong object

Looks good. /Erik Jaroslav Bachorik skrev 2/18/14 5:22 PM: Please, review the following test change. Issue : https://bugs.openjdk.java.net/browse/JDK-8034168 Webrev: http://cr.openjdk.java.net/~jbachorik/8034168/webrev.00 The test fails because of falsely evaluating the thread being parked a

Re: RFR: 6815126 intermittent SimulResumerTest.java failure

I also like to understand better. I looked at this failure before and I couldn't see what was wrong, not in the test or product. Erik Jaroslav Bachorik skrev 3/27/14 4:49 PM: On 27.3.2014 15:49, shanliang wrote: Hi, The call thr.frames(0, frames.size() - 1); suffers a synchronization i

Re: RFR(S): 8043520: Serviceability tests using @library failing with java.lang.NoClassDefFoundError

Looks good! Erik Yekaterina Kantserova skrev 2014-05-20 15:48: Thanks Staffan! New webrev can be found here: http://cr.openjdk.java.net/~ykantser/8043520/webrev.01/ // Katja On 05/20/2014 03:07 PM, Staffan Larsen wrote: test/sun/management/jmxremote/bootstrap/PasswordFilePermissionTest.

RFR(M): 8028474: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh timeout, leaves looping process behind

Hi, Could I have a review of a test that has been failing intermittently. The test now uses files for synchronization instead of waiting for a process that sleeps. Webrev: http://cr.openjdk.java.net/~egahlin/8028474/ Bug: https://bugs.openjdk.java.net/browse/JDK-8028474 Description: The test

  1   2   3   >