Re: Review Request: 8238358: Implementation of JEP 371: Hidden Classes

2020-03-27 Thread forax
> De: "mandy chung" > À: "Remi Forax" > Cc: "valhalla-dev" , "core-libs-dev" > , "serviceability-dev" > , "hotspot-dev" > > Envoyé: Vendredi 27 Mars 2020 16:50:55 > Objet: Re: Review Request: 8238358: Imple

Re: RFR: 8200559: Java agents doing instrumentation need a means to define auxilary classes

2021-04-16 Thread forax
> De: "Rafael Winterhalter" > À: "Remi Forax" > Cc: "Rafael Winterhalter" , "core-libs-dev" > , "serviceability-dev" > > Envoyé: Vendredi 16 Avril 2021 18:27:46 > Objet: Re: RFR: 8200559: Java agents doing instrumentation

Re: RFR: 8200559: Java agents doing instrumentation need a means to define auxilary classes

2021-04-16 Thread forax
> De: "Rafael Winterhalter" > À: "Remi Forax" > Cc: "Rafael Winterhalter" , "core-libs-dev" > , "serviceability-dev" > > Envoyé: Vendredi 16 Avril 2021 18:41:26 > Objet: Re: RFR: 8200559: Java agents doing instrumentati

Re: RFR: 8229516: Thread.isInterrupted() always returns false after thread termination

2019-10-29 Thread Remi Forax
Hi David, in java.lang.Thread interrupt0 should be renamed to setInterruptEvent, because what it does now and I don't really understand the comment in interrupted(), if a thread is interrupted by two other threads calling interrupt(), you will loose an interrupt anyway. Rémi - Mail origina

Re: Review Request: 8238358: Implementation of JEP 371: Hidden Classes

2020-03-27 Thread Remi Forax
Hi Mandy, in ReflectionFactory, why in the case of a constructor the check to the anonymous class is removed ? in BytecodeGenerator, the comment "// bootstrapping issue if using condy" can be promoted on top of clinit, because i ask myself the same question seeing a static block was generated i

Re: Review Request: 8238358: Implementation of JEP 371: Hidden Classes

2020-03-27 Thread Remi Forax
- Mail original - > De: "David Holmes" > À: "mandy chung" , "Vicente Romero" > , "jan lahoda" > > Cc: "serviceability-dev" , "hotspot-dev" > , > "core-libs-dev" , "valhalla-dev" > > Envoyé: Samedi 28 Mars 2020 00:01:58 > Objet: Re: Review Request: 8238358: Implementation of JEP 371: H

Re: RFR: JDK-8225056 VM support for sealed classes

2020-05-19 Thread Remi Forax
- Mail original - > De: "David Holmes" > À: "Harold David Seigel" , "hotspot-runtime-dev" > , > "amber-dev" , "core-libs-dev" > , "serviceability-dev" > > Envoyé: Mardi 19 Mai 2020 07:26:38 > Objet: Re: RFR: JDK-8225056 VM support for sealed classes > Hi Harold, > > Adding servicea

Re: PRE-RFR: 8177154: Default configuration should disallow loading agents

2017-03-24 Thread Remi Forax
Please, can we have a discussion on the merit of not of allowing loadAgent by default before discussing about how to implement that. There is only one interesting method in VirtualMachine, loadAgent, and if this method do not work by default, there is no point to have the whole API. If you have

Re: JDK-8041679 Replace uses of StringBuffer with StringBuilder within the JDK

2014-05-12 Thread Remi Forax
On 05/12/2014 12:42 PM, Alan Bateman wrote: On 12/05/2014 11:03, Paul Sandoz wrote: It covers many areas and i have grouped the patches into such areas to aid reviewing. When commenting please including core-libs. The groupings are a bit odd but I looked through the -core, -io, -management a

Re: RFR: 8200559: Java agents doing instrumentation need a means to define auxilary classes

2021-04-16 Thread Remi Forax
- Mail original - > De: "Rafael Winterhalter" > À: "core-libs-dev" , "serviceability-dev" > > Envoyé: Vendredi 16 Avril 2021 15:52:07 > Objet: RFR: 8200559: Java agents doing instrumentation need a means to define > auxilary classes > To allow agents the definition of auxiliary classes

Re: RFR: 8272992: Replace usages of Collections.sort with List.sort call in jdk.* modules

2021-09-13 Thread Rémi Forax
On Mon, 23 Aug 2021 21:08:05 GMT, Andrey Turbanov wrote: > Collections.sort is just a wrapper, so it is better to use an instance method > directly. src/jdk.jfr/share/classes/jdk/jfr/internal/MetadataReader.java line 86: > 84: if (Logger.shouldLog(LogTag.JFR_SYSTEM_PARSER, LogLevel.TR

Re: Proposal of a new version of AsyncGetCallTrace

2022-03-18 Thread Remi Forax
Knowing if there is a C stackframe in the middle of the stack while blocking on a synchronized is an important feature for a profiler when loom will land. Rémi - Original Message - > From: "Bechberger, Johannes" > To: "hotspot-dev" , > hotspot-jfr-...@openjdk.java.net, "serviceability-