So overall it looks good to me and should be pushed to the staging forest
once you hear from others that commented previously.
I think that means Chris Hegarty, Michael McMahon, and Sergey Bylokhov. Alan,
please correct me if I'm wrong.
Thanks,
iris
-Original Message-
From: Alan
On 26 Nov 2013, at 18:08, Iris Clark wrote:
So overall it looks good to me and should be pushed to the staging forest
once you hear from others that commented previously.
I think that means Chris Hegarty, Michael McMahon, and Sergey Bylokhov.
Alan, please correct me if I'm wrong.
I'm
Hi Phil,
thanks a lot for the review. Please find my comments inline:
On Tue, Nov 26, 2013 at 12:24 AM, Phil Race philip.r...@oracle.com wrote:
Hi,
I see you've already received a ton of good feedback on this v2.
I have just a few things to add.
I don't know what symlinks might exist on
Hi,
thanks to everybody for the prompt and helpful reviews. Here comes the
final webrev which incorporates all the corrections and suggestions from
the second review round:
http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/
I've successfully build (and run some smoke tests) with these
On 26/11/2013 16:23, Volker Simonis wrote:
Hi,
thanks to everybody for the prompt and helpful reviews. Here comes the
final webrev which incorporates all the corrections and suggestions from
the second review round:
http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/
I've successfully
Hi.
http://cr.openjdk.java.net/~simonis/webrevs/8024854.v3/
+ src/solaris/classes/java/lang/UNIXProcess.java.aix
2 * Copyright (c) 1995, 2013, Oracle and/or its affiliates. All rights
reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
Oracle copyright in
Looking only at what you needed to change this time round, all seems
fine now.
-phil.
On 11/26/13 8:23 AM, Volker Simonis wrote:
Hi,
thanks to everybody for the prompt and helpful reviews. Here comes the
final webrev which incorporates all the corrections and suggestions
from the second
Hi, Volker,
just a few very minor comments about the client changes:
1. mlib_sys.c: the change is fine, but it makes the following comment
obsolete.
2. XRBackendNative.c: the same comment here.
3. Awt2dLibraries.gmk: $(JDK_TOPDIR)/src/aix/porting/porting_aix.c would
be better than just
Hi Volker,
The security changes look fine. I'm not crazy that we now have to
maintain one additional java.security file which is the exact same as
java.security-linux, but this is really an existing issue with
duplicated content across the java.security files which I will try to
fix early in
Hi Artem,
thanks a lot for your review. Please find my comments inline:
On Monday, November 25, 2013, Artem Ananiev wrote:
Hi, Volker,
just a few very minor comments about the client changes:
1. mlib_sys.c: the change is fine, but it makes the following comment
obsolete.
You're right.
Hi Sean,
thanks a lot for you review.
Please let me know once you start working on 6997010 so I can update the
corresponding AIX file accordingly.
Regards,
Volker
On Monday, November 25, 2013, Sean Mullan wrote:
Hi Volker,
The security changes look fine. I'm not crazy that we now have to
Hi,
I see you've already received a ton of good feedback on this v2.
I have just a few things to add.
I don't know what symlinks might exist on AIX but it seems odd to
me that you have :-
138 static char *fullAixFontPath[] = {
139 /usr/lpp/X11/lib/X11/fonts/Type1,
..
but the paths in the
We've synced our staging repository yesterday with the latest jdk8-b117 and
I noticed that change 8025985: com.sun.management.OSMBeanFactory should
not be public moved the file src/solaris/native/com/sun/
management/UnixOperatingSystem_md.c to
On 21/11/2013 15:54, Volker Simonis wrote:
:
But actually I've just realized that it is not need at all, because
'aix_close.c' isn't in the PATH for any other OS than AIX (that could
be probably called a feature of the new file layout:) So I'll simply
change it to:
48 ifeq
Hi Alan,
so I'll rename 'initLocalAddrTable()' into 'platformInit()' and move
the call to 'aix_close_init' to a AIX-specific version of
'platformInit()' in net_util_md.c as discussed.
I'll post a final webrev once I got the comments from the AWT/2D guys.
As far as I understood, you've now
On 20/11/2013 18:26, Volker Simonis wrote:
Hi,
this is the second review round for 8024854: Basic changes and files
to build the class library on AIX
https://bugs.openjdk.java.net/browse/JDK-8024854. The previous
reviews can be found at the end of this mail in the references section.
I've
Hi Alan,
thanks a lot for the fast review and your valuable comments. Please find my
answers inline:
On Thu, Nov 21, 2013 at 1:01 PM, Alan Bateman alan.bate...@oracle.comwrote:
On 20/11/2013 18:26, Volker Simonis wrote:
Hi,
this is the second review round for 8024854: Basic changes and
Hi,
this is the second review round for 8024854: Basic changes and files to
build the class library on
AIXhttps://bugs.openjdk.java.net/browse/JDK-8024854.
The previous reviews can be found at the end of this mail in the references
section.
I've tried to address all the comments and suggestions
18 matches
Mail list logo
