Re: RFR(xxs): 8206243: java -XshowSettings fails if memory.limit_in_bytes overflows LONG.max

2018-07-03 Thread Thomas Stüfe
Thank you Bob! On Tue, Jul 3, 2018 at 2:59 PM, Bob Vandette wrote: > Looks ok. > > Bob. > >> On Jul 3, 2018, at 5:15 AM, Thomas Stüfe wrote: >> >> Thank you David! >> >> I changed the webrev in place. >> >> Thanks, Thomas >> >> On Tue, Jul 3, 2018 at 10:37 AM, David Holmes >> wrote: >>> Hi

Re: RFR(xxs): 8206243: java -XshowSettings fails if memory.limit_in_bytes overflows LONG.max

2018-07-03 Thread Bob Vandette
Looks ok. Bob. > On Jul 3, 2018, at 5:15 AM, Thomas Stüfe wrote: > > Thank you David! > > I changed the webrev in place. > > Thanks, Thomas > > On Tue, Jul 3, 2018 at 10:37 AM, David Holmes wrote: >> Hi Thomas, >> >> This seems okay. >> >> Minor nit: >> >> if(bigInt >> >> Please add a

Re: RFR(xxs): 8206243: java -XshowSettings fails if memory.limit_in_bytes overflows LONG.max

2018-07-03 Thread Thomas Stüfe
Thank you David! I changed the webrev in place. Thanks, Thomas On Tue, Jul 3, 2018 at 10:37 AM, David Holmes wrote: > Hi Thomas, > > This seems okay. > > Minor nit: > > if(bigInt > > Please add a space after 'if' > > Thanks, > David > > > On 3/07/2018 6:20 PM, Thomas Stüfe wrote: >> >> Hi all,

Re: RFR(xxs): 8206243: java -XshowSettings fails if memory.limit_in_bytes overflows LONG.max

2018-07-03 Thread David Holmes
Hi Thomas, This seems okay. Minor nit: if(bigInt Please add a space after 'if' Thanks, David On 3/07/2018 6:20 PM, Thomas Stüfe wrote: Hi all, may I please have reviews for this small fix. https://bugs.openjdk.java.net/browse/JDK-8206243

RFR(xxs): 8206243: java -XshowSettings fails if memory.limit_in_bytes overflows LONG.max

2018-07-03 Thread Thomas Stüfe
Hi all, may I please have reviews for this small fix. https://bugs.openjdk.java.net/browse/JDK-8206243 http://cr.openjdk.java.net/~stuefe/webrevs/8206243-java-xshowsettings-fails-for-large-values-of-memory-limit_in_bytes/webrev.00/webrev/ On some Linux kernels, the unlimited value of