Re: RFR: 8241585: Remove unused _recursion_counter facility from PerfTraceTime

2020-03-27 Thread Claes Redestad
On 2020-03-27 03:18, David Holmes wrote: Yeah they confuse me. Which makes it hard to see what impact your changes may have. This patch removes some internal, unused code on the JVM end that is not observable via jstat / jvmstat. I'm happy if serviceability can weigh in though. The other

Re: RFR: 8241585: Remove unused _recursion_counter facility from PerfTraceTime

2020-03-26 Thread David Holmes
Hi Claes, On 27/03/2020 10:11 am, Claes Redestad wrote: On 2020-03-27 00:36, David Holmes wrote: Okay so can you change the bug synopsis and description to cover this more general cleanup and tuneup please. I filed an addendum RFE and will add this RFE bug id to the single changeset

Re: RFR: 8241585: Remove unused _recursion_counter facility from PerfTraceTime

2020-03-26 Thread Claes Redestad
On 2020-03-27 00:36, David Holmes wrote: Okay so can you change the bug synopsis and description to cover this more general cleanup and tuneup please. I filed an addendum RFE and will add this RFE bug id to the single changeset push: https://bugs.openjdk.java.net/browse/JDK-8241705

Re: RFR: 8241585: Remove unused _recursion_counter facility from PerfTraceTime

2020-03-26 Thread David Holmes
On 27/03/2020 9:46 am, Chris Plummer wrote: On 3/26/20 4:36 PM, David Holmes wrote: Hi Claes, Adding serviceability as they are the consumers of this IIUC. On 27/03/2020 3:40 am, Claes Redestad wrote: Hi, PerfTraceTime::_recursion_counter is unused, and removing it gets rid of some branchy

Re: RFR: 8241585: Remove unused _recursion_counter facility from PerfTraceTime

2020-03-26 Thread Chris Plummer
On 3/26/20 4:36 PM, David Holmes wrote: Hi Claes, Adding serviceability as they are the consumers of this IIUC. On 27/03/2020 3:40 am, Claes Redestad wrote: Hi, PerfTraceTime::_recursion_counter is unused, and removing it gets rid of some branchy (but well-predicted) code in paths that is

Re: RFR: 8241585: Remove unused _recursion_counter facility from PerfTraceTime

2020-03-26 Thread David Holmes
Hi Claes, Adding serviceability as they are the consumers of this IIUC. On 27/03/2020 3:40 am, Claes Redestad wrote: Hi, PerfTraceTime::_recursion_counter is unused, and removing it gets rid of some branchy (but well-predicted) code in paths that is somewhat startup sensitive. Okay.