Re: RFR: 8255455: Pre-generate ThreadHeapSampler::_log_table [v7]

2020-10-30 Thread Claes Redestad
On Fri, 30 Oct 2020 17:39:05 GMT, Ioi Lam wrote: >> Claes Redestad has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 11 additional >> commits

Re: RFR: 8255455: Pre-generate ThreadHeapSampler::_log_table [v7]

2020-10-30 Thread Ioi Lam
On Fri, 30 Oct 2020 15:24:17 GMT, Claes Redestad wrote: >> The static `ThreadHeapSampler::_log_table` is currently initialized on JVM >> bootstrap to an overhead of ~67k instructions (linux-x64). By turning the >> initialization into a constexpr, we can precalculate the helper table at >>

Re: RFR: 8255455: Pre-generate ThreadHeapSampler::_log_table [v7]

2020-10-30 Thread Claes Redestad
> The static `ThreadHeapSampler::_log_table` is currently initialized on JVM > bootstrap to an overhead of ~67k instructions (linux-x64). By turning the > initialization into a constexpr, we can precalculate the helper table at > compile time, which trades a runtime overhead for a small, 8kb,