Re: RFR (S): 8012086: The object count event should only send events for instances occupying more than 0.5% of the heap

2013-05-08 Thread Bengt Rutisson
Erik, Looks good! Bengt On 5/7/13 9:28 PM, Erik Helin wrote: Jesper, I've changed the flag to be an experimental flag instead of a product flag. Please see new webrev at: http://cr.openjdk.java.net/~ehelin/8012086/webrev.02/ Thanks, Erik On 05/07/2013 03:54 PM, Jesper Wilhelmsson

Re: RFR (S): 8012086: The object count event should only send events for instances occupying more than 0.5% of the heap

2013-05-08 Thread Jesper Wilhelmsson
Erik Helin skrev 8/5/13 10:00 AM: Jesper, On 05/07/2013 09:52 PM, Jesper Wilhelmsson wrote: Erik Helin skrev 7/5/13 9:28 PM: Jesper, I've changed the flag to be an experimental flag instead of a product flag. Thanks! Please see new webrev at:

Re: RFR (S): 8012086: The object count event should only send events for instances occupying more than 0.5% of the heap

2013-05-08 Thread Erik Helin
Jesper, On 05/08/2013 10:20 AM, Jesper Wilhelmsson wrote: Erik Helin skrev 8/5/13 10:00 AM: Jesper, On 05/07/2013 09:52 PM, Jesper Wilhelmsson wrote: Erik Helin skrev 7/5/13 9:28 PM: Jesper, I've changed the flag to be an experimental flag instead of a product flag. Thanks! Please see

Re: RFR (S): 8012086: The object count event should only send events for instances occupying more than 0.5% of the heap

2013-05-08 Thread Jesper Wilhelmsson
Erik Helin skrev 8/5/13 1:00 PM: Jesper, On 05/08/2013 10:20 AM, Jesper Wilhelmsson wrote: Erik Helin skrev 8/5/13 10:00 AM: Jesper, On 05/07/2013 09:52 PM, Jesper Wilhelmsson wrote: Erik Helin skrev 7/5/13 9:28 PM: Jesper, I've changed the flag to be an experimental flag instead of a

Re: RFR (S): 8012086: The object count event should only send events for instances occupying more than 0.5% of the heap

2013-05-08 Thread Erik Helin
Thanks! Erik On 05/08/2013 01:29 PM, Jesper Wilhelmsson wrote: Erik Helin skrev 8/5/13 1:00 PM: Jesper, On 05/08/2013 10:20 AM, Jesper Wilhelmsson wrote: Erik Helin skrev 8/5/13 10:00 AM: Jesper, On 05/07/2013 09:52 PM, Jesper Wilhelmsson wrote: Erik Helin skrev 7/5/13 9:28 PM: Jesper,

Re: RFR (S): 8012086: The object count event should only send events for instances occupying more than 0.5% of the heap

2013-05-07 Thread Jesper Wilhelmsson
Hi, Please check with the serviceability team (CC:ed) before adding a flag to control the threshold. I suspect that they would prefer some tracing specific way to configure these thresholds. /Jesper Erik Helin skrev 7/5/13 2:58 PM: Hi Bengt, thanks for the review! On 05/07/2013 11:42 AM,

Re: RFR (S): 8012086: The object count event should only send events for instances occupying more than 0.5% of the heap

2013-05-07 Thread Erik Helin
Jesper, I've changed the flag to be an experimental flag instead of a product flag. Please see new webrev at: http://cr.openjdk.java.net/~ehelin/8012086/webrev.02/ Thanks, Erik On 05/07/2013 03:54 PM, Jesper Wilhelmsson wrote: Hi, Please check with the serviceability team (CC:ed) before

Re: RFR (S): 8012086: The object count event should only send events for instances occupying more than 0.5% of the heap

2013-05-07 Thread Jesper Wilhelmsson
Erik Helin skrev 7/5/13 9:28 PM: Jesper, I've changed the flag to be an experimental flag instead of a product flag. Thanks! Please see new webrev at: http://cr.openjdk.java.net/~ehelin/8012086/webrev.02/ If you want to change the description of the flag to say ... to generate a trace