Re: RFR 10 (L): 8183012: Code cleanup in com.sun.tools.jdi

Hi Christoph, On Wed, Jun 28, 2017 at 4:47 PM, Langer, Christoph wrote: > Hi Thomas, > > thanks for your review! > > > com/sun/tools/jdi/InvokableTypeImpl.java: > > > > import com.sun.jdi.VMCannotBeModifiedException; ?Why do we need to > > import this type, we do

RE: RFR 10 (L): 8183012: Code cleanup in com.sun.tools.jdi

Hi Thomas, thanks for your review! > com/sun/tools/jdi/InvokableTypeImpl.java: > > import com.sun.jdi.VMCannotBeModifiedException; ?Why do we need to > import this type, we do not seem to use it? This is needed for the documentation, see line 97, the throws documentation. >

Re: RFR 10 (L): 8183012: Code cleanup in com.sun.tools.jdi

Hi Christoph, Thanks for the cleanup! Here some minor remarks (like Serguei, I did not check the expanded imports). --- com/sun/tools/jdi/InvokableTypeImpl.java: import com.sun.jdi.VMCannotBeModifiedException; ?Why do we need to import this type, we do not seem to use it? ---

Re: RFR 10 (L): 8183012: Code cleanup in com.sun.tools.jdi

va.net Subject: Re: RFR 10 (L): 8183012: Code cleanup in com.sun.tools.jdi   Hi Christoph, It looks good to me. I do not have time to check the i

RE: RFR 10 (L): 8183012: Code cleanup in com.sun.tools.jdi

: Mittwoch, 28. Juni 2017 10:04 To: Langer, Christoph <christoph.lan...@sap.com>; serviceability-dev@openjdk.java.net Subject: Re: RFR 10 (L): 8183012: Code cleanup in com.sun.tools.jdi Hi Christoph, It looks good to me. I do not have time to check the imports and their sorting. Thanks

RFR 10 (L): 8183012: Code cleanup in com.sun.tools.jdi

Hi, I've got another contribution for cleaning up the jdk.jdi classes. This time it's about package com.sun.tools.jdi. Bug: https://bugs.openjdk.java.net/browse/JDK-8183012 Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8183012.0/ What I've done: I've largely cleaned up the import