On Tue, 29 Aug 2023 13:46:08 GMT, Matthias Baesken wrote:
> The sun/tools/jhsdb tests have issues when we run them concurrently .
> So add a related config to TEST.root.
This pull request has now been integrated.
Changeset: 1e7e2bcf
Author:Matthias Baesken
URL:
https://git.openjdk.o
On Tue, 29 Aug 2023 13:46:08 GMT, Matthias Baesken wrote:
> The sun/tools/jhsdb tests have issues when we run them concurrently .
> So add a related config to TEST.root.
Hi Alan and Chris , thanks for the reviews !
-
PR Comment: https://git.openjdk.org/jdk/pull/15469#issuecomment-1
On Tue, 29 Aug 2023 23:37:06 GMT, Jiangli Zhou wrote:
> Please review this simple change from @cjmoon1 for resolving static linking
> issue caused by multiple definition of 'normalize'. @cjmoon1's branch can be
> found at:
> https://github.com/openjdk/jdk/compare/master...cjmoon1:jdk:fix_norma
Please review this simple change from @cjmoon1 for resolving static linking
issue caused by multiple definition of 'normalize'. @cjmoon1's branch can be
found at:
https://github.com/openjdk/jdk/compare/master...cjmoon1:jdk:fix_normalize.
The change incorporated suggestions from both @sspitsyn a
On Mon, 21 Aug 2023 21:47:14 GMT, Chris Plummer wrote:
> During [JDK-8151815](https://bugs.openjdk.org/browse/JDK-8151815) it was
> noted that the PerfMemory _initialized and _destroyed fields should be
> volatile, but VMStructs didn't have the needed support for doing that, so it
> was left a
On Wed, 23 Aug 2023 18:26:03 GMT, Chris Plummer wrote:
>> During [JDK-8151815](https://bugs.openjdk.org/browse/JDK-8151815) it was
>> noted that the PerfMemory _initialized and _destroyed fields should be
>> volatile, but VMStructs didn't have the needed support for doing that, so it
>> was le
> Arguments were added to the launcher arguments.
Leonid Mesnik has updated the pull request incrementally with one additional
commit since the last revision:
fixed copyright
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15454/files
- new: https://git.openjdk.org/jdk/pul
On Tue, 29 Aug 2023 09:12:51 GMT, Leo Korinth wrote:
>> Rename createJavaProcessBuilder so that it is not used by mistake instead of
>> createTestJvm.
>>
>> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed
>> -i -e
>> "s/createJavaProcessBuilder(/createJavaProcessBu
On Tue, 29 Aug 2023 13:46:08 GMT, Matthias Baesken wrote:
> The sun/tools/jhsdb tests have issues when we run them concurrently .
> So add a related config to TEST.root.
Marked as reviewed by cjplummer (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/15469#pullrequestrevie
On Tue, 29 Aug 2023 14:06:01 GMT, Roger Riggs wrote:
>> Leo Korinth has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> copyright
>
> I don't think this is the best change across so many files.
> It gives a very ugly name to a common test fu
On Tue, 29 Aug 2023 13:46:08 GMT, Matthias Baesken wrote:
> The sun/tools/jhsdb tests have issues when we run them concurrently .
> So add a related config to TEST.root.
This looks okay to me
-
Marked as reviewed by alanb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/154
On Tue, 29 Aug 2023 14:06:01 GMT, Roger Riggs wrote:
>> Leo Korinth has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> copyright
>
> I don't think this is the best change across so many files.
> It gives a very ugly name to a common test fu
On Tue, 29 Aug 2023 09:12:51 GMT, Leo Korinth wrote:
>> Rename createJavaProcessBuilder so that it is not used by mistake instead of
>> createTestJvm.
>>
>> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed
>> -i -e
>> "s/createJavaProcessBuilder(/createJavaProcessBu
This update fixes two important issues:
- Issue reported by a bug submitter about missing JVMTI events on virtual
threads after an a JVMTI agent dynamic attach
- Known scalability/performance issue: a need to lazily create
`JvmtiThreadState's` for virtual threads
The issue is tricky to fix be
On Mon, 28 Aug 2023 19:12:04 GMT, Leonid Mesnik wrote:
> Arguments were added to the launcher arguments.
looks good
-
Marked as reviewed by kevinw (Committer).
PR Review: https://git.openjdk.org/jdk/pull/15454#pullrequestreview-1599925725
On Mon, 28 Aug 2023 11:03:51 GMT, Afshin Zafari wrote:
>> The `find` method now is
>> ```C++
>> template
>> int find(T* token, bool f(T*, E)) const {
>> ...
>>
>> Any other functions which use this are also changed.
>> Local linux-x64-debug hotspot:tier1 passed. Mach5 tier1 build on linux and
> Rename createJavaProcessBuilder so that it is not used by mistake instead of
> createTestJvm.
>
> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed
> -i -e
> "s/createJavaProcessBuilder(/createJavaProcessBuilderIgnoreTestJavaOpts(/g"`
>
> Then I have manually modifi
On Thu, 24 Aug 2023 11:34:13 GMT, Kevin Walls wrote:
> Several tests from test/jdk/sun/tools/jstatd are intermittent.
>
> Port clashes when run at the same time on the same machine have been a
> problem.
> The RMI error "no such object in table" can mean a reference on the RMI
> server has bee
On Thu, 24 Aug 2023 21:38:41 GMT, Kevin Walls wrote:
>> Several tests from test/jdk/sun/tools/jstatd are intermittent.
>>
>> Port clashes when run at the same time on the same machine have been a
>> problem.
>> The RMI error "no such object in table" can mean a reference on the RMI
>> server h
On Thu, 24 Aug 2023 21:38:41 GMT, Kevin Walls wrote:
>> Several tests from test/jdk/sun/tools/jstatd are intermittent.
>>
>> Port clashes when run at the same time on the same machine have been a
>> problem.
>> The RMI error "no such object in table" can mean a reference on the RMI
>> server h
On Sun, 27 Aug 2023 17:03:00 GMT, Kim Barrett wrote:
>> Not a review, just agreeing with @stefank and @jdksjolen . What they
>> describe is idiomatic C++.
>
> Also, why isn't this change also being applied to `find_from_end`
There can be a confusion related to selection of type names T and E:
21 matches
Mail list logo
