Re: Seemingly erroneous return value in HotSpot test

2023-09-13 Thread David Holmes
Hi Julian, This is a serviceability issue - cc'd. On 14/09/2023 12:48 pm, Julian Waters wrote: Hi all, In the HotSpot test /test/hotspot/jtreg/vmTestbase/nsk/jvmti/IterateThroughHeap/filter-tagged/HeapFilter.cpp, the method occurance_expected, which returns a jboolean, returns JNI_ERR in an e

Re: RFR: JDK-8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX [v2]

2023-09-13 Thread David Holmes
On Wed, 13 Sep 2023 15:30:22 GMT, Joachim Kern wrote: >> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) , >> the following test started to fail on AIX : >> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java; >> The problem was described in >> [JDK-8309549](https

Re: RFR: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests

2023-09-13 Thread David Holmes
On Tue, 12 Sep 2023 19:20:16 GMT, Aleksey Shipilev wrote: > and consume the usual amount of memory. And how much is that? And at what concurrency level will we not be able to run these tests in parallel without potentially impacting the way they run i.e. running out of memory sooner than expe

Integrated: 8316228: jcmd tests are broken by 8314828

2023-09-13 Thread Leonid Mesnik
On Wed, 13 Sep 2023 23:57:43 GMT, Leonid Mesnik wrote: > The fix 8314828 removed dependency to /vmTestbase and tests started failing. > Verified by running tests and submitting tier1. This pull request has now been integrated. Changeset: 11d431b2 Author:Leonid Mesnik URL: https://gi

Re: RFR: 8316228: jcmd tests are broken by 8314828

2023-09-13 Thread David Holmes
On Wed, 13 Sep 2023 23:57:43 GMT, Leonid Mesnik wrote: > The fix 8314828 removed dependency to /vmTestbase and tests started failing. > Verified by running tests and submitting tier1. Looks good. Thanks - Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org

RFR: 8316228: jcmd tests are broken by 8314828

2023-09-13 Thread Leonid Mesnik
The fix 8314828 removed dependency to /vmTestbase and tests started failing. Verified by running tests and submitting tier1. - Commit messages: - 8316228: jcmd tests are broken by 8314828 Changes: https://git.openjdk.org/jdk/pull/15731/files Webrev: https://webrevs.openjdk.org/?rep

Integrated: 8314828: Mark 3 jcmd command-line options test as vm.flagless

2023-09-13 Thread Leonid Mesnik
On Wed, 23 Aug 2023 22:58:05 GMT, Leonid Mesnik wrote: > Mark 3 tests as flagless to don't run them if not needed. Also, small clean > up. This pull request has now been integrated. Changeset: 23fab118 Author:Leonid Mesnik URL: https://git.openjdk.org/jdk/commit/23fab1181b6a053efc4

Re: RFR: 8314828: Mark 3 jcmd command-line options test as vm.flagless

2023-09-13 Thread Chris Plummer
On Wed, 23 Aug 2023 22:58:05 GMT, Leonid Mesnik wrote: > Mark 3 tests as flagless to don't run them if not needed. Also, small clean > up. Marked as reviewed by cjplummer (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15407#pullrequestreview-1625546191

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v13]

2023-09-13 Thread Jonathan Joo
> 8315149: Add hsperf counters for CPU time of internal GC threads Jonathan Joo has updated the pull request incrementally with one additional commit since the last revision: Update total gc cpu implementation (still not finished) - Changes: - all: https://git.openjdk.org/jdk/p

Re: RFR: 8316199: Remove sun/tools/jstatd/TestJstatd* tests from problemlist for Windows.

2023-09-13 Thread Chris Plummer
On Wed, 13 Sep 2023 14:34:42 GMT, Kevin Walls wrote: > Original failure in 8081569 is a long time ago, and not reproducing. > Other failures recorded there may be different problems, some of them are > port related which are helped by other changes since these tests were > problemlisted. > > T

Re: RFR: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests

2023-09-13 Thread Chris Plummer
On Tue, 12 Sep 2023 19:20:16 GMT, Aleksey Shipilev wrote: > Similar to [JDK-8315437](https://bugs.openjdk.org/browse/JDK-8315437), > current vmTestbase/nsk/monitoring/stress/lowmem tests contains 36 tests, each > running exclusively. This drags the tier4 test times up. There seem to be no > re

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2023-09-13 Thread Justin Lu
On Wed, 13 Sep 2023 18:12:15 GMT, Naoto Sato wrote: > Looks good to me, although I did not look at each l10n file, but sampled > some. Thanks for tackling this conversion. Thanks for the review; (In addition to testing), I ran a script to verify only white space escape sequences exist in JDK .

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2023-09-13 Thread Naoto Sato
On Wed, 13 Sep 2023 17:38:28 GMT, Justin Lu wrote: >> JDK .properties files still use ISO-8859-1 encoding with escape sequences. >> It would improve readability to see the native characters instead of escape >> sequences (especially for the L10n process). The majority of files changed >> are l

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v12]

2023-09-13 Thread Jonathan Joo
> 8315149: Add hsperf counters for CPU time of internal GC threads Jonathan Joo has updated the pull request incrementally with one additional commit since the last revision: Partial commit attempting to add total cpu tracker - Changes: - all: https://git.openjdk.org/jdk/pull/1

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2023-09-13 Thread Justin Lu
> JDK .properties files still use ISO-8859-1 encoding with escape sequences. It > would improve readability to see the native characters instead of escape > sequences (especially for the L10n process). The majority of files changed > are localized resource files. > > This change converts the Un

Re: RFR: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests

2023-09-13 Thread Aleksey Shipilev
On Tue, 12 Sep 2023 19:20:16 GMT, Aleksey Shipilev wrote: > Similar to [JDK-8315437](https://bugs.openjdk.org/browse/JDK-8315437), > current vmTestbase/nsk/monitoring/stress/lowmem tests contains 36 tests, each > running exclusively. This drags the tier4 test times up. There seem to be no > re

Re: RFR: 8301639: JDI and JDWP specs should clarify potential deadlock issues with method invocation

2023-09-13 Thread Chris Plummer
On Wed, 13 Sep 2023 13:01:32 GMT, Alan Bateman wrote: >> Of course as soon as I posted that I now realize the issue. There are more >> things that could "deadlock" virtual threads when all other threads are >> suspended - such as calling sleep, because it requires a "system" thread to >> be ac

Re: RFR: 8301639: JDI and JDWP specs should clarify potential deadlock issues with method invocation

2023-09-13 Thread Chris Plummer
On Wed, 13 Sep 2023 12:47:48 GMT, Alan Bateman wrote: >> This PR includes a couple of clarifications of the JDWP and JDI invoke >> method support. The first is that deadlocks can occur due to a needed >> "resource" being held. The spec previously just mentioned monitors being >> held, but this

Re: RFR: 8316199: Remove sun/tools/jstatd/TestJstatd* tests from problemlist for Windows.

2023-09-13 Thread Leonid Mesnik
On Wed, 13 Sep 2023 14:34:42 GMT, Kevin Walls wrote: > Original failure in 8081569 is a long time ago, and not reproducing. > Other failures recorded there may be different problems, some of them are > port related which are helped by other changes since these tests were > problemlisted. > > T

Re: RFR: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests

2023-09-13 Thread Leonid Mesnik
On Tue, 12 Sep 2023 19:20:16 GMT, Aleksey Shipilev wrote: > Similar to [JDK-8315437](https://bugs.openjdk.org/browse/JDK-8315437), > current vmTestbase/nsk/monitoring/stress/lowmem tests contains 36 tests, each > running exclusively. This drags the tier4 test times up. There seem to be no > re

Re: RFR: JDK-8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX [v2]

2023-09-13 Thread Joachim Kern
On Wed, 13 Sep 2023 15:30:22 GMT, Joachim Kern wrote: >> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) , >> the following test started to fail on AIX : >> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java; >> The problem was described in >> [JDK-8309549](https

Re: RFR: JDK-8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX [v2]

2023-09-13 Thread Joachim Kern
> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) , > the following test started to fail on AIX : > com/sun/tools/attach/warnings/DynamicLoadWarningTest.java; > The problem was described in > [JDK-8309549](https://bugs.openjdk.org/browse/JDK-8309549) with a first try > o

Re: RFR: JDK-8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX [v2]

2023-09-13 Thread Joachim Kern
On Tue, 12 Sep 2023 04:59:13 GMT, David Holmes wrote: >> Joachim Kern has updated the pull request incrementally with one additional >> commit since the last revision: >> >> try to improve code following Davids suggestions and do some cosmetic >> changes > > src/hotspot/share/prims/jvmtiAgen

RFR: 8316199: Remove sun/tools/jstatd/TestJstatd* tests from problemlist for Windows.

2023-09-13 Thread Kevin Walls
Original failure in 8081569 is a long time ago, and not reproducing. Other failures recorded there may be different problems, some of them are port related which are helped by other changes since these tests were problemlisted. This problemlist entry should be removed. - Commit mess

Re: RFR: 8301639: JDI and JDWP specs should clarify potential deadlock issues with method invocation

2023-09-13 Thread Alan Bateman
On Wed, 13 Sep 2023 01:07:58 GMT, David Holmes wrote: >> src/java.se/share/data/jdwp/jdwp.spec line 1178: >> >>> 1176: "support the timer mechanism for virtual threads, and thus >>> methods such as " >>> 1177: ">> href=../../api/java.base/java/lang/Thread.html#sleep(long)>Thread

Re: RFR: 8301639: JDI and JDWP specs should clarify potential deadlock issues with method invocation

2023-09-13 Thread Alan Bateman
On Tue, 12 Sep 2023 22:24:18 GMT, Chris Plummer wrote: > This PR includes a couple of clarifications of the JDWP and JDI invoke method > support. The first is that deadlocks can occur due to a needed "resource" > being held. The spec previously just mentioned monitors being held, but this > is

RFR: 8316182: RISC-V: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved

2023-09-13 Thread Feilong Jiang
Hi, please consider. Inspired by [JDK-8313800](https://bugs.openjdk.org/browse/JDK-8313800). RISC-V also treats x8/fp as a callee-saved scratch register for some time, and it is freely used by C2-generated code. Therefore, any code in SA that uses getFP() in a compiled frame is very likely to co

Re: RFR: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests

2023-09-13 Thread Aleksey Shipilev
On Wed, 13 Sep 2023 06:07:06 GMT, Leonid Mesnik wrote: > I start testing of fix in CI and approve once it is completed. Thank you! - PR Comment: https://git.openjdk.org/jdk/pull/15689#issuecomment-1717099563