Re: RFR: 8312498: Thread::getState and JVM TI GetThreadState should return TIMED_WAITING virtual thread is timed parked [v3]

2023-09-14 Thread Alan Bateman
On Fri, 15 Sep 2023 00:36:10 GMT, David Holmes wrote: > What is TIMED PINNING? LockSupport.parkNanos when the carrier can't be released due to monitor or native frame. - PR Review Comment: https://git.openjdk.org/jdk/pull/14978#discussion_r1326860516

Re: RFR: JDK-8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX [v4]

2023-09-14 Thread Joachim Kern
On Fri, 15 Sep 2023 02:01:26 GMT, David Holmes wrote: >> Joachim Kern has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'origin/JDK-8315706' into JDK-8315706 >> - Following the proposals > > src/hotspot/shar

Re: RFR: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests

2023-09-14 Thread Aleksey Shipilev
On Thu, 14 Sep 2023 08:00:56 GMT, Aleksey Shipilev wrote: >>> and consume the usual amount of memory. >> >> And how much is that? And at what concurrency level will we not be able to >> run these tests in parallel without potentially impacting the way they run >> i.e. running out of memory so

Re: Seemingly erroneous return value in HotSpot test

2023-09-14 Thread David Holmes
On 15/09/2023 12:02 pm, Julian Waters wrote: Just a heads up, there are even more instances of a method supposed to return a jboolean returning JNI_ERR instead in other places as well, which seems to be fairly concerning: It is only error paths that should never really happen. But yes a bug.

Re: Seemingly erroneous return value in HotSpot test

2023-09-14 Thread Julian Waters
Just a heads up, there are even more instances of a method supposed to return a jboolean returning JNI_ERR instead in other places as well, which seems to be fairly concerning: === Output from failing command(s) repeated here === * For target support_test_hotspot_jtreg_native_support_libhs103t002_

Re: RFR: JDK-8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX [v4]

2023-09-14 Thread David Holmes
On Thu, 14 Sep 2023 12:32:18 GMT, Joachim Kern wrote: >> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) , >> the following test started to fail on AIX : >> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java; >> The problem was described in >> [JDK-8309549](https

Re: RFR: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests

2023-09-14 Thread David Holmes
On Thu, 14 Sep 2023 08:00:56 GMT, Aleksey Shipilev wrote: >>> and consume the usual amount of memory. >> >> And how much is that? And at what concurrency level will we not be able to >> run these tests in parallel without potentially impacting the way they run >> i.e. running out of memory so

Re: RFR: 8316148: Remove sun/tools/jhsdb/JStackStressTest.java from problem list

2023-09-14 Thread David Holmes
On Tue, 12 Sep 2023 23:31:31 GMT, Chris Plummer wrote: > [JDK-8276210](https://bugs.openjdk.org/browse/JDK-8276210) no longer seems to > be reproducing, even before > [JDK-8313800](https://bugs.openjdk.org/browse/JDK-8313800) was just pushed. > I'm not sure what may have fixed it, but even if

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v18]

2023-09-14 Thread David Holmes
On Thu, 14 Sep 2023 23:29:15 GMT, Jonathan Joo wrote: >> 8315149: Add hsperf counters for CPU time of internal GC threads > > Jonathan Joo has updated the pull request incrementally with one additional > commit since the last revision: > > Clean up test and improve total counter name Changes

Re: RFR: 8312498: Thread::getState and JVM TI GetThreadState should return TIMED_WAITING virtual thread is timed parked [v3]

2023-09-14 Thread David Holmes
On Thu, 14 Sep 2023 13:29:48 GMT, Alan Bateman wrote: >> Yes but TIMED and SUSPENDED are not alike. I assume SUSPENDED is a >> stand-alone bit because you can be in various states and suspended at the >> same time. But TIMED isn't like that. > >> Yes but TIMED and SUSPENDED are not alike. I ass

Re: RFR: 8301639: JDI and JDWP specs should clarify potential deadlock issues with method invocation [v2]

2023-09-14 Thread David Holmes
On Thu, 14 Sep 2023 19:08:14 GMT, Chris Plummer wrote: >> This PR includes a couple of clarifications of the JDWP and JDI invoke >> method support. The first is that deadlocks can occur due to a needed >> "resource" being held. The spec previously just mentioned monitors being >> held, but thi

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v18]

2023-09-14 Thread Jonathan Joo
> 8315149: Add hsperf counters for CPU time of internal GC threads Jonathan Joo has updated the pull request incrementally with one additional commit since the last revision: Clean up test and improve total counter name - Changes: - all: https://git.openjdk.org/jdk/pull/15082/f

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v17]

2023-09-14 Thread Jonathan Joo
> 8315149: Add hsperf counters for CPU time of internal GC threads Jonathan Joo has updated the pull request incrementally with one additional commit since the last revision: Add unit test to check existence of GC CPU counters - Changes: - all: https://git.openjdk.org/jdk/pull/

Integrated: 8301991: Convert l10n properties resource bundles to UTF-8 native

2023-09-14 Thread Justin Lu
On Tue, 12 Sep 2023 21:57:31 GMT, Justin Lu wrote: > JDK .properties files still use ISO-8859-1 encoding with escape sequences. It > would improve readability to see the native characters instead of escape > sequences (especially for the L10n process). The majority of files changed > are local

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v16]

2023-09-14 Thread Jonathan Joo
> 8315149: Add hsperf counters for CPU time of internal GC threads Jonathan Joo has updated the pull request incrementally with one additional commit since the last revision: Fix segfaults on build - Changes: - all: https://git.openjdk.org/jdk/pull/15082/files - new: https://

Re: Seemingly erroneous return value in HotSpot test

2023-09-14 Thread Chris Plummer
I think it should return false like is does with verify_tag(). This will cause the test to fail, which it what we would want in this case Chris On 9/13/23 11:20 PM, David Holmes wrote: Hi Julian, This is a serviceability issue - cc'd. On 14/09/2023 12:48 pm, Julian Waters wrote: Hi all, In

Re: RFR: 8301639: JDI and JDWP specs should clarify potential deadlock issues with method invocation [v2]

2023-09-14 Thread Chris Plummer
> This PR includes a couple of clarifications of the JDWP and JDI invoke method > support. The first is that deadlocks can occur due to a needed "resource" > being held. The spec previously just mentioned monitors being held, but this > is too specific. The second is to clarify that an invoke on

Re: RFR: 8301639: JDI and JDWP specs should clarify potential deadlock issues with method invocation

2023-09-14 Thread Chris Plummer
On Tue, 12 Sep 2023 22:24:18 GMT, Chris Plummer wrote: > This PR includes a couple of clarifications of the JDWP and JDI invoke method > support. The first is that deadlocks can occur due to a needed "resource" > being held. The spec previously just mentioned monitors being held, but this > is

Re: RFR: JDK-8315486: vmTestbase/nsk/jdwp/ThreadReference/ForceEarlyReturn/forceEarlyReturn002/forceEarlyReturn002.java timed out [v2]

2023-09-14 Thread Alex Menkov
On Thu, 7 Sep 2023 01:25:19 GMT, Alex Menkov wrote: >> To test ForceEarlyReturn command for NO_MORE_FRAMES case the test creates >> ThreadStartEventRequest with SUSPEND_ALL policy and requests debuggee to >> start new thread. >> If debuggee JVM starts some internal threads before the request is

Integrated: 8316147: Remove serviceability/sa/TestJhsdbJstackMixed.java from -Xcomp problem list

2023-09-14 Thread Chris Plummer
On Tue, 12 Sep 2023 23:23:39 GMT, Chris Plummer wrote: > [JDK-8248675](https://bugs.openjdk.org/browse/JDK-8248675) no longer seems to > be reproducing, even before > [JDK-8313800](https://bugs.openjdk.org/browse/JDK-8313800) was just pushed. > I'm not sure what may have fixed it, but even if

Re: RFR: 8316147: Remove serviceability/sa/TestJhsdbJstackMixed.java from -Xcomp problem list

2023-09-14 Thread Leonid Mesnik
On Tue, 12 Sep 2023 23:23:39 GMT, Chris Plummer wrote: > [JDK-8248675](https://bugs.openjdk.org/browse/JDK-8248675) no longer seems to > be reproducing, even before > [JDK-8313800](https://bugs.openjdk.org/browse/JDK-8313800) was just pushed. > I'm not sure what may have fixed it, but even if

Re: RFR: 8316147: Remove serviceability/sa/TestJhsdbJstackMixed.java from -Xcomp problem list

2023-09-14 Thread Chris Plummer
On Wed, 13 Sep 2023 03:16:03 GMT, Leonid Mesnik wrote: > Fine with fix, assuming you verified that test doesn't fail with Xcomp on > linux-aarch64. Yes, I tested with 100s of runs on linux-aarch64 with -Xcomp. Can I push this as a trivial change? - PR Comment: https://git.openjdk

Re: RFR: 8316148: Remove sun/tools/jhsdb/JStackStressTest.java from problem list

2023-09-14 Thread Chris Plummer
On Tue, 12 Sep 2023 23:31:31 GMT, Chris Plummer wrote: > [JDK-8276210](https://bugs.openjdk.org/browse/JDK-8276210) no longer seems to > be reproducing, even before > [JDK-8313800](https://bugs.openjdk.org/browse/JDK-8313800) was just pushed. > I'm not sure what may have fixed it, but even if

Re: RFR: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests

2023-09-14 Thread Daniel D . Daugherty
On Thu, 14 Sep 2023 05:44:51 GMT, David Holmes wrote: >> Similar to [JDK-8315437](https://bugs.openjdk.org/browse/JDK-8315437), >> current vmTestbase/nsk/monitoring/stress/lowmem tests contains 36 tests, >> each running exclusively. This drags the tier4 test times up. There seem to >> be no re

Re: RFR: 8316182: RISC-V: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved

2023-09-14 Thread Fei Yang
On Wed, 13 Sep 2023 11:53:39 GMT, Feilong Jiang wrote: > Hi, please consider. > Inspired by [JDK-8313800](https://bugs.openjdk.org/browse/JDK-8313800). > RISC-V also treats x8/fp as a callee-saved scratch register for some time, > and it is freely used by C2-generated code. Therefore, any code

Re: RFR: 8312498: Thread::getState and JVM TI GetThreadState should return TIMED_WAITING virtual thread is timed parked [v3]

2023-09-14 Thread Alan Bateman
On Wed, 26 Jul 2023 12:18:02 GMT, David Holmes wrote: > Yes but TIMED and SUSPENDED are not alike. I assume SUSPENDED is a > stand-alone bit because you can be in various states and suspended at the > same time. But TIMED isn't like that. The SUSPENDED bit can only be set when the virtual thre

Re: RFR: 8312498: Thread::getState and JVM TI GetThreadState should return TIMED_WAITING virtual thread is timed parked [v3]

2023-09-14 Thread Alan Bateman
On Thu, 27 Jul 2023 01:54:58 GMT, Serguei Spitsyn wrote: > Looks good. > Thanks, > Serguei Thanks Serguei. I had to pause this to work on other things. When I sync'ed up the branch I found I had to update recently introduced test jvmti/vthread/VThreadEventTest/VThreadEventTest.java as it was c

Re: RFR: 8312498: Thread::getState and JVM TI GetThreadState should return TIMED_WAITING virtual thread is timed parked [v3]

2023-09-14 Thread Alan Bateman
> Thread::getState is an API for monitoring and management purposes to report > the thread state. If a virtual thread is parked with LockSupport.parkNanos, > its state is reported as WAITING when it should be TIMED_WAITING. JVM TI > GetThreadState has the same issue in that it returns > JVMTI_

Re: RFR: JDK-8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX [v4]

2023-09-14 Thread Joachim Kern
On Thu, 14 Sep 2023 12:32:18 GMT, Joachim Kern wrote: >> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) , >> the following test started to fail on AIX : >> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java; >> The problem was described in >> [JDK-8309549](https

Re: RFR: JDK-8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX [v4]

2023-09-14 Thread Joachim Kern
> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) , > the following test started to fail on AIX : > com/sun/tools/attach/warnings/DynamicLoadWarningTest.java; > The problem was described in > [JDK-8309549](https://bugs.openjdk.org/browse/JDK-8309549) with a first try > o

Re: RFR: JDK-8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX [v3]

2023-09-14 Thread Christoph Langer
On Thu, 14 Sep 2023 09:20:24 GMT, Joachim Kern wrote: >> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) , >> the following test started to fail on AIX : >> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java; >> The problem was described in >> [JDK-8309549](https

Re: RFR: JDK-8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX [v3]

2023-09-14 Thread Joachim Kern
On Thu, 14 Sep 2023 09:40:54 GMT, Alan Bateman wrote: >> Joachim Kern has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commit

Re: RFR: JDK-8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX [v3]

2023-09-14 Thread Alan Bateman
On Thu, 14 Sep 2023 09:20:24 GMT, Joachim Kern wrote: >> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) , >> the following test started to fail on AIX : >> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java; >> The problem was described in >> [JDK-8309549](https

Re: RFR: JDK-8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX [v3]

2023-09-14 Thread Joachim Kern
> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) , > the following test started to fail on AIX : > com/sun/tools/attach/warnings/DynamicLoadWarningTest.java; > The problem was described in > [JDK-8309549](https://bugs.openjdk.org/browse/JDK-8309549) with a first try > o

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v15]

2023-09-14 Thread Jonathan Joo
> 8315149: Add hsperf counters for CPU time of internal GC threads Jonathan Joo has updated the pull request incrementally with one additional commit since the last revision: comment out lines that cause segfault - Changes: - all: https://git.openjdk.org/jdk/pull/15082/files

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v14]

2023-09-14 Thread Jonathan Joo
> 8315149: Add hsperf counters for CPU time of internal GC threads Jonathan Joo has updated the pull request incrementally with one additional commit since the last revision: Update to improve total time tracking - Changes: - all: https://git.openjdk.org/jdk/pull/15082/files

Re: RFR: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests

2023-09-14 Thread Aleksey Shipilev
On Thu, 14 Sep 2023 05:44:51 GMT, David Holmes wrote: > > and consume the usual amount of memory. > > And how much is that? And at what concurrency level will we not be able to > run these tests in parallel without potentially impacting the way they run > i.e. running out of memory sooner than

Re: RFR: 8301639: JDI and JDWP specs should clarify potential deadlock issues with method invocation

2023-09-14 Thread Alan Bateman
On Wed, 13 Sep 2023 16:05:51 GMT, Chris Plummer wrote: > I can change it to `@apiNote`. Since it is not really part of the spec, I can > see leaving it out of the JDWP spec. It's mostly important to get this info > to JDI users. Okay, in which case a CSR is not strictly needed here (I added th

Integrated: 8316199: Remove sun/tools/jstatd/TestJstatd* tests from problemlist for Windows.

2023-09-14 Thread Kevin Walls
On Wed, 13 Sep 2023 14:34:42 GMT, Kevin Walls wrote: > Original failure in 8081569 is a long time ago, and not reproducing. > Other failures recorded there may be different problems, some of them are > port related which are helped by other changes since these tests were > problemlisted. > > T

Re: RFR: 8316199: Remove sun/tools/jstatd/TestJstatd* tests from problemlist for Windows.

2023-09-14 Thread Kevin Walls
On Wed, 13 Sep 2023 14:34:42 GMT, Kevin Walls wrote: > Original failure in 8081569 is a long time ago, and not reproducing. > Other failures recorded there may be different problems, some of them are > port related which are helped by other changes since these tests were > problemlisted. > > T