Re: RFR: 8301639: JDI and JDWP specs should clarify potential deadlock issues with method invocation [v2]

2023-09-15 Thread Alan Bateman
On Fri, 15 Sep 2023 21:48:35 GMT, Chris Plummer wrote: > CSR has been created: > [JDK-8301639](https://bugs.openjdk.org/browse/JDK-8301639) I added the "csr" label as it was initially looking like this would involve a spec update. It's now changed to be non-normative and an API note so a CSR

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v18]

2023-09-15 Thread Jonathan Joo
On Fri, 15 Sep 2023 01:29:57 GMT, David Holmes wrote: >> Jonathan Joo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Clean up test and improve total counter name > > test/jdk/sun/tools/jcmd/TestGcCounters.java line 34: > >> 32:

Re: RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v19]

2023-09-15 Thread Jonathan Joo
> 8315149: Add hsperf counters for CPU time of internal GC threads Jonathan Joo has updated the pull request incrementally with one additional commit since the last revision: Address dholmes@ comments - Changes: - all: https://git.openjdk.org/jdk/pull/15082/files - new: https

Re: RFR: 8314829: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java ignores vm flags

2023-09-15 Thread Chris Plummer
On Fri, 15 Sep 2023 23:18:06 GMT, Leonid Mesnik wrote: > The test is updated to start the target VM with tested flags in addition to > heap size. > Tested with tier1, and iter5/6 rt/svc with CI flags. Marked as reviewed by cjplummer (Reviewer). - PR Review: https://git.openjdk.org

RFR: 8314829: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java ignores vm flags

2023-09-15 Thread Leonid Mesnik
The test is updated to start the target VM with tested flags in addition to heap size. Tested with tier1, and iter5/6 rt/svc with CI flags. - Commit messages: - 8314829 Changes: https://git.openjdk.org/jdk/pull/15771/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15771&ran

Re: RFR: 8301639: JDI and JDWP specs should clarify potential deadlock issues with method invocation [v2]

2023-09-15 Thread Chris Plummer
On Thu, 14 Sep 2023 19:08:14 GMT, Chris Plummer wrote: >> This PR includes a couple of clarifications of the JDWP and JDI invoke >> method support. The first is that deadlocks can occur due to a needed >> "resource" being held. The spec previously just mentioned monitors being >> held, but thi

Integrated: 8316148: Remove sun/tools/jhsdb/JStackStressTest.java from problem list

2023-09-15 Thread Chris Plummer
On Tue, 12 Sep 2023 23:31:31 GMT, Chris Plummer wrote: > [JDK-8276210](https://bugs.openjdk.org/browse/JDK-8276210) no longer seems to > be reproducing, even before > [JDK-8313800](https://bugs.openjdk.org/browse/JDK-8313800) was just pushed. > I'm not sure what may have fixed it, but even if

Re: RFR: 8316182: RISC-V: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved

2023-09-15 Thread Feilong Jiang
On Thu, 14 Sep 2023 14:44:09 GMT, Fei Yang wrote: >> Hi, please consider. >> Inspired by [JDK-8313800](https://bugs.openjdk.org/browse/JDK-8313800). >> RISC-V also treats x8/fp as a callee-saved scratch register for some time, >> and it is freely used by C2-generated code. Therefore, any code i

Integrated: 8316182: RISC-V: SA stack walking code having trouble finding sender frame when invoking LambdaForms is involved

2023-09-15 Thread Feilong Jiang
On Wed, 13 Sep 2023 11:53:39 GMT, Feilong Jiang wrote: > Hi, please consider. > Inspired by [JDK-8313800](https://bugs.openjdk.org/browse/JDK-8313800). > RISC-V also treats x8/fp as a callee-saved scratch register for some time, > and it is freely used by C2-generated code. Therefore, any code

RFR: 8299560: Assertion failed: currentQueryIndex >= 0 && currentQueryIndex < numberOfJavaProcessesAtInitialization

2023-09-15 Thread Kevin Walls
This assert happens rarely, but is seen in testing a few times. getCurrentQueryIndexForProcess comments that it can return -1, but it asserts that the value is >=0 If we let it return -1 for failure as its comment documents, the caller can handle the failure and not assert and end the JVM. C

Re: RFR: 8314502: Change the comparator taking version of GrowableArray::find to be a template method [v4]

2023-09-15 Thread Afshin Zafari
On Thu, 7 Sep 2023 07:06:46 GMT, Afshin Zafari wrote: >>> Also, why isn't this change also being applied to `find_from_end` >> >> Thank you @kimbarrett, the function is also changed accordingly. > >> We could just as well do a capturing lambda here, yes. Then we'd have: >> >> ```c++ >> template

Re: RFR: JDK-8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX [v5]

2023-09-15 Thread Joachim Kern
> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) , > the following test started to fail on AIX : > com/sun/tools/attach/warnings/DynamicLoadWarningTest.java; > The problem was described in > [JDK-8309549](https://bugs.openjdk.org/browse/JDK-8309549) with a first try > o