Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v5]

2023-10-16 Thread Chris Plummer
On Mon, 16 Oct 2023 21:05:58 GMT, Johannes Bechberger wrote: >> Fix `onthrow` issue by passing the event info to the `initialize` method. >> >> This prevents `jdb` from receiving a broken exception event and throwing an >> internal NullPointerException, upon attaching to the JDWP-agent. > > Jo

Re: RFR: 8318126: Refresh manpages

2023-10-16 Thread Iris Clark
On Mon, 16 Oct 2023 01:18:52 GMT, David Holmes wrote: > The open nroff manpage files are out of sync with their closed markdown > sources and need to be refreshed. > > The changes to apply are coming from: > > - [JDK-8288158](https://bugs.openjdk.org/browse/JDK-8288158): Add an anchor > to ea

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v5]

2023-10-16 Thread Chris Plummer
On Mon, 16 Oct 2023 21:05:58 GMT, Johannes Bechberger wrote: >> Fix `onthrow` issue by passing the event info to the `initialize` method. >> >> This prevents `jdb` from receiving a broken exception event and throwing an >> internal NullPointerException, upon attaching to the JDWP-agent. > > Jo

Re: RFR: 8318126: Refresh manpages

2023-10-16 Thread David Holmes
On Mon, 16 Oct 2023 06:02:02 GMT, Alan Bateman wrote: >> The open nroff manpage files are out of sync with their closed markdown >> sources and need to be refreshed. >> >> The changes to apply are coming from: >> >> - [JDK-8288158](https://bugs.openjdk.org/browse/JDK-8288158): Add an anchor >

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v5]

2023-10-16 Thread Johannes Bechberger
> Fix `onthrow` issue by passing the event info to the `initialize` method. > > This prevents `jdb` from receiving a broken exception event and throwing an > internal NullPointerException, upon attaching to the JDWP-agent. Johannes Bechberger has updated the pull request incrementally with one

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v4]

2023-10-16 Thread Chris Plummer
On Mon, 16 Oct 2023 19:07:37 GMT, Johannes Bechberger wrote: >> Fix `onthrow` issue by passing the event info to the `initialize` method. >> >> This prevents `jdb` from receiving a broken exception event and throwing an >> internal NullPointerException, upon attaching to the JDWP-agent. > > Jo

Integrated: JDK-8317285: Misspellings in hprof test lib

2023-10-16 Thread Alex Menkov
On Fri, 13 Oct 2023 01:15:58 GMT, Alex Menkov wrote: > The change fixes misspelled "referer" in test/lib/jdk/test/lib/hprof library > The only caller of changed public API is VThreadInHeapDump.java This pull request has now been integrated. Changeset: aed1e810 Author:Alex Menkov URL:

Re: RFR: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818 [v4]

2023-10-16 Thread Alex Menkov
On Sat, 14 Oct 2023 20:17:31 GMT, Hannes Greule wrote: >> See the bug description for more information. >> >> This implementation brings down the time to take a heap dump on the example >> application in the bug report to <2 seconds on my machine. > > Hannes Greule has updated the pull request

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v2]

2023-10-16 Thread Johannes Bechberger
On Mon, 16 Oct 2023 18:16:59 GMT, Johannes Bechberger wrote: >> `ex.catchLocation())` and `ex.thread().frame(0).location()` are valid. > > The problem is that the properties of the `ex.location()` are broken: > > `` > LocationImpl(VirtualMachine vm, > ReferenceTypeImpl dec

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v4]

2023-10-16 Thread Johannes Bechberger
> Fix `onthrow` issue by passing the event info to the `initialize` method. > > This prevents `jdb` from receiving a broken exception event and throwing an > internal NullPointerException, upon attaching to the JDWP-agent. Johannes Bechberger has updated the pull request incrementally with one

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v2]

2023-10-16 Thread Johannes Bechberger
On Mon, 16 Oct 2023 17:51:31 GMT, Johannes Bechberger wrote: >> Ok. It should work so there is a bug somewhere. I'll look into it. In the >> meantime can you verify that ex.catchLocation().method() is valid? > > `ex.catchLocation())` and `ex.thread().frame(0).location()` are valid. The problem

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v2]

2023-10-16 Thread Johannes Bechberger
On Mon, 16 Oct 2023 17:20:57 GMT, Chris Plummer wrote: >> I resolved all the other things you pointed out, but this issue is sticky. > > Ok. It should work so there is a bug somewhere. I'll look into it. In the > meantime can you verify that ex.catchLocation().method() is valid? `ex.catchLocati

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v2]

2023-10-16 Thread Chris Plummer
On Mon, 16 Oct 2023 16:34:40 GMT, Johannes Bechberger wrote: >> `if (!ex.thread().frame(0).location().equals(ex.location())) {` causes an >> exception: >> >> >> java.lang.IllegalArgumentException: Invalid method id: 139869509179824 >> at >> jdk.jdi/com.sun.tools.jdi.ReferenceTypeImpl

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v2]

2023-10-16 Thread Johannes Bechberger
On Mon, 16 Oct 2023 16:22:29 GMT, Johannes Bechberger wrote: >> test/jdk/com/sun/jdi/JdwpOnThrowTest.java line 86: >> >>> 84: if (ex.catchLocation() == null) { >>> 85: throw new RuntimeException("Exception >>> catch location is null")

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v3]

2023-10-16 Thread Johannes Bechberger
> Fix `onthrow` issue by passing the event info to the `initialize` method. > > This prevents `jdb` from receiving a broken exception event and throwing an > internal NullPointerException, upon attaching to the JDWP-agent. Johannes Bechberger has updated the pull request incrementally with one

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v2]

2023-10-16 Thread Johannes Bechberger
On Mon, 16 Oct 2023 15:50:05 GMT, Chris Plummer wrote: >> Johannes Bechberger has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add test case > > test/jdk/com/sun/jdi/JdwpOnThrowTest.java line 86: > >> 84: if (

Re: Serviceability Meetup

2023-10-16 Thread Laurence Cable
Thanks Marcus!!! looking forward to it! - Larry On 10/15/23 1:28 PM, Marcus Hirt wrote: Hi all, Roughly 19 months ago I held an OpenJDK Serviceability Meetup, where a few people (35 in total) from various companies (Oracle, SAP, Red Hat, Datadog, Azul, VMware and more) interested in OpenJDK

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v2]

2023-10-16 Thread Chris Plummer
On Mon, 16 Oct 2023 16:01:39 GMT, Johannes Bechberger wrote: >> Fix `onthrow` issue by passing the event info to the `initialize` method. >> >> This prevents `jdb` from receiving a broken exception event and throwing an >> internal NullPointerException, upon attaching to the JDWP-agent. > > Jo

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option

2023-10-16 Thread Johannes Bechberger
On Wed, 11 Oct 2023 10:44:53 GMT, Johannes Bechberger wrote: > Fix `onthrow` issue by passing the event info to the `initialize` method. > > This prevents `jdb` from receiving a broken exception event and throwing an > internal NullPointerException, upon attaching to the JDWP-agent. I added a

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v2]

2023-10-16 Thread Johannes Bechberger
> Fix `onthrow` issue by passing the event info to the `initialize` method. > > This prevents `jdb` from receiving a broken exception event and throwing an > internal NullPointerException, upon attaching to the JDWP-agent. Johannes Bechberger has updated the pull request incrementally with one

Serviceability Meetup

2023-10-16 Thread Marcus Hirt
Hi all, Roughly 19 months ago I held an OpenJDK Serviceability Meetup, where a few people (35 in total) from various companies (Oracle, SAP, Red Hat, Datadog, Azul, VMware and more) interested in OpenJDK serviceability topics, met to discuss various problems and potential solutions related to Open

Re: RFR: 8318126: Refresh manpages

2023-10-16 Thread Hamlin Li
On Mon, 16 Oct 2023 01:18:52 GMT, David Holmes wrote: > The open nroff manpage files are out of sync with their closed markdown > sources and need to be refreshed. > > The changes to apply are coming from: > > - [JDK-8288158](https://bugs.openjdk.org/browse/JDK-8288158): Add an anchor > to ea

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option

2023-10-16 Thread Johannes Bechberger
On Wed, 11 Oct 2023 10:44:53 GMT, Johannes Bechberger wrote: > Fix `onthrow` issue by passing the event info to the `initialize` method. > > This prevents `jdb` from receiving a broken exception event and throwing an > internal NullPointerException, upon attaching to the JDWP-agent. After the