On Wed, 25 Oct 2023 04:07:12 GMT, Quan Anh Mai wrote:
>> src/hotspot/share/utilities/growableArray.hpp line 213:
>>
>>> 211:
>>> 212: template
>>> 213: int find(T* token, bool f(T*, const E&)) const {
>>
>> What is the advantage of a const reference here?
>
> You can bind a non-const refer
On Wed, 25 Oct 2023 11:27:18 GMT, Johannes Bechberger
wrote:
> Fix race condition in debugger port selection, introduced with
> [JDK-8317920](https://bugs.openjdk.org/browse/JDK-8317920).
>
> Tested on my Mac M1, but it doesn't contain platform-dependent code.
test/jdk/com/sun/jdi/lib/jdb/Deb
On Tue, 24 Oct 2023 12:26:46 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/compiler/compilerOracle.cpp line 650:
>>
>>> 648: } else {
>>> 649: jio_snprintf(errorbuf, buf_size, "MemStat: invalid value
>>> expected 'collect' or 'print' (omitting value means 'collect')");
>>> 650:
On Wed, 25 Oct 2023 08:44:29 GMT, Leo Korinth wrote:
>> This pull request renames `createJavaProcessBuilder` to
>> `createLimitedTestJavaProcessBuilder` and renames `createTestJvm` to
>> `createTestJavaProcessBuilder`. Both are implemented through a private
>> `createJavaProcessBuilder`. It al
On Wed, 25 Oct 2023 20:37:46 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use 64-bit atomic add for incrementing counters
The
On Wed, 25 Oct 2023 21:05:06 GMT, Daniel D. Daugherty
wrote:
> A trivia fix to ProblemList
> java/lang/management/MemoryMXBean/CollectionUsageThreshold.java in Xcomp.
This pull request has now been integrated.
Changeset: a542f739
Author:Daniel D. Daugherty
URL:
https://git.openjdk
A trivia fix to ProblemList
java/lang/management/MemoryMXBean/CollectionUsageThreshold.java in Xcomp.
-
Commit messages:
- 8318843: ProblemList
java/lang/management/MemoryMXBean/CollectionUsageThreshold.java in Xcomp
Changes: https://git.openjdk.org/jdk/pull/16368/files
Webrev: h
On Wed, 25 Oct 2023 21:05:06 GMT, Daniel D. Daugherty
wrote:
> A trivia fix to ProblemList
> java/lang/management/MemoryMXBean/CollectionUsageThreshold.java in Xcomp.
Thanks for fixing this!
-
Marked as reviewed by lmesnik (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/
On Wed, 25 Oct 2023 21:11:01 GMT, Leonid Mesnik wrote:
>> A trivia fix to ProblemList
>> java/lang/management/MemoryMXBean/CollectionUsageThreshold.java in Xcomp.
>
> Thanks for fixing this!
@lmesnik - Thanks for the fast review! Just a ProblemListing and not a fix
though...
-
PR
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request incrementally with one additional
commit since the last revision:
Use 64-bit atomic add for incrementing counters
-
Changes:
- all: https://git.openjdk.org/jdk/pull/1508
> When using 'MemStat' CompileCommand, we accidentally register the command if
> an invalid suboption had been specified. Fixed, added regression test
> (verified).
Thomas Stuefe has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the
> 8315149: Add hsperf counters for CPU time of internal GC threads
Jonathan Joo has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 31 additional commits si
On Wed, 25 Oct 2023 17:23:34 GMT, Chris Plummer wrote:
>> `parseListenAddress()` looks for a fairly specific format:
>>
>> `listenRegexp = Pattern.compile("Listening for transport \\b(.+)\\b at
>> address: \\b(.+)\\b");`
>>
>> However, it does not assume the transport type, so maybe doing that
On Wed, 25 Oct 2023 17:09:09 GMT, Chris Plummer wrote:
>> Making too many not enough assumptions. The other method didn't make
>> assumptions on the format of address and connection type, so I thought that
>> I shouldn't too. I could create a temporary shell file that mimicks the
>> other outp
On Wed, 25 Oct 2023 16:53:18 GMT, Johannes Bechberger
wrote:
>> test/lib/jdk/test/lib/JDWP.java line 60:
>>
>>> 58: if (parts.length != 2) {
>>> 59: return null;
>>> 60: }
>>
>> This is a bit presumptuous in that it assumes that the first 2 token line of
>> output
On Tue, 24 Oct 2023 11:51:45 GMT, Johan Sjölen wrote:
>> I think that NMT is deserving of its own subdirectory. Can we do a review of
>> the changes before I fix the merge conflicts?
>>
>> 1. Moved all the nmt source code from services/ to nmt/
>> 2. Renamed all the include statements and sorte
On Wed, 25 Oct 2023 16:39:31 GMT, Chris Plummer wrote:
>> Fix race condition in debugger port selection, introduced with
>> [JDK-8317920](https://bugs.openjdk.org/browse/JDK-8317920).
>>
>> Tested on my Mac M1, but it doesn't contain platform-dependent code.
>
> test/lib/jdk/test/lib/JDWP.java
On Wed, 25 Oct 2023 11:27:18 GMT, Johannes Bechberger
wrote:
> Fix race condition in debugger port selection, introduced with
> [JDK-8317920](https://bugs.openjdk.org/browse/JDK-8317920).
>
> Tested on my Mac M1, but it doesn't contain platform-dependent code.
test/lib/jdk/test/lib/JDWP.java
On Tue, 24 Oct 2023 09:56:57 GMT, Thomas Schatzl wrote:
> The JEP covers the idea very well, so I'm only covering some implementation
> details here:
>
> * regions get a "pin count" (reference count). As long as it is non-zero, we
> conservatively never reclaim that region even if there is no
The JEP covers the idea very well, so I'm only covering some implementation
details here:
* regions get a "pin count" (reference count). As long as it is non-zero, we
conservatively never reclaim that region even if there is no reference in
there. JNI code might have references to it.
* the JN
On Mon, 23 Oct 2023 08:41:56 GMT, Stefan Karlsson wrote:
>> Hi,
>>
>> Thank you for looking through these changes. I applied your comments and
>> also did a run through to look for incorrectly ordered includes. For the
>> gtest source files I separated the includes in a consistent manner, they
Fix race condition in debugger port selection, introduced with
[JDK-8317920](https://bugs.openjdk.org/browse/JDK-8317920).
Tested on my Mac M1, but it doesn't contain platform-dependent code.
-
Commit messages:
- Fix Debuggee creation
Changes: https://git.openjdk.org/jdk/pull/1635
On Thu, 5 Oct 2023 03:04:39 GMT, Jonathan Joo wrote:
>> Jonathan Joo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add comment and change if defined to ifdef
>
> Resolved comments and sanity checks pass on all builds:
> https://github
On Tue, 24 Oct 2023 09:51:20 GMT, Goetz Lindenmaier wrote:
> …tipleRegistries.java
>
> The test fails in our CI with the message listed here. We see both, aarch and
> x86_64. It happens rarely, but a long time back.
Looks OK to me, but I think the serviceability area reviewers might want to
r
> This pull request renames `createJavaProcessBuilder` to
> `createLimitedTestJavaProcessBuilder` and renames `createTestJvm` to
> `createTestJavaProcessBuilder`. Both are implemented through a private
> `createJavaProcessBuilder`. It also updates the java doc.
>
> This is so that it should be
On Tue, 5 Sep 2023 18:05:34 GMT, Roger Riggs wrote:
>> I have created an alternative that uses enums to force the user to make a
>> decision:
>> https://github.com/openjdk/jdk/compare/master...lkorinth:jdk:+process_tools
>> . Another alternative is to do the same but instead using an enum (I t
26 matches
Mail list logo
