Re: RFR: JDK-8321565: [REDO] Heap dump does not contain virtual Thread stack references

2023-12-12 Thread David Holmes
On Fri, 8 Dec 2023 22:29:12 GMT, Alex Menkov wrote: > Original fix for JDK-8299426 (Heap dump does not contain virtual Thread stack > references, #16665) caused failures of new test (added while #16665 was under > review): > test/hotspot/jtreg/compiler/c2/TestReduceAllocationAndHeapDump.java

Re: RFR: JDK-8321565: [REDO] Heap dump does not contain virtual Thread stack references

2023-12-12 Thread David Holmes
On Wed, 13 Dec 2023 04:59:16 GMT, Alex Menkov wrote: >>> So is the main thread operating in_native whilst doing the merge? I suspect >>> the admonition of not doing the merge at a safepoint actually meant "not a >>> safepoint by the VMThread" as that would cause the whole VM to pause. Even

Re: RFR: JDK-8321565: [REDO] Heap dump does not contain virtual Thread stack references

2023-12-12 Thread Alex Menkov
On Wed, 13 Dec 2023 01:38:03 GMT, Alex Menkov wrote: >>> I.e. merge is performed on main java thread, but VM is at safepoint >> >> So is the main thread operating in_native whilst doing the merge? I suspect >> the admonition of not doing the merge at a safepoint actually meant "not a >>

Re: RFR: JDK-8321565: [REDO] Heap dump does not contain virtual Thread stack references

2023-12-12 Thread Alex Menkov
On Tue, 12 Dec 2023 23:11:41 GMT, David Holmes wrote: > So is the main thread operating in_native whilst doing the merge? I suspect > the admonition of not doing the merge at a safepoint actually meant "not a > safepoint by the VMThread" as that would cause the whole VM to pause. Even > doing

Re: RFR: 8311218: fatal error: stuck in JvmtiVTMSTransitionDisabler::VTMS_transition_disable [v3]

2023-12-12 Thread Leonid Mesnik
On Fri, 8 Dec 2023 11:54:40 GMT, Serguei Spitsyn wrote: >> This fix is for JDK 23 but the intention is to back port it to 22 in RDP-1 >> time frame. >> It is fixing a deadlock issue between `VirtualThread` class critical >> sections with the `interruptLock` (in methods: `unpark()`,

Re: RFR: JDK-8321565: [REDO] Heap dump does not contain virtual Thread stack references

2023-12-12 Thread David Holmes
On Tue, 12 Dec 2023 22:18:33 GMT, Alex Menkov wrote: > I.e. merge is performed on main java thread, but VM is at safepoint So is the main thread operating in_native whilst doing the merge? I suspect the admonition of not doing the merge at a safepoint actually meant "not a safepoint by the

Re: RFR: 8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder [v3]

2023-12-12 Thread Leonid Mesnik
On Mon, 11 Dec 2023 14:06:43 GMT, Stefan Karlsson wrote: >> [JDK-8315097](https://bugs.openjdk.org/browse/JDK-8315097): 'Rename >> createJavaProcessBuilder' changed the name of the ProcessTools helper >> functions used to create `ProcessBuilder`s used to spawn new java test >> processes. >>

Re: RFR: JDK-8321565: [REDO] Heap dump does not contain virtual Thread stack references

2023-12-12 Thread Alex Menkov
On Tue, 12 Dec 2023 21:59:12 GMT, Alex Menkov wrote: >> Prior to the virtual thread changes what thread is performing the merge? >> After these changes what thread would do it if not included in the VM >> operation? >> >> The assert is correct - we should not do the merge at the safepoint (or

Re: RFR: JDK-8321565: [REDO] Heap dump does not contain virtual Thread stack references

2023-12-12 Thread Alex Menkov
On Tue, 12 Dec 2023 07:06:07 GMT, David Holmes wrote: > Prior to the virtual thread changes what thread is performing the merge? Prior the change merge is performed on either AttachListener thread (when it's the current thread - special case for tools like jcmd) or on VMThread (if the current

Re: RFR: 8314029: Add file name parameter to Compiler.perfmap [v8]

2023-12-12 Thread Evgeny Astigeevich
On Mon, 11 Dec 2023 22:41:56 GMT, Yi-Fan Tsai wrote: >> `jcmd Compiler.perfmap` uses the hard-coded file name for a perf map: >> `/tmp/perf-%d.map`. This change adds an optional argument for specifying a >> file name. >> >> `jcmd PID help Compiler.perfmap` shows the following usage. >> >>

Re: RFR: JDK-8320890: [AIX] Find a better way to mimic dl handle equality [v4]

2023-12-12 Thread Joachim Kern
> On AIX, repeated calls to dlopen referring to the same shared library may > result in different, unique dl handles to be returned from libc. In that it > differs from typical libc implementations that cache dl handles. > > This causes problems in the JVM with code that assumes equality of

Integrated: 8321729: Remove 'orb' field in RMIConnector

2023-12-12 Thread Kevin Walls
On Mon, 11 Dec 2023 12:50:38 GMT, Kevin Walls wrote: > Tidyup change, looks like this field was not removed when IIOP was removed > from RMIConnector. > > The field is not required for interoperability: > with the field removed, I can still connect an older JMX client to a running > app with

Re: RFR: 8321729: Remove 'orb' field in RMIConnector

2023-12-12 Thread Kevin Walls
On Mon, 11 Dec 2023 12:50:38 GMT, Kevin Walls wrote: > Tidyup change, looks like this field was not removed when IIOP was removed > from RMIConnector. > > The field is not required for interoperability: > with the field removed, I can still connect an older JMX client to a running > app with

Integrated: 8311306: Test com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java failed: out of expected range

2023-12-12 Thread Kevin Walls
On Mon, 11 Dec 2023 11:33:08 GMT, Kevin Walls wrote: > Trivial test update to run in "othervm". This test has failed due to > interrupted threads: the interruption interferes with timing, but also the > test is designed to fail if interrupted. > > Other tests in the same directory have the

Re: RFR: 8311306: Test com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java failed: out of expected range

2023-12-12 Thread Kevin Walls
On Mon, 11 Dec 2023 11:33:08 GMT, Kevin Walls wrote: > Trivial test update to run in "othervm". This test has failed due to > interrupted threads: the interruption interferes with timing, but also the > test is designed to fail if interrupted. > > Other tests in the same directory have the