On Thu, 15 Feb 2024 19:55:08 GMT, Serguei Spitsyn wrote:
>> The implementation of the JVM TI `GetObjectMonitorUsage` does not match the
>> spec.
>> The function returns the following structure:
>>
>>
>> typedef struct {
>> jthread owner;
>> jint entry_count;
>> jint waiter_count;
>
On Thu, 15 Feb 2024 08:46:43 GMT, Serguei Spitsyn wrote:
> This enhancement replaces uses of NULL with nullptr in the XML-description
> files for JVMTI. These are the files `hotsport/share/prims/jvmti.xml` and
> `hotspot/share/prims/jvmti*.xls`.
>
> The following files are auto-generated from
On Thu, 15 Feb 2024 17:50:23 GMT, Suchismith Roy wrote:
> > Hi,
> > some remarks:
> >
> > * there is no need for a copy for the first call to dll_load_library. Just
> > hand in the string 1:1.
> > * I would only do the *.a fallback loading if the error indicates that the
> > *.so file had not
On Thu, 15 Feb 2024 08:46:43 GMT, Serguei Spitsyn wrote:
> This enhancement replaces uses of NULL with nullptr in the XML-description
> files for JVMTI. These are the files `hotsport/share/prims/jvmti.xml` and
> `hotspot/share/prims/jvmti*.xls`.
>
> The following files are auto-generated from
On Thu, 15 Feb 2024 04:04:19 GMT, Chris Plummer wrote:
> The test is odd in a couple of ways. The first is it's in the SA test
> directory, yet is also meant as a VM heap dump test. If someone were to make
> changes to the VM heapdump code and run the VM heapdump tests, this test
> would not g
On Thu, 15 Feb 2024 12:19:31 GMT, Magnus Ihse Bursie wrote:
> Since jcheck only checks file in a commit, there is a possibility of us
> getting files in the repository that would not be accepted by jcheck. This
> can happen when extending the set of files checked by jcheck, or if jcheck
> chan
On Thu, 15 Feb 2024 13:15:51 GMT, Aleksey Shipilev wrote:
> When I proposed this change 10 years ago, there was a push back:
> https://bugs.openjdk.org/browse/JDK-8005604.
>
> Is it resolved now?
Thank you for the link @shipilev.
I've read the discussion, my understanding that main concern was
On Thu, 8 Feb 2024 23:30:01 GMT, Leonid Mesnik wrote:
> Tests updated to use jtreg vm flags.
> Tested by running tests with different flags and tier1.
This pull request has now been integrated.
Changeset: 9029bf64
Author:Leonid Mesnik
URL:
https://git.openjdk.org/jdk/commit/9029bf64
On Thu, 15 Feb 2024 12:19:31 GMT, Magnus Ihse Bursie wrote:
> Since jcheck only checks file in a commit, there is a possibility of us
> getting files in the repository that would not be accepted by jcheck. This
> can happen when extending the set of files checked by jcheck, or if jcheck
> chan
On Thu, 8 Feb 2024 23:30:01 GMT, Leonid Mesnik wrote:
> Tests updated to use jtreg vm flags.
> Tested by running tests with different flags and tier1.
Marked as reviewed by sspitsyn (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/17781#pullrequestreview-1883994215
On Thu, 8 Feb 2024 23:30:01 GMT, Leonid Mesnik wrote:
> Tests updated to use jtreg vm flags.
> Tested by running tests with different flags and tier1.
Looks good.
-
Marked as reviewed by cjplummer (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17781#pullrequestreview-1883
On Thu, 15 Feb 2024 19:55:08 GMT, Serguei Spitsyn wrote:
>> The implementation of the JVM TI `GetObjectMonitorUsage` does not match the
>> spec.
>> The function returns the following structure:
>>
>>
>> typedef struct {
>> jthread owner;
>> jint entry_count;
>> jint waiter_count;
>
> The implementation of the JVM TI `GetObjectMonitorUsage` does not match the
> spec.
> The function returns the following structure:
>
>
> typedef struct {
> jthread owner;
> jint entry_count;
> jint waiter_count;
> jthread* waiters;
> jint notify_waiter_count;
> jthread
On Thu, 15 Feb 2024 17:28:52 GMT, Andy Goryachev wrote:
>> Please do not replace those tabs with spaces as they are intentional for
>> testing the runtime to safely ignore them. I suggest replacing them with
>> Unicode escapes (`\u000b`)
>
> `\u000b` is VT (vertical tab)
> `\u0009` or `\t`
On Thu, 15 Feb 2024 08:15:16 GMT, Thomas Stuefe wrote:
> Hi,
>
> some remarks:
>
> * there is no need for a copy for the first call to dll_load_library. Just
> hand in the string 1:1.
> * I would only do the *.a fallback loading if the error indicates that the
> *.so file had not been there.
On Thu, 15 Feb 2024 17:09:17 GMT, Naoto Sato wrote:
>> All the java/util/Currency tests pass. I also searched the code for "ZZ" but
>> could not find any references in the test.
>
> Please do not replace those tabs with spaces as they are intentional for
> testing the runtime to safely ignore t
On Thu, 15 Feb 2024 15:48:38 GMT, Magnus Ihse Bursie wrote:
>> This looks weird indeed. Luckily it's just test code. Did you run the test
>> after this change?
>
> All the java/util/Currency tests pass. I also searched the code for "ZZ" but
> could not find any references in the test.
Please d
On Thu, 15 Feb 2024 14:01:46 GMT, Erik Joelsson wrote:
>> test/jdk/java/util/Currency/currency.properties line 18:
>>
>>> 16: SB=EUR,111,2, 2099-01-01T00:00:00
>>> 17: US=euR,978,2,2001-01-01T00:00:00
>>> 18: ZZ = ZZZ , 999 , 3
>>
>> This looks weird, but so did t
On Thu, 15 Feb 2024 12:26:11 GMT, Magnus Ihse Bursie wrote:
>> Since jcheck only checks file in a commit, there is a possibility of us
>> getting files in the repository that would not be accepted by jcheck. This
>> can happen when extending the set of files checked by jcheck, or if jcheck
>>
On Thu, 15 Feb 2024 02:45:26 GMT, Alex Menkov wrote:
>> The fix updates heap dumpers to report correct instance size value for
>> HPROF_GC_CLASS_DUMP records (currently it's reported as size of all instance
>> fields)
>>
>> Testing: tier1, tier2, tier5-svc
>
> Alex Menkov has updated the pull
On Thu, 15 Feb 2024 12:19:31 GMT, Magnus Ihse Bursie wrote:
> Since jcheck only checks file in a commit, there is a possibility of us
> getting files in the repository that would not be accepted by jcheck. This
> can happen when extending the set of files checked by jcheck, or if jcheck
> chan
Since jcheck only checks file in a commit, there is a possibility of us getting
files in the repository that would not be accepted by jcheck. This can happen
when extending the set of files checked by jcheck, or if jcheck changes how it
checks files (perhaps due to bug fixes).
I have now run jc
On Wed, 14 Feb 2024 01:52:16 GMT, David Holmes wrote:
>> Thank you for the comment, David.
>> Now the test checks:
>> - the threads waiting to enter the monitor are returned correctly with all
>> permutations of threads waiting to be notified and threads waiting to
>> re-enter the monitor
>> In
On Wed, 14 Feb 2024 13:15:27 GMT, Albert Mingkun Yang wrote:
> Relocate `Generation.java` to mirror the structure in hotspot. Also,
> specialize the logic to two concrete generations.
>
> Test: tier1-3
This pull request has now been integrated.
Changeset: 2b1a8400
Author:Albert Mingkun Ya
On Wed, 14 Feb 2024 20:17:21 GMT, Albert Mingkun Yang wrote:
>> Relocate `Generation.java` to mirror the structure in hotspot. Also,
>> specialize the logic to two concrete generations.
>>
>> Test: tier1-3
>
> Albert Mingkun Yang has updated the pull request incrementally with three
> addition
On Wed, 14 Feb 2024 20:17:21 GMT, Albert Mingkun Yang wrote:
>> Relocate `Generation.java` to mirror the structure in hotspot. Also,
>> specialize the logic to two concrete generations.
>>
>> Test: tier1-3
>
> Albert Mingkun Yang has updated the pull request incrementally with three
> addition
This enhancement replaces uses of NULL with nullptr in the XML-description
files for JVMTI. These are the files `hotsport/share/prims/jvmti.xml` and
`hotspot/share/prims/jvmti*.xls`.
The following files are auto-generated from the `jvmti.xml` and `*.xsl files`
in the `build//variant-server/gens
On Mon, 12 Feb 2024 18:04:21 GMT, Suchismith Roy wrote:
>> J2SE agent does not start and throws error when it tries to find the shared
>> library ibm_16_am.
>> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load
>> fails.It fails to identify the shared library ibm_16_am
28 matches
Mail list logo
