On Mon, 18 Mar 2024 13:14:41 GMT, Richard Reingruber wrote:
>> This pr changes `JfrJvmtiAgent::retransform_classes()` and
>> `jfr_set_enabled` to switch to `WXWrite` before transitioning to the vm.
>>
>> Testing:
>> make test TEST=jdk/jfr/event/runtime/TestClassLoadEvent.java
>> TEST_VM_OPTS=
On Mon, 18 Mar 2024 23:45:29 GMT, Serguei Spitsyn wrote:
>> Please, review this fix correcting the JVMTI `RawMonitorWait()`
>> implementation.
>> The `RawMonitorWait()` is using the the `jt->is_interrupted(true)` to
>> update the interrupt status of the interrupted waiting thread. The issue
> The `JvmtiHandshake` and `JvmtiUnitedHandshakeClosure` classes were
> introduced in the JDK 22 to unify/simplify the JVM TI functions supporting
> implementation of the virtual threads. This enhancement is to refactor JVM TI
> functions `GetOwnedMonitorInfo` and `GetOwnedMonitorStackDepthInfo`
On Mon, 18 Mar 2024 11:10:47 GMT, Serguei Spitsyn wrote:
>> Maybe `is_interrupted_with_reset`? (though that would seem like an alias
>> for `is_interrupted(true)`.
>
> Thanks, Alan and David. Will consider your suggestions.
Renamed now.
-
PR Review Comment: https://git.openjdk.or
> Please, review this fix correcting the JVMTI `RawMonitorWait()`
> implementation.
> The `RawMonitorWait()` is using the the `jt->is_interrupted(true)` to update
> the interrupt status of the interrupted waiting thread. The issue is that
> when it calls `jt->is_interrupted(true)` to fetch an
On Mon, 18 Mar 2024 16:47:24 GMT, Bill Huang wrote:
> This task addresses an essential aspect of our testing infrastructure: the
> proper handling and cleanup of temporary files and socket files created
> during test execution. The motivation behind these changes is to prevent the
> accumulati
This task addresses an essential aspect of our testing infrastructure: the
proper handling and cleanup of temporary files and socket files created during
test execution. The motivation behind these changes is to prevent the
accumulation of unnecessary files in the default temporary directory, wh
Please review this cleanup PR which removes per-thread compiler stats from
`sun.management`
This removes:
* The deprecated interface method
`HotspotCompilationMBean.getCompilerThreadStats()` along with the
implementation method in `HotspotCompilation`
* The class returned by these methods, `Co
Would that be okay with you?
Absolutely!
On Mon, Mar 18, 2024 at 2:31 PM Kevin Walls wrote:
> Right, the existing Deprecated tag had me thinking this was a Java SE
> interface that had begun the deprecation process.
>
> But it's not a published API.
>
Great, it seems we have consensus that we can go ahead and remove these
deprecated me
Right, the existing Deprecated tag had me thinking this was a Java SE interface
that had begun the deprecation process.
But it's not a published API.
Maybe we can go further: HotspotCompilationMBean and HotspotInternalMBean look
unused. They are not exposed in the standard PlatformMBeanServer.
> This pr changes `JfrJvmtiAgent::retransform_classes()` and `jfr_set_enabled`
> to switch to `WXWrite` before transitioning to the vm.
>
> Testing:
> make test TEST=jdk/jfr/event/runtime/TestClassLoadEvent.java
> TEST_VM_OPTS=-XX:+AssertWXAtThreadSync
> make test TEST=compiler/intrinsics/klass
On Mon, 18 Mar 2024 02:21:40 GMT, David Holmes wrote:
>> src/hotspot/share/runtime/javaThread.cpp line 596:
>>
>>> 594: // Checks and clears the interrupt status for platform or virtual
>>> thread.
>>> 595: // Used by the JVMTI RawMonitorWait only.
>>> 596: bool JavaThread::is_interrupted() {
>
On Mon, 18 Mar 2024 02:23:44 GMT, David Holmes wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: made current changes limitedto just RawMonitorWait
>
> src/hotspot/share/runtime/javaThread.cpp line 595:
>
On Mon, 18 Mar 2024 04:43:02 GMT, David Holmes wrote:
>> The `JvmtiHandshake` and `JvmtiUnitedHandshakeClosure` classes were
>> introduced in the JDK 22 to unify/simplify the JVM TI functions supporting
>> implementation of the virtual threads. This enhancement is to refactor JVM
>> TI functio
Similar to [JDK-8328157](https://bugs.openjdk.org/browse/JDK-8328157), we want
to move the setting of LDFLAGS to LDFLAGS_JDK[LIB/EXE into SetupJdkLibrary and
SetupJdkExecutable.
-
Commit messages:
- 8328177: Move LDFLAGS_JDK[LIB/EXE] to JdkNativeCompilation.gmk
Changes: https://gi
On Fri, 15 Mar 2024 13:58:15 GMT, Tobias Holenstein
wrote:
> > As I wrote in JBS, shouldn't this be handled by `ThreadInVMfromNative`?
>
> I agree. This is something I am investigating at the moment. Ideally,
> AssertWXAtThreadSync would also be true by default.
I've added a bunch more locati
> This pr changes `JfrJvmtiAgent::retransform_classes()` and `jfr_set_enabled`
> to switch to `WXWrite` before transitioning to the vm.
>
> Testing:
> make test TEST=jdk/jfr/event/runtime/TestClassLoadEvent.java
> TEST_VM_OPTS=-XX:+AssertWXAtThreadSync
> make test TEST=compiler/intrinsics/klass
18 matches
Mail list logo
