Re: RFR: 8330969: scalability issue with loaded JVMTI agent [v2]

2024-05-10 Thread Daniel D . Daugherty
On Tue, 30 Apr 2024 01:49:31 GMT, Serguei Spitsyn wrote: >> src/hotspot/share/prims/jvmtiThreadState.cpp line 366: >> >>> 364: attempts--; >>> 365: } >>> 366: DEBUG_ONLY(if (attempts == 0) break;) >> >> Previously `_VTMS_transition_count` considered all threads at the

Re: RFR: 8332042: Move MEMFLAGS to its own include file

2024-05-10 Thread Thomas Stuefe
On Fri, 10 May 2024 09:06:08 GMT, Thomas Stuefe wrote: > MEMFLAGS, as well as its enum constants, should live in its own include. > > The constants are used throughout the code base, often without needing the > allocation APIs exposed through allocation.hpp. > > The MEMFLAGS enum def is often

RFR: 8332042: Move MEMFLAGS to its own include file

2024-05-10 Thread Thomas Stuefe
MEMFLAGS, as well as its enum constants, should live in its own include. The constants are used throughout the code base, often without needing the allocation APIs exposed through allocation.hpp. The MEMFLAGS enum def is often needed within NMT itself, again often without needing allocation.hp

Re: RFR: 8331557: Serial: Refactor SerialHeap::do_collection [v6]

2024-05-10 Thread Albert Mingkun Yang
> It's probably easier to read the new code directly. The two classes in > `serialVMOperations` serve as entrance points to invoke young/full GCs. Some > previously hidden decisions are made more obvious, e.g. if a young-gc fails > (or will probablly fail), fallback to full-gc. > > Additionally

Re: RFR: 8331557: Serial: Refactor SerialHeap::do_collection [v5]

2024-05-10 Thread Guoxiong Li
On Wed, 8 May 2024 10:04:15 GMT, Albert Mingkun Yang wrote: >> It's probably easier to read the new code directly. The two classes in >> `serialVMOperations` serve as entrance points to invoke young/full GCs. Some >> previously hidden decisions are made more obvious, e.g. if a young-gc fails >