Re: RFR: 8356870: HotSpotDiagnosticMXBean.dumpThreads and jcmd Thread.dump_to_file updates [v2]

2025-05-24 Thread Alan Bateman
On Sun, 25 May 2025 06:00:07 GMT, Alan Bateman wrote: >> src/hotspot/share/classfile/javaClasses.cpp line 5519: >> >>> 5517: oop >>> java_util_concurrent_locks_AbstractOwnableSynchronizer::get_owner_threadObj(oop >>> obj) { >>> 5518: assert(_owner_offset != 0, "Must be initialized"); >>> 551

Re: RFR: 8356870: HotSpotDiagnosticMXBean.dumpThreads and jcmd Thread.dump_to_file updates

2025-05-24 Thread Alan Bateman
On Sun, 25 May 2025 05:08:12 GMT, Chen Liang wrote: >> Updates the thread dump generated by HotSpotDiagnosticMXBean.dumpThreads and >> jcmd Thread.dump_to_file to include thread state and lock information. Also >> update the HotSpotDiagnosticMXBean.dumpThreads API description to link to a >> d

Re: RFR: 8356870: HotSpotDiagnosticMXBean.dumpThreads and jcmd Thread.dump_to_file updates [v2]

2025-05-24 Thread Alan Bateman
> Updates the thread dump generated by HotSpotDiagnosticMXBean.dumpThreads and > jcmd Thread.dump_to_file to include thread state and lock information. Also > update the HotSpotDiagnosticMXBean.dumpThreads API description to link to a > description of the JSON format dump as that format is inten

Re: RFR: 8356870: HotSpotDiagnosticMXBean.dumpThreads and jcmd Thread.dump_to_file updates

2025-05-24 Thread Alan Bateman
On Sun, 25 May 2025 05:16:36 GMT, Chen Liang wrote: >> Updates the thread dump generated by HotSpotDiagnosticMXBean.dumpThreads and >> jcmd Thread.dump_to_file to include thread state and lock information. Also >> update the HotSpotDiagnosticMXBean.dumpThreads API description to link to a >> d

Re: RFR: 8356870: HotSpotDiagnosticMXBean.dumpThreads and jcmd Thread.dump_to_file updates

2025-05-24 Thread Chen Liang
On Sat, 24 May 2025 09:33:13 GMT, Shaojin Wen wrote: >> Updates the thread dump generated by HotSpotDiagnosticMXBean.dumpThreads and >> jcmd Thread.dump_to_file to include thread state and lock information. Also >> update the HotSpotDiagnosticMXBean.dumpThreads API description to link to a >>

Re: RFR: 8356870: HotSpotDiagnosticMXBean.dumpThreads and jcmd Thread.dump_to_file updates

2025-05-24 Thread Chen Liang
On Sat, 24 May 2025 06:57:56 GMT, Alan Bateman wrote: > Updates the thread dump generated by HotSpotDiagnosticMXBean.dumpThreads and > jcmd Thread.dump_to_file to include thread state and lock information. Also > update the HotSpotDiagnosticMXBean.dumpThreads API description to link to a > des

Re: RFR: 8352075: Perf regression accessing fields [v8]

2025-05-24 Thread John R Rose
On Thu, 22 May 2025 08:21:38 GMT, Radim Vansa wrote: >> This optimization is a followup to https://github.com/openjdk/jdk/pull/24290 >> trying to reduce the performance regression in some scenarios introduced in >> https://bugs.openjdk.org/browse/JDK-8292818 . Based both on performance and >>

Re: RFR: 8352075: Perf regression accessing fields [v8]

2025-05-24 Thread John R Rose
On Thu, 22 May 2025 08:21:38 GMT, Radim Vansa wrote: >> This optimization is a followup to https://github.com/openjdk/jdk/pull/24290 >> trying to reduce the performance regression in some scenarios introduced in >> https://bugs.openjdk.org/browse/JDK-8292818 . Based both on performance and >>

VirtualMachineImpl.checkCatchesAndSendQuitTo leaks file handles

2025-05-24 Thread Philippe Marschall
Hello I believe sun.tools.attach.VirtualMachineImpl#checkCatchesAndSendQuitTo on Linux leaks file handles after JDK-8327114 [1]. The issue is the line 361 [2] final var cmdline = Files.lines(procPid.resolve("cmdline")).findFirst(); Because the Stream is not closed the file handle is not clos

Re: RFR: 8352075: Perf regression accessing fields [v5]

2025-05-24 Thread John R Rose
On Tue, 20 May 2025 23:01:08 GMT, John R Rose wrote: >> This change adds smaller "fast-forward" table to accelerate random-access >> queries within a larger stream. >> >> I am not against this change, but I think it should be refactored (either >> now or later) into a library that can be used

Re: RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v5]

2025-05-24 Thread Markus Grönlund
On Sat, 24 May 2025 15:19:52 GMT, Markus Grönlund wrote: >> Johannes Bechberger has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix compilation > > src/hotspot/share/jfr/support/jfrThreadLocal.hpp line 103: > >> 101: volatile CPUTimeL

Re: RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v5]

2025-05-24 Thread Markus Grönlund
On Fri, 23 May 2025 21:20:39 GMT, Johannes Bechberger wrote: >> This is the code for the [JEP 509: CPU Time based profiling for >> JFR](https://openjdk.org/jeps/509). >> >> Currently tested using [this test >> suite](https://github.com/parttimenerd/basic-profiler-tests). This runs >> profile

Re: RFR: 8356870: HotSpotDiagnosticMXBean.dumpThreads and jcmd Thread.dump_to_file updates

2025-05-24 Thread Shaojin Wen
On Sat, 24 May 2025 06:57:56 GMT, Alan Bateman wrote: > Updates the thread dump generated by HotSpotDiagnosticMXBean.dumpThreads and > jcmd Thread.dump_to_file to include thread state and lock information. Also > update the HotSpotDiagnosticMXBean.dumpThreads API description to link to a > des

Re: RFR: 8356870: HotSpotDiagnosticMXBean.dumpThreads and jcmd Thread.dump_to_file updates

2025-05-24 Thread Shaojin Wen
On Sat, 24 May 2025 06:57:56 GMT, Alan Bateman wrote: > Updates the thread dump generated by HotSpotDiagnosticMXBean.dumpThreads and > jcmd Thread.dump_to_file to include thread state and lock information. Also > update the HotSpotDiagnosticMXBean.dumpThreads API description to link to a > des

Re: RFR: 8356222: Thread.print command reports waiting on the Class initialization monitor for both carrier and virtual threads

2025-05-24 Thread Alan Bateman
On Wed, 21 May 2025 20:35:33 GMT, Alex Menkov wrote: > The change fixes "Thread.print" diagnostic command when mounted virtual > thread is waiting on the class initialization monitor. > > Testing: new test, tier1 sanity run test/hotspot/jtreg/serviceability/dcmd/thread/ClassInitMonitorVThread.

RFR: 8356870: HotSpotDiagnosticMXBean.dumpThreads and jcmd Thread.dump_to_file updates

2025-05-24 Thread Alan Bateman
Updates the thread dump generated by HotSpotDiagnosticMXBean.dumpThreads and jcmd Thread.dump_to_file to include thread state and lock information. Also update the HotSpotDiagnosticMXBean.dumpThreads API description to link to a description of the JSON format dump as that format is intended to b